Commit Graph

174 Commits

Author SHA1 Message Date
Tomasz Wasilczyk
353d4c5c75 Use String8/16 c_str [camera]
Bug: 295394788
Test: make checkbuild
Change-Id: I7ca371112e891f4f40673b5c34e3b8ccc41841bf
Merged-In: I7ca371112e891f4f40673b5c34e3b8ccc41841bf
2023-08-24 17:07:46 +00:00
Treehugger Robot
1c8377c24c Merge "Camera: VTS: Wait for release fence before consuming buffers" into android13-tests-dev 2023-04-05 17:10:33 +00:00
Shuzhen Wang
72f97643fb Camera: Fix VTS failure for depth only camera
If the device is depth-only, use threshold with Y16 format rather than
IMPLEMENTATION_DEFINED.

This fixes the regression introduced by the fix for b/265984260.

Bug: 276957901
Test: atest VtsAidlHalCameraProvider_TargetTest
Change-Id: If9023f1ed17bb761abbb9be36e567264f8bf0689
2023-04-04 20:57:27 +00:00
Shuzhen Wang
0f56c56709 Camera: VTS: Wait for release fence before consuming buffers
The camera HAL may signal release fence after processCaptureResult.
If the VTS test waits for the release fence in the context of the
capture result, there is possibility of deadlock.

Rather, we should wait for the releaseFence in a different thread
context to really emulate the real application behavior.

Test: atest VtsAidlHalCameraProvider_TargetTest
Bug: 241281568
Change-Id: Id1d92e901aae1cab084846d252ef090fcda182d7
2023-04-04 16:45:28 +00:00
Shuzhen Wang
cd3c483ab0 Camera VTS: Remove unnecessary test of Y16 depth format
getAvailableOutputStreams() shouldn't unconditionally add Y16 stream
configurations. Instead, if the threshold being passed in is valid,
getAvailableOutputStreams() should use the threshold's format
instead.

Test: Run VTS on pixel; vendor testing.
Bug: 265984260
Change-Id: I3c8119c6032141bb6e2f95f060f014a13340d16b
2023-02-08 21:56:51 +00:00
kongchenrui
7549241c15 Fix the problem that the data field of Entry in the verifyLogicalOrUltraHighResCameraMetadata function is empty
The reason for this problem is: local variables are used when saving
PhysicalCameraCharacteristics. When its life cycle ends, physChars will
be released. Since Entry uses a pointer, data will be null. So physChars
should be defined outside else to ensure that physChars is not released
during use

Bug: 248221707
Test: VtsHalCameraProviderV2_4TargetTest
Test: VtsAidlHalCameraProvider_TargetTest
Signed-off-by: kongchenrui <kongchenrui@xiaomi.com>
Change-Id: I4c05e695d255f210f310f8ce78ec2fa71a42cee9
2022-09-28 20:35:55 +00:00
Jayant Chowdhary
9ab187f118 Delete HIDL 3.8
- HIDL camera device@3.8, metadata@3.8 were temporary interfaces

Bug: 221108824

Test: GCA
Test: Camera CTS

Merged-In: I44cd1ac0e2f6647e3e9d5c60a535faf716d5ed93
Change-Id: I44cd1ac0e2f6647e3e9d5c60a535faf716d5ed93
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
(cherry picked from commit 406da44909)
2022-05-25 23:43:33 +00:00
Shuzhen Wang
36efa7161a Camera: Increase bit depth of stream use case to 64
Test: Camera CTS
Bug: 223387965
Change-Id: I23a4324602ed37cf38c7a1a34dade615c4adb72b
2022-03-09 22:57:40 +00:00
Emilian Peev
4ce76d242c Camera: Use 64bit integers for dynamic range profile values
Additionally extend the dynamic range profile map to include
hints about extra lookahead latency.

Bug: 215396395
Test: Camera CTS
Change-Id: I600a3147d94a9aad1a312b92aacee014c05db16f
2022-02-23 00:26:22 +00:00
Rucha Katakwar
18aa2d952b Camera: Update constrained HFR VTS test.
Added a check that HAL does not advertise multiple preview rates for
the same recording rate and size.

Bug: 200310682

Change-Id: Ia213f152ad00c846a533577e552b668efdde6f3d
2022-02-15 16:38:25 -08:00
Shuzhen Wang
7267abff25 Camera: Add stream use case API
- Add availableStreamUseCase static metadata tag
- Add STREAM_USE_CASE camera capability
- Add useCase flag in camera stream interface

Test: atest VtsHalCameraProviderV2_4TargetTest
Bug: 200307880
Change-Id: I4e473edcb52a97fa0e1b27cf94603cf9f9984f82
2022-02-03 17:46:44 -08:00
TreeHugger Robot
714f9596c3 Merge "Camera: VTS: Remove GRF MultiCamera for Android 12" 2022-01-20 05:49:39 +00:00
Shuzhen Wang
ea3ab4f3f3 Camera: VTS: Remove GRF MultiCamera for Android 12
Certain OEMs' new S launches with vendor freeze cannot implement
multi-camera API.

Test: Build
Bug: 189053514
Bug: 211709637
Change-Id: I71b46f1e8343a5848cbe3fa55bbcd427c87b05dd
(cherry picked from commit 30a198ded0)
2022-01-19 13:21:42 -08:00
Emilian Peev
b5f634fc37 Camera: Add device 3.8 and HDR10 native APIs
Initial set of native API extensions to support 10-bit
output capable device:
- Identification
- Configuration
- Data plumbing

Bug: 195946346
Test: adb shell
/data/nativetest64/VtsHalCameraProviderV2_4TargetTest/VtsHalCameraProviderV2_4TargetTest
--gtest_filter=PerInstance/CameraHidlTest.process10BitDynamicRangeRequest/0_internal_0

Change-Id: I526120944232ce211259cbd215935db7e445a6c5
2022-01-05 15:46:50 -08:00
Jayant Chowdhary
c40bae7dc8 Merge "VTS test for previewStabilization" 2021-12-29 19:52:56 +00:00
Jayant Chowdhary
bf39d4db34 VTS test for previewStabilization
Bug: 200197440

Test: VtsHalCameraProviderV2_4TargetTest
     --gtest_filter=PerInstance/CameraHidlTest.processCaptureRequestPreviewStab*

Change-Id: Iba71983a69d20af605924fa6f1c0697e49d911f8
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2021-12-15 14:41:03 -08:00
Rucha Katakwar
5ad93755c8 Camera: Add 3.8 version of ICameraDevice.
The new version of ICameraDevice supports interfaces for torch
strength control feature. New VTS test has been added to test the
emulator HAL-side implementation of the newly added interfaces.

bug: 200174275

Test: Camera VTS test pass.
Change-Id: Ia5652a96e09bd716b5079fe9ed071dffc53b5b12
2021-12-13 12:02:51 -08:00
Shuzhen Wang
8136c00c7e Camera: Update readoutTimeout requirement
Due to sensor crop, readoutTimeout - startOfExposure may be larger than
exposureTime. Update the VTS test to reflect the spec change.

Test: processCaptureRequestPreview
Bug: 208270993
Change-Id: I51a373ecbc5c7c086f84c5479a43dffbe8fcc0c2
2021-12-01 18:34:03 -08:00
Shuzhen Wang
cd9af6c1ce Camera: Add version 3.8 of ICameraDeviceCallback
The new version of ICameraDeviceCallback supports shutter notify with readout
timestamp.

The readout timestamp is used to re-time viewfinder frames to reduce
jitter. When camera runs at fixed frame rate, the start_of_exposure time
intervals may change, but start_or_readout intervals are constant.

Test: Camera VTS test
Bug: 189380857
Change-Id: I4c3856a4e30caa8cdf8417d437de1de3190c6fd6
2021-11-17 13:48:10 -08:00
Shuzhen Wang
5ee43a6d24 Camera: VTS for test_pattern tag requirement for physical camera
Ensure that if TEST_PATTERN_MODE is listed in physical request keys, the
corresponding physical camera must support the privacy related test
pattern modes.

Test: Run Camera VTS with Cuttlefish emulator
Bug: 204108650
Change-Id: I8f378ab642c7c010a2ba73a8e89e65c91ba780eb
2021-11-03 22:56:16 +00:00
TreeHugger Robot
3c2ebae81c Merge "VtsHalCameraProviderV2_4TargetTest: Override rotate&crop" into sc-v2-dev 2021-11-02 19:06:21 +00:00
Shuzhen Wang
dc6da704ed Camera: Adjust VTS test to relax multi-camera requirement
The multi-camera Grf requirement is now only applicable to rear facing
camera.

Test: Run test on Pixel devices
Bug: 204252005
Change-Id: Idb7735eebdc104f6ee6a5946b50c11aea809eb85
2021-10-29 11:24:03 -07:00
Emilian Peev
06ec563f55 VtsHalCameraProviderV2_4TargetTest: Override rotate&crop
As per documentation the default auto rotate&crop mode must
be overriden before passing the capture request back to the
camera provider.

Bug: 204407427
Test:
atest
VtsHalCameraProviderV2_4TargetTest:PerInstance/CameraHidlTest#processCaptureRequestPreview/0_internal_0
atest
VtsHalCameraProviderV2_4TargetTest:PerInstance/CameraHidlTest#processMultiCaptureRequestPreview/0_internal_0
atest
VtsHalCameraProviderV2_4TargetTest:PerInstance/CameraHidlTest#processCaptureRequestBurstISO/0_internal_0
atest
VtsHalCameraProviderV2_4TargetTest:PerInstance/CameraHidlTest#flushPreviewRequest/0_internal_0

Change-Id: I1e1d387a04add8be9a281fcc3f78a867990248b3
2021-10-28 17:49:19 -07:00
Emilian Peev
3387f1c84e Camera: Add static metadata that can map device state to orientation
Allow camera providers to advertise the mapping between device state
and camera orientation.

Bug: 201005727
Test: VtsHalCameraProviderV2_4TargetTest
--gtest_filter=PerInstance/CameraHidlTest.getCameraCharacteristics/0_internal_0

Change-Id: Ibb035f4dc3d8af1106ac08f86e43b953ddcbf55b
2021-10-06 16:42:25 -07:00
Shuzhen Wang
208ed2af02 Camera: VTS: Set proper dataSpace for reprocessing test
Set proper dataSpace for reprocessing output stream.

Bug: 199483381
Test: Camera VTS test on Pixel 4 and Cuttlefish
Change-Id: I6ac96fc65abf4332f3f248b9aed0e3a7ea88d57c
2021-09-20 23:53:58 +00:00
Shuzhen Wang
3ed299dfca Camera: Add logical camera requirement test for GVF
The test verifies that if more than one color camera is available for a
particular facing, a logical mulit-camera must be supported consisting
all color cameras facing that direction.

Test: Run VTS test on Pixel4 and cuttlefish emulator
Bug: 178633246
Change-Id: I7b02a4057064a7f4a236c1bbc49f768ac80232cf
2021-07-08 11:03:24 -07:00
Cliff Wu
ee49e56f26 [VTS] Add test cases for ICameraInjectionSession.hal
- Add test cases for ICameraInjectionSession.hal in VtsHalCameraProviderV2_4TargetTest.

Bug: 171024665
Test: Camera VTS
Change-Id: I5c16cc090b8bf0072163fbc928f4180d60c4206d
2021-05-27 07:00:05 +00:00
Emilian Peev
3177f58e30 Camera: Correct partial result entry count query
Use the partial tag count instead of the
size of the metadata buffer.
Additionally initialize 'collectedResult' to avoid
false positives when checking partial result entries
against invalid/uninitialized accumulated results.

Bug: 187156343
Test: Partner verified
Change-Id: Iff55f53952c7b06bc2a0b9786247d8ec04227705
2021-05-17 09:13:50 -07:00
Shuzhen Wang
af88452fa9 VTS: Cast camera device to lower versions
If the camera device is of a certain version, it can be casted to all lower version
numbers.

Test: VtsHalCameraProviderV2_4TargetTest
Bug: 187010354
Change-Id: Ib9515d898948fb2e04d20b0087d98334fa71def0
2021-05-06 16:10:21 +00:00
Shuzhen Wang
9f89b05379 Camera: Add a new tag for multi-resolution stream support
- The new tag is used to remove the ambiguity when a physical camera is
backing more than one logical cameras.
- Add missing VTS tests for multi-resolution stream.

Test: Camera CTS, VTS
Bug: 156254356
Bug: 184663916
Change-Id: I8adc152bbf57e8ec5e058834c1c6f461aca1bcbd
2021-04-15 15:28:51 -07:00
Jayant Chowdhary
c1982fe71b camera VTS: Add VTS test for ultra high resolution sensors.
Bug: 152813564

Test: VtsHalCameraProviderV2_4TargetTest
      --gtest_filter=PerInstance/CameraHidlTest.processUltra* on
            cuttlefish

Change-Id: If314fedc5f57a01cb2a103b834356b0c3d51e976
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2021-03-30 18:06:50 -07:00
Shuzhen Wang
25d67108b7 Camera: Add support for multi-resolution input and output streams
- Multi-resolution output streams allow for variable output sizes for
logical multi-camera.
- Multi-resolution reprocessing allows for reprocessing of
variable size images.

Test: Camera CTS, VTS
Bug: 156254356
Change-Id: I4e8b14a4d6aabdb4b194483d93af53e033c08e28
2021-03-04 13:09:32 -08:00
Treehugger Robot
a7d7cb2b9c Merge "Camera: Set arbitrary dataspace for RAW streams" am: 371265231c am: 9af4be5581 am: 2e2d030425
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1576524

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ie2f9130c6ab1c98e8b94fc2502c336c8c29b0319
2021-02-05 07:32:26 +00:00
Emilian Peev
2bb7e8a59b Camera: Set arbitrary dataspace for RAW streams
Use 'arbitrary' dataspace when trying to configure RAW
streams.

Bug: 179158925
Test: run vts -m VtsHalCameraProviderV2_4TargetTest
Change-Id: I1faa29bea3df91a34ba87ec2c7ecb9a17bd7a4e2
2021-02-04 22:10:02 +00:00
TreeHugger Robot
ba1b4cc839 Merge "VTS: Verify no duplicate entries between partial results" 2020-11-17 05:53:57 +00:00
Shuzhen Wang
6f906c15ab VTS: Verify no duplicate entries between partial results
Partial results are appended together. If there are duplicate entries
between partial results, there will be more than more entries for a tag
in the final result. This can cause undefined behavior, especially when
they have different values.

Test: Run Camera VTS test on Pixel devices
Bug: 170575182
Change-Id: I931660cef16a90ee0c247e3c4513a88adb7211ab
2020-11-16 11:11:59 -08:00
Treehugger Robot
29368c06d3 Merge "Camera: Expect physical results in the last partial notification" am: cecee13161 am: f026f3e5fe am: 5bb754093a am: 3ee6110e35
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1435036

Change-Id: I8dcaf8ccfc584c2ba6a53fee3eff06d8f1b6f80a
2020-11-13 21:52:52 +00:00
Treehugger Robot
cecee13161 Merge "Camera: Expect physical results in the last partial notification" 2020-11-13 20:45:34 +00:00
Xin Li
50393137ed Merge ab/6749736 in stage.
Bug: 167233921
Merged-In: I6756cad681e4cfa01868450214da0d7b2d5261e4
Change-Id: Ia529ecf4f48248d5af63673f359916486f71bc35
2020-10-08 23:22:52 -07:00
Emilian Peev
e33822c0d9 Camera: Expect physical results in the last partial notification
Per API specification the physical device capture results will only
be part of the last/final partial result notification.

Bug: 165476824
Test: adb shell
/data/nativetest64/VtsHalCameraProviderV2_4TargetTest/VtsHalCameraProviderV2_4TargetTest

Change-Id: I0aa860b10ed2bd30c46f58ad0ee530c740f1f5d6
2020-09-23 16:10:11 +00:00
Treehugger Robot
e453d81dc8 Merge "camera vts: fix CameraHidlTest::isSecureOnly for HAL1 Device" am: d56db87577 am: 83a6256f38 am: ed6abddaf8 am: 12069ba334 am: 2b2b298116
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1428451

Change-Id: I3ef3aa622487517945bec335e123a0fe7e422005
2020-09-18 18:32:05 +00:00
Treehugger Robot
ed6abddaf8 Merge "camera vts: fix CameraHidlTest::isSecureOnly for HAL1 Device" am: d56db87577 am: 83a6256f38
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1428451

Change-Id: I2aa2077cffbbee18a0cd25acb46c3a8e0c4b6f14
2020-09-18 16:31:22 +00:00
NukemZHYu
5508e51c5c camera vts: fix CameraHidlTest::isSecureOnly for HAL1 Device
change (getCameraDeviceVersion(mProviderType, name) to (getCameraDeviceVersion(name, mProviderType)
Avoid Camera HAL 1 Device fail on Status(EX_TRANSACTION_FAILED): 'BAD_TYPE:

Bug: 168676352
Test: run commandAndExit vts -m VtsHalCameraProviderV2_5Target

Change-Id: Icb164538bbc357e22412a7320bb721c220c24a4c
2020-09-16 21:00:33 +00:00
TreeHugger Robot
c70f1c788b Merge "Camera HAL Vts : Fix usage flag combination during gralloc allocation." into stage-aosp-rvc-ts-dev am: 7cc876ee02 am: 314611d129 am: 4181fe2378 am: 03a6282934 am: 7941bf02ce
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/12173503

Change-Id: I9dad2aacd376239427dd1a84c0e93132d5a55b9a
2020-08-06 17:23:28 +00:00
Dan Shi
ff985a85a8 Suppress gtest error for tests without any instance
Bug: 162052785
Test: m -j vts
Change-Id: I58bc808a82b2128bb8774f762f9b9fcecd2614fb
2020-07-29 09:46:36 -07:00
Jayant Chowdhary
ef9374cb20 Camera HAL Vts : Fix usage flag combination during gralloc allocation.
Earlier, for processCaptureRequestInternal, we took into account
producer and consumer usage flags returned by configureSingleStream.
Instead we should be taking into account the producer flag returned by
configureSingleStream and the consumer flag passed into
processCaptureRequestInternal (for output streams).

Bug: 162344072

Test: Use secure camera as secure only camera and run vts
Test: Run camera vts
Test: Vendor testing

Change-Id: I9fbd4db4cff48c25684f097907e7ba995c3edf41
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2020-07-28 19:18:00 +00:00
Jayant Chowdhary
6a9a809e36 camera : Allow non bc camera devices through getConcurrentStreamingCameraIds
Also Add y16 stream combinations to configureConcurrentStreamsAvailableOutputs vts test

Bug: 159247271

Test: VtsHalCameraProviderV2_4TargetTest
      --gtest_filter=PerInstance/CameraHidlTest.configureConc* on
      cuttlefish

Change-Id: If5fea1fc47a3bcc8d3695e23f01a55091c246eda
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2020-06-24 12:42:49 -07:00
Eino-Ville Talvala
d6346872c6 Camera: Fix insensitive language in comments and names
Test: Builds
Bug: 159480149
Change-Id: Ic048071867b69e5c2d337f59f697980a6a64587f
2020-06-19 15:25:01 -07:00
Jayant Chowdhary
ec37ce4947 Merge changes from topic "vts-secure-only-camera" into rvc-dev
* changes:
  Camera VTS: Add a minimal test for secure only cameras.
  camera vts: Skip regular vts tests for secure only cameras.
2020-06-01 22:52:53 +00:00
Jayant Chowdhary
a80974ca8c Camera VTS: Add a minimal test for secure only cameras.
Bug: 156749607

Test: VtsHalCameraProviderV2_4TargetTest
      --gtest_filter=PerInstance/CameraHidlTest.processSecureCaptureRequest* on device which
      SECURE_IMAGE_DATA.

Change-Id: I57f6210b69b383dc4f43cc4ee8272050a0432541
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2020-06-01 12:15:58 -07:00