Commit Graph

64224 Commits

Author SHA1 Message Date
Ray Chin
9022f45022 Support product specific VTS test configuration am: 7d03f49853
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3018625

Change-Id: I2dfd15a88f8b3d749fce434e58edb7928f117cf0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-30 03:21:15 +00:00
Treehugger Robot
86d8bf593a Merge "Remove unnecessary "_external" suffix from libcppbor" into main 2024-03-29 21:18:28 +00:00
Ray Chin
7d03f49853 Support product specific VTS test configuration
The tuner vts will read the system property
ro.vendor.vts_tuner_configuration_variant as the suffix of the config
file to read. Vendor who wants to support multiple region for a single
SoC need to put all VTS config with different suffix as
/vendor/etc/tuner_vts_config_aidl_V1.{suffix}.xml on device.

Bug: 322899156
Test: atest VtsHalTvTunerTargetTest
Change-Id: I1f76d700671c07bc90965fba94f96b8be47198d7
2024-03-29 11:10:50 +08:00
Treehugger Robot
c523f76846 Merge "Remove reference to factory reset of K" into main 2024-03-29 03:06:38 +00:00
Shawn Willden
98125926c1 Remove unnecessary "_external" suffix from libcppbor
Test: Build
Change-Id: Ied163d1f40c3b86d7b85cae1700310f5cb674e2d
2024-03-28 20:42:34 -06:00
Shawn Willden
deaa5dd808 Remove reference to factory reset of K
The ISharedSecret.aidl description of the pre-shared secret K
mentioned that K was set up during factory reset.  While that could be
done, it is almost never done; most OEMs inject K in the factory.
Removed the reference to setup in factory reset to reduce confusion.

Test: N/A, comment-only change
Change-Id: Idbbd5a8d64197ef4713a75075a9730d06162ad05
2024-03-29 01:22:06 +00:00
Mikhail Naganov
69d60aa02c audio: Fix some VTS issues on real devices
1. Skip testing of stream I/O on certain types of mix ports.

2. Skip testing of connection of BT SCO device.

Bug: 300735639
Bug: 326888356
Bug: 328010709
Bug: 331516432
Test: atest VtsHalAudioCoreTargetTest
Change-Id: I9b8bbf2014e223375c8f8400ff2af32268803706
2024-03-28 17:02:27 -07:00
Treehugger Robot
f814c97702 Merge "Update needed for Rust v1.77.0" into main 2024-03-28 06:26:30 +00:00
Charisee
c3a74935a1 Update needed for Rust v1.77.0
error: field `0` is never read
  --> hardware/interfaces/security/authgraph/default/src/main.rs:34:24
   |
34 | struct HalServiceError(String);
   |        --------------- ^^^^^^
   |        |
   |        field in this struct
   |
   = note: `HalServiceError` has derived impls for the traits `Clone` and `Debug`, but these are intenti
onally ignored during dead code analysis
   = note: `-D dead-code` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(dead_code)]`
help: consider changing the field to be of unit type to suppress this warning while preserving the field
 numbering, or remove the field
   |
34 | struct HalServiceError(());
   |                        ~~

error: aborting due to 1 previous error


Test: ./build.py --lto thin

bug: http://b/330185853
Change-Id: I08b79176fb5edea9e24990e4884e521c24660d68
2024-03-27 22:58:56 +00:00
Mikhail Naganov
efb45bc792 audio: Allow to inherit Binder RT priority in AIDL
This option is on by default for HIDL interfaces, however
in AIDL it needs to be enabled explicitly.

Bug: 331469541
Test: m
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:d975a9e6ec0b6f0eeac99673b9b06e11146874ba)
Merged-In: I971185a46da4222160fb04b8b77f805ef0396562
Change-Id: I971185a46da4222160fb04b8b77f805ef0396562
2024-03-27 16:20:33 +00:00
David Drysdale
c8b02ff6e7 Merge "Secretkeeper: more VTS tests" into main 2024-03-27 12:22:06 +00:00
A. Cody Schuffelen
ddc6a8dbdf Fix .rc file for keymint-service.nonsecure
This target was using the same `.rc` as the keymint-service target,
though it had a different name.

Bug: 331474817
Test: LOCAL_KEYMINT_PRODUCT_PACKAGE=android.hardware.security.keymint-service.nonsecure m && launch_cvd --noresume --secure_hals=keymint,oemlock
Change-Id: I0f744b75e451f6780d8f6c9bddbd5ea80c579a20
2024-03-26 15:40:37 -07:00
Doug Ferraz
cfa68a1fbb Merge "Bluetooth HCI: Add VTS requirement for HCI 4.2 - Annotations" into main 2024-03-26 14:02:54 +00:00
Doug Ferraz
eff7b9102f Bluetooth HCI: Add VTS requirement for HCI 4.2 - Annotations
Bug: 285456310
Test: atest VtsHalBluetoothV1_1TargetTest
Test: atest VtsHalBluetoothV1_0TargetTest
Test: atest VtsHalBluetoothTargetTest
Change-Id: I5a910d2a7d778b2e64a524d0a389b911c080e189
2024-03-25 20:04:19 -04:00
Treehugger Robot
dc543a304b Merge "ExternalCameraHAL: dup fd when creating AIDL NativeHandle" into main 2024-03-25 23:54:31 +00:00
Doug Ferraz
7229b6bacc Merge "Bluetooth HCI: Add VTS requirement for HCI 4.2 - HIDL version" into main 2024-03-25 22:24:41 +00:00
Avichal Rakesh
ea30826bf3 ExternalCameraHAL: dup fd when creating AIDL NativeHandle
AIDL's NativeHandle do not have a concept of unowned file
descriptors. If a NativeHandle object is created with an
fd, NativeHandle implicitly assumes ownership of the fd.
When passing fds over binder, ExternalCameraHAL used
makeToAidl which which accidentally transferred ownership
to the AIDL objects. Additionally, NativeHandles close
owned fds on destruction, which led to multiple closure
of fences.

This CL changes the logic to use dupToAidl to ensure that
NativeHandle objects are given ownership of a duped fds
and don't interfere with any of the fds used for internal
bookkeeping.

Bug: 313115623
Test: Verified by partner that ExternalCameraHAL no longer double closes fds.
Merged-In: Ic406634de6f22a290abb414e80a7747927368b68
Change-Id: Ic406634de6f22a290abb414e80a7747927368b68
2024-03-25 21:59:11 +00:00
Andrew Scull
6cb40f35b6 Merge "Require proper DICE if StrongBox is present" into main 2024-03-25 20:57:47 +00:00
Doug Ferraz
2984a75096 Bluetooth HCI: Add VTS requirement for HCI 4.2 - HIDL version
Bug: 285456310
Test: atest VtsHalBluetoothV1_1TargetTest
Change-Id: I0af583e35428f8ec8c9c360d9e28c1c909ad9001
2024-03-25 16:37:29 -04:00
Doug Ferraz
83b2267b78 Bluetooth HCI: Add VTS requirement for HCI 4.2
Bug: 285456310
Test: atest VtsHalBluetoothTargetTest
Change-Id: I056b924543ac349beb9b0eddaf039b0aa9187821
2024-03-25 14:52:55 -04:00
Andrew Scull
2146152db9 Require proper DICE if StrongBox is present
If a decice provides a StrongBox KeyMint instance then the default IRPC
instance is required to use a proper, non-degenerate DICE chain.

Expose a function to check whether the CSR contains a proper DICE chain
and use that from VTS to implement the test.

Bug: 302204396
Test: atest VtsHalRemotelyProvisionedComponentTargetTest
Change-Id: I90cf070bc2279fc52e0a8e7fd0039d3fdb68c1d7
2024-03-25 18:16:24 +00:00
Mikhail Naganov
a41ff5134d audio: Implement blocking in remote submix when there is no sink
The HIDL implementation blocked for the audio buffer duration
when the output side of the remote submix pipe does not have
the sink connected. This behavior was accidentally removed
when fixing b/327220024.

Also, limit the amount of the debug messages displayed when
the sink is shutdown to avoid spamming the syslog.

Bug: 328347445
Test: repro steps from the bug
Test: atest VtsHalAudioCoreTargetTest
Test: atest --test-filter=".*AudioPlaybackCaptureTest.*" CtsMediaAudioTestCases
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:6507376fb940198e8c39ad6d5345d132b1dd7219)
Merged-In: Ia66cb7b4567d42a41bf4715b7d725d36510ac50c
Change-Id: Ia66cb7b4567d42a41bf4715b7d725d36510ac50c
2024-03-25 16:04:27 +00:00
Yuyang Huang
b959192690 Merge "Adapt CheckApfIsSupported for VSR-15 compatibility" into main 2024-03-25 06:51:10 +00:00
Treehugger Robot
f3f6e5b2cd Merge "Update APF VTS for VSR-14 compliance" into main 2024-03-23 01:26:24 +00:00
Mikhail Naganov
222d034461 Merge "audio: Adjust stream buffer size calculation" into main 2024-03-22 03:36:44 +00:00
Mikhail Naganov
cbb2976223 audio: Adjust stream buffer size calculation
When calculating buffer size, use powers of two
for "large" buffers only on SRs >= 44100 Hz.
With lower SRs, sizes rounded up to a multiple
of 2 give too high latency.

Bug: 328432688
Test: repro steps from b/328432688#comment3
Test: atest VtsHalAudioCoreTargetTest
Change-Id: I605ef8507fef030d349e85c33ed0229c9566ddb5
2024-03-21 16:40:30 -07:00
Ayush Jain
e63e865777 Merge "uwb: Keep VTS timeout to be consistent with UWB stack" into main 2024-03-21 16:33:18 +00:00
Mikhail Naganov
df65834372 audio: Do not use A2DP/LE status when populating device port
The events about the status of A2DP and LE are sent by
the framework asynchronously with attempts to connect
an external device. As a result, the connection attempt
may be rejected by the bluetooth HAL module.

Bug: 327711955
Test: atest VtsHalAudioCoreTargetTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:a46d52771a3e4a7816ea722088153ee6b65f59c3)
Merged-In: Iecef0ee6a66cd290237fdcccd6a7016e9622c4b0
Change-Id: Iecef0ee6a66cd290237fdcccd6a7016e9622c4b0
2024-03-20 16:48:08 +00:00
Treehugger Robot
8127a59cb2 Merge "Update owners for sensor interfaces" into main 2024-03-20 12:51:11 +00:00
Treehugger Robot
2116f9c807 Merge "Fix annotation in doc" into main 2024-03-20 00:41:09 +00:00
Ady Abraham
530024ea4a composer: vts: add support for batched create/destroy layers
Bug: 315517904
Fixes: 329461909
Test: atest VtsHalGraphicsComposer3_TargetTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:a00d246f2725b22d32b2908230de7620238827ba)
Merged-In: Ic3c0415612b1387671ab8efa0ec95ed727f6bf68
Change-Id: Ic3c0415612b1387671ab8efa0ec95ed727f6bf68
2024-03-19 23:11:56 +00:00
Yuyang Huang
641f0aed53 Adapt CheckApfIsSupported for VSR-15 compatibility
This commit updates CheckApfIsSupported to align with VSR-15
requirements. APF should have minimum of 2000 bytes usable memory.

Bug: 303356901
Test: TH
Change-Id: I2a2dbc22e1532fcb11ab256830cecba9f6c54446
2024-03-19 11:13:08 +09:00
Yuyang Huang
fe83a98b3e Update APF VTS for VSR-14 compliance
Modified the VTS to check the APF version is 4 (or higher) as mandated
by VSR-14.

Test: TH
Change-Id: I28f6579bf426e5338880fcc6afff33c769f29634
2024-03-19 11:01:26 +09:00
Treehugger Robot
4372ea1bd1 Merge "Remove the default implementation for NFC aidl HAL" into main 2024-03-19 01:33:35 +00:00
Bhakthavatsala Raghavendra
2ad3630302 uwb: Keep VTS timeout to be consistent with UWB stack
Change-Id: I17367f955ced5ea3d109af06122678f8e6e8cda1
2024-03-16 19:58:31 -07:00
Shunkai Yao
bb35effe0d Audio effect aidl log reduce and level adjust
Bug: 329334917
Test: atest AudioEffectTest
Test: atest CtsMediaAudioTestCases
Test: atest CtsEffectTestCases
Test: audio use cases on pixel AIDL audio hal
Change-Id: I49876924b230f2ac834d3b0e494a03b814c4bb6e
Merged-In: I49876924b230f2ac834d3b0e494a03b814c4bb6e
2024-03-16 00:00:12 +00:00
Henri Chataing
8954a83c93 Merge changes I422445af,I9c995127 into main
* changes:
  uwb/aidl/default: Use write_all instead of write in sendUciMessage
  uwb/aidl/default: Log incoming and outgoing packet bytes
2024-03-15 15:28:07 +00:00
Henri Chataing
cd3a3402b5 uwb/aidl/default: Use write_all instead of write in sendUciMessage
write_all ensures that the full buffer is being written.

Bug: 329316454
Test: TreeHugger
Change-Id: I422445aff32cdeba8fba9497a4296e6eda2e60ce
2024-03-15 15:26:17 +00:00
Henri Chataing
67b4c13cf7 uwb/aidl/default: Log incoming and outgoing packet bytes
Bug: 329316454
Test: TreeHugger
Change-Id: I9c9951273ed593a2090d199830a973f013b3da68
2024-03-15 15:26:17 +00:00
Shunkai Yao
49800ab894 Merge changes I95f19d20,Ic720e74c into main
* changes:
  minor improvements for VtsHalAudioEffectFactoryTargetTest
  Effect AIDL VTS: skip data path testing for offloading effects
2024-03-14 22:29:46 +00:00
Charlie Boutier
4e2937b460 Merge "uwb_hal: handle data_packet parsing" into main 2024-03-14 18:35:35 +00:00
Shunkai Yao
e0c1f31ff6 minor improvements for VtsHalAudioEffectFactoryTargetTest
Bug: 327678656
Test: atest VtsHalAudioEffectFactoryTargetTest
Change-Id: I95f19d20883142cd500c552966bd8f02256a1be5
Merged-In: I95f19d20883142cd500c552966bd8f02256a1be5
2024-03-14 17:32:07 +00:00
Shunkai Yao
50e478ba73 Effect AIDL VTS: skip data path testing for offloading effects
Bug: 328330990
Test: atest VtsHalBassBoostTargetTest
Test: atest VtsHalDownmixTargetTest
Test: atest VtsHalLoudnessEnhancerTargetTest
Test: atest VtsHalVolumeTargetTest
Change-Id: Ic720e74cf25f5282dfa52dca354a5eccf9071f61
Merged-In: Ic720e74cf25f5282dfa52dca354a5eccf9071f61
2024-03-14 17:10:37 +00:00
Henri Chataing
60cd14a576 Remove the default implementation for NFC aidl HAL
The HAL android.hardware.nfc-service.example
is not used anywhere; cuttlefish is using the implementation
in /device/google/cuttlefish/guest/hals/nfc instead
(android.hardware.nfc-service.cuttlefish)

Test: NA
Change-Id: I76dd12624e0e3eb4bb4c7ebf33c33a7781bf9836
2024-03-14 16:27:22 +00:00
David Drysdale
5f4493d75b Secretkeeper: more VTS tests
Add tests for:
- large number of session creations
  - also use a bigger identity, to better simulate real use
- attempt to retrieve a secret with an incorrect identity

Test: VtsSecretkeeperTargetTest (shiba)
Bug: 327526008
Change-Id: I8dddf643d03a8fb679511564cb03c2248477c116
2024-03-14 15:00:37 +00:00
Tri Vo
b02ff886be Tests for imported wrapped RSA and EC keys
Only applies for devices on VSR API level 35 and above, so that existing
devices which previously passed VTS should not need to pass the new
tests.

Bug: 292534977
Test: VtsAidlKeyMintTargetTest
Change-Id: I8281c3cebf05795e3f9a1ed2b112fc149d8a104c
2024-03-14 13:04:16 +00:00
Treehugger Robot
31f8d6e36b Merge "automotive aidl: Add required @RustDerive annotations" into main 2024-03-14 08:05:54 +00:00
John Reck
52414d1c2a Fix annotation in doc
Change-Id: I4fb90e7b30659227263087c85b98db31bb039184
2024-03-14 01:58:19 +00:00
Felix Obenhuber
38f12da7b8 automotive aidl: Add required @RustDerive annotations
Derive vehicle hal parcelables from the Clone trait where applicable. This is is
supportive for implementing a vehicle hal service in Rust because caching e.g
VehiclePropValue or VehiclePropConfig instances allow less verbose code and
increase performance. Cloning a VehiclePropConfig instead of constructing each
time needed is less verbose. Property configs are normally not updated at
runtime.

This is not an API change, so in order to avoid having to bump the AIDL
API version for this HAL we used the hash_gen.sh script as below:

$ m android.hardware.automotive.vehicle-update-api
$ m android.hardware.automotive.vehicle-freeze-api

$ vim vehicle/aidl/Android.bp # removed frozen_api argument and the newly
created version 3 block

$ cp -r aidl_api/android.hardware.automotive.vehicle/3/* aidl_api/android.hardware.automotive.vehicle/2/
$ rm -rf aidl_api/android.hardware.automotive.vehicle/3/

./system/tools/aidl/build/hash_gen.sh \
    hardware/interfaces/automotive/vehicle/aidl/aidl_api/android.hardware.automotive.vehicle/2 \
    1 \
    hardware/interfaces/automotive/vehicle/aidl/aidl_api/android.hardware.automotive.vehicle/2/.hash

Test: manual - used new derives in custom implementation
Change-Id: I586b89b160eb7a01ce24fad211b9e909175cdd3c
Merged-In: I889c0d51f2c2633908231dd39c9ea5259de36667
2024-03-14 01:29:28 +00:00
Anthony Stange
ac0eaa9004 Update owners for sensor interfaces
Change-Id: Id471dad8fde48c6ac515693ceb0471673145e13e
2024-03-13 23:13:10 +00:00