Commit Graph

27940 Commits

Author SHA1 Message Date
David Drysdale
bb3d85eaa4 Test for patchlevels and too much entropy
Add tests for:
 - Too much entropy should be rejected with INVALID_INPUT_LENGTH
 - All authorization lists should include a vendor and boot patchlevel.

These requirements are in both the KeyMint and the KeyMaster 4.0 AIDL
specificications, but have never been policed before.

Currently disabled with a command-line flag because CF does not have
the patchlevels and so fails lots of tests.

Test: VtsKeyMintAidlTargetTest
Change-Id: Ic9622ef3f1b80e013a34059218e3e029f392eb72
2021-04-30 14:50:14 +01:00
David Drysdale
7de9febd17 Add more symmetric KeyMint tests
Also fix some test name comments along the way.

Test: VtsKeyMintAidlTargetTest
Change-Id: I828acfaa676e1b9fa2e3c6f184f9dafb936b0e82
2021-04-30 14:50:12 +01:00
David Drysdale
40eb8f53ea KeyMint AIDL tweaks
- Describe 3DES requirements
- Remove references to non-existent getKeyCharacteristics() entrypoint
- Remove references to non-existent attestKey() entrypoint
- Remove mention of asymmetric verification operations
- Remove text describing incomplete update()
- Remove text discussing padding for ECDSA
- EC keys can't encrypt/decrypt
- Force use of curve not key size for EC keys
- Drop TODO re: CBOR encoding of wrapped key
- Indicate caller-provided nonces must have correct size
- Add more reference to IKeyMintOperation
- Align parameter names with signatures
- Correct MIN_MAC_LENGTH error code
- Make CREATION_DATETIME consistently optional
- Describe use of MGF1 digest option
- Fix typos

Test: VtsKeyMintAidlTargetTest (CF)
Change-Id: Ie01b99d33be7336e872bf24a7761a3ac5b1d584c
2021-04-30 14:19:31 +01:00
Jooyung Han
b4be35f854 Merge "aidl: Suppress warnings on out-array" 2021-04-27 22:47:15 +00:00
Jooyung Han
a886a5c4be Merge changes from topic "fix-aidl-warnings"
* changes:
  aidl: Set explicit default values
  aidl: Set explicit default values
  aidl: Set explicit default values for enum-type fields
  aidl: Set explicit defaults to enum-type fields
2021-04-27 22:46:40 +00:00
Treehugger Robot
af3b58e35a Merge "Add attestation format documentation" 2021-04-27 20:40:50 +00:00
David Drysdale
5cde787c9f Merge "Align KeyMint AIDL with usage" 2021-04-27 16:43:01 +00:00
Shawn Willden
3cb64a6822 Add attestation format documentation
Somehow the attestation format docs got dropped from KeyMint in the
transition from Keymaster.  This replaces them, and also clarifies
that KeyMint StrongBox should not support device attestation.

Test: VtsAidlKeyMintTargetTest
Change-Id: I2334e99b4797c7a0e2e59727ffa730cf7504df31
2021-04-27 09:22:25 -06:00
Jooyung Han
386e55b616 aidl: Set explicit default values
Fixes: 179853698
Test: mma in hardware/interfaces/vibrator
Change-Id: I231c3cfb17f812944bcc6a88e618d96d7068f6c2
2021-04-27 20:11:54 +09:00
Jooyung Han
9c3ebfc83f aidl: Set explicit default values
This fixes warnings in AIDL files(-Wenum-explicit-default).

No semantic changes. (Explicit values are all zero enumerators.)

Fixes: 179853367
Test: mma in hardware/interfaces/keymaster
Change-Id: If5a70da3efd05a344c39ef1d2e73b7ec2b894f33
2021-04-27 18:33:17 +09:00
Jooyung Han
3a966323ef aidl: Set explicit default values for enum-type fields
Fixes: 179853674
Test: mma in hardware/interfaces/neuralnetworks
Change-Id: I9fdc7089eaf1202299da098220875ef8398667fe
2021-04-27 13:58:46 +09:00
Jooyung Han
695ef7acfe aidl: Set explicit defaults to enum-type fields
Fixes: 179853398
Test: mma in hardware/interfaces/graphics
Change-Id: I6f93bca4ba3c8d538765fc9a811b9050c6142cc3
2021-04-27 12:17:39 +09:00
Jooyung Han
d63cd3fff6 aidl: Suppress warnings on out-array
out-param arrays are considered harmful since the Java backend requires
them to be correctly allocated at caller site. But the only user of
android.hardware.identity is in C++, we can just ignore them.

Fixes: 179853403
Test: mma in hardware/interfaces/identity
Change-Id: Ib9b7ad895b3827c0888869a5b154696e3aff5624
2021-04-27 10:51:57 +09:00
Ady Abraham
2fff170562 composer: VtsDisplay::setDimensions shouldn't be const
Fix the usage of const attribute in VtsDisplay

Test: run composer 2.4 VTS
Bug: 185195256
Change-Id: I616ea044f46bc080ad0e82753b5031d9a38369f3
2021-04-26 12:00:06 -07:00
Andy Dyer-smith
e1dd0085d9 Merge "Fix typo in PAD_V2 comments" 2021-04-26 17:48:17 +00:00
Selene Huang
8f9494c4f6 Added various vts tests for attestKey.
- Added tests for signing attest key with factory chain.
  - Added test for signing encryption keys.
  - Added tests for chaining many RSA attest keys on the same chain.
  - Added tests for chaining many Ec attest keys on the same chain.
  - Added tests for alternate chaining of rsa-ec-rsa-ec-rsa attesti
    keys on the same chain.

Test: atest VtsAidlKeyMintTargetTest
Change-Id: I9c67e2b928d6bba6cc4074a4b65f639f33c9ec26
2021-04-24 22:43:13 -07:00
Treehugger Robot
24c422c48b Merge "Bluetooth: Turn Bluetooth off while device setup" 2021-04-23 17:46:53 +00:00
Andy Dyer-Smith
889c46c11a Fix typo in PAD_V2 comments
Bug: 158315823
Test: m

Change-Id: Ic7ba213f2e0ff523349e4b80926a302399db8d88
2021-04-23 16:25:12 +00:00
Treehugger Robot
f04466c090 Merge "Added vts tests for certificate subject and serial for various algorithms and self sign or non-self sign certificates." 2021-04-23 07:53:20 +00:00
Cheney Ni
1f3312ce04 Bluetooth: Turn Bluetooth off while device setup
Because there's only one HCI interface, it won't open if Bluetooth is in
use, but encounter unexpected results. Based on the auto-generated test
config file, and this adds BT off condition in the device setup stage.

Bug: 184720725
Test: android-vts/tools/vts-tradefed run commandAndExit vts -m VtsHalBluetoothV1_*TargetTest
Change-Id: If03d3621f9e0cfebce7574126def134c4303b97f
2021-04-23 11:59:33 +08:00
Aaron Tsai
47e14e567f Adding 1s time gap between back-to-back calling setDataThrottling API
Modem has restriction that it can not process back-to-back thermal actions.
Adding 1s delay to prevent unexpected errors.

Bug: 181634712
Test: atest VtsHalRadioV1_6TargetTest -- --test-arg com.android.tradefed.testtype.GTest:native-test-flag:"--gtest_filter=*setDataThrottling/0_slot1"
Change-Id: I70a717cbc3a63d5b1abb4be9d3920d0ee3451b14
2021-04-23 02:35:23 +00:00
Treehugger Robot
40bbe789a4 Merge "libgtest_prod: use headers." 2021-04-23 01:17:59 +00:00
Ady Abraham
fc67ba997e Merge "composer: update VtsDisplay dimensions" 2021-04-23 00:39:20 +00:00
Yifan Hong
5cd5a17657 libgtest_prod: use headers.
libgtest_prod is a static library that contains only
headers. It is now deprecated for good, and is replaced
by libgtest_prod_headers.

Test: TH
Bug: 185916167
Change-Id: I18bb1b0ab355fdfb627f9bcf56b6c4bdf9971e02
2021-04-22 17:19:01 -07:00
Treehugger Robot
5705ebf9c1 Merge "Let the default Atrace HAL support /sys/kernel/tracing" 2021-04-22 23:36:18 +00:00
Selene Huang
6e46f1467c Added vts tests for certificate subject and serial for various
algorithms and self sign or non-self sign certificates.

Test: atest VtsAidlKeyMintTargetTest
Change-Id: I4e9d8db7be500f165c3a9f240ea2dfe00c2a70d1
2021-04-22 15:18:32 -07:00
Hridya Valsaraju
1e52e63238 Let the default Atrace HAL support /sys/kernel/tracing
With this change, atrace HAL will look for tracefs in
/sys/kernel/tracing first and /sys/kernel/debug/tracing second.

Test: systrace
Bug: 185427606
Change-Id: Iccc5af92db222dc422a527c14b1f2fb7bc4e7746
2021-04-22 15:10:46 -07:00
Ady Abraham
c801385495 composer: update VtsDisplay dimensions
When the active config changes, the display dimension might change
as well, so we need to update it to match the active config.

Test: run composer 2.4 VTS
Bug: 185195256
Change-Id: Ie2671e61498d2501901885b2a9986ee1974bd641
Merged-In: Ie2671e61498d2501901885b2a9986ee1974bd641
2021-04-22 18:56:46 +00:00
Michael Butler
1544989041 Merge "Remove NN canonical IDevice::isUpdatable -- hal" 2021-04-22 18:07:59 +00:00
David Drysdale
56ba912b30 Align KeyMint AIDL with usage
- Make HardwareAuthToken nullable on begin()
 - Drop unused vestigial performOperation() entrypoint
 - Drop unused Tag::BLOB_USAGE_REQUIREMENTS

Test: TreeHugger, VtsKeyMintAidlTargetTest (CF)
Change-Id: I577ac04d843ee6d03cbfb99e56ef3e69eb034532
2021-04-22 15:55:29 +01:00
Jonathan Reichert
2585f44a6e Merge "Fix SetCountryCode test when US is not supported" 2021-04-22 12:13:57 +00:00
Roman Kiryanov
de2b8f248e Merge "Move the qemu_pipe library into vhal_v2_0" 2021-04-21 23:05:40 +00:00
Michael Butler
3e9720b83f Remove NN canonical IDevice::isUpdatable -- hal
This CL alters the AIDL utility "getDevices" to return whether or not a
service is updatable. This CL additional removes IDevice::isUpdatable
because it is now redundant with the changes to "getDevices".

Bug: 170696350
Test: mma
Test: NeuralNetworksTest_static
Change-Id: I86228763937c0dd2ee5b1d9d547c367cd7504ed4
2021-04-21 13:27:59 -07:00
Jack Yu
91ce32adb9 Merge "radio: Add VTS test for OperatorInfo.operatorNumeric" 2021-04-21 20:13:56 +00:00
Selene Huang
6d70ac2462 Merge "Implement device unique attestation vts tests for keymint." 2021-04-21 19:46:56 +00:00
Sooraj Sasindran
0cb21f39ae Merge "Use 0 as link capacity estimate if device is not connected" 2021-04-21 19:05:36 +00:00
SongFerng Wang
9d38b91d8d Merge "modemReducedFeatureSet add PhysicalChannelConfig_1_6 item" 2021-04-21 17:32:27 +00:00
Sooraj Sasindran
6e9d3413e1 Use 0 as link capacity estimate if device is not connected
Use 0 as link capacity estimate if device is not connected instead of -1

Bug: 184663919
Change-Id: Id634c7e32200b5d94eed36cefbee6ba8babc8f26
Test: only documentation change
2021-04-21 10:10:15 -07:00
Treehugger Robot
251b679e22 Merge "Update documentation for secondary bandwidth" 2021-04-21 16:58:36 +00:00
Sooraj Sasindran
6985b64a95 Update documentation for secondary bandwidth
Update documentation for secondary bandwidth to indicate that
some modems do not support this feature

Test: build
Bug: 162373679
Change-Id: I03d4079e03817fe7c7b52eb18058c49e54302d6b
Merged-In: I03d4079e03817fe7c7b52eb18058c49e54302d6b
2021-04-21 16:46:50 +00:00
Treehugger Robot
92c127f961 Merge "[ANAPIC Review] Remove config 1.3 hal" 2021-04-21 16:03:35 +00:00
Treehugger Robot
ad078c25f9 Merge "[ANAPIC Review] Modify radio 1.6 based on ANAPIC comment" 2021-04-21 16:03:26 +00:00
Treehugger Robot
0292dbbec8 Merge "Add units to hal times and durations names" 2021-04-21 11:35:45 +00:00
SongFerngWang
09a94cc486 modemReducedFeatureSet add PhysicalChannelConfig_1_6 item
Bug: 185925786
Test: build pass
Change-Id: I7d0c1b2534f50bbb445e2929b2807da0835d6bfe
Merged-In: I7d0c1b2534f50bbb445e2929b2807da0835d6bfe
2021-04-21 17:14:29 +08:00
Zoey Chen
a7ea6affd2 [ANAPIC Review] Remove config 1.3 hal
Bug: 183738012
Test: build
Change-Id: Ie0eec5576d08ddcd9a8f5ee1a1d9e2b32772653e
Merged-In: Ie0eec5576d08ddcd9a8f5ee1a1d9e2b32772653e
2021-04-21 17:07:05 +08:00
Treehugger Robot
04d6d4a186 Merge "Added 12 various attestation related vts tests. - Check for app id only if challenge is provided. - Verify self sign certificate works for RSA and Ecdsa. - Verified attestation is generated for encryption keys too. - Verify no attestation is generated for symetric keys. - Verify app id is always required when attestation challenge is provided to the new key generation. - Verify app id is ignored when challenge is missing. - Verify app id length is properly encoded. - Added vts tests for various attestation success and fail cases." 2021-04-21 05:57:09 +00:00
Zoey Chen
532dcfd48a [ANAPIC Review] Modify radio 1.6 based on ANAPIC comment
- setupDataCall_1_6, remove "same as 1.5" comment
 - sendSMSExpectMore to sendSmsExpectMore
 - getAllowedNetworkTypesBitmap should use int32_t
 - csiCqiReport uses uint8_t
 - cellBandwidthDownlinkKhz and cellBandwidthUplinkKhz
 - AccessTechnologySpecificInfo, remove these struct NgranRegistrationInfo and GeranRegistrationInfo

Bug: 183738486
Test: make
Change-Id: Icae28d68831bbd01836b8d464e8ece134a9aa63d
Merged-In: Icae28d68831bbd01836b8d464e8ece134a9aa63d
2021-04-21 05:12:17 +00:00
Selene Huang
4f64c22809 Added 12 various attestation related vts tests.
- Check for app id only if challenge is provided.
- Verify self sign certificate works for RSA and Ecdsa.
- Verified attestation is generated for encryption keys too.
- Verify no attestation is generated for symetric keys.
- Verify app id is always required when attestation challenge is
  provided to the new key generation.
- Verify app id is ignored when challenge is missing.
- Verify app id length is properly encoded.
- Added vts tests for various attestation success and fail cases.

Test: atest VtsAidlKeyMintTargetTest
Change-Id: If29249b0913fd9c2f91d20188ca5cfbaa04bead8
2021-04-20 19:23:40 -07:00
Selene Huang
531a72d7ff Implement device unique attestation vts tests for keymint.
Test: atest VtsAidlKeyMintTargetTest
Change-Id: If271c915d33cece035ab67b9149ae4ba762648b4
2021-04-21 01:45:13 +00:00
Lev Proleev
8df7d6eaf9 Add units to hal times and durations names
The change adds "Ns" suffix to timeOnDevice, timeInDriver,
loopTimeoutDuration, deadline and duration.

Fix: 183118329
Test: mm
Change-Id: I4afe34f27fc8717ac28c8fa09edda9918641c39a
Merged-In: Id1f9ee4b8e41873c97690bb19a5e84572dd9ccf1
2021-04-20 18:16:11 +00:00