Commit Graph

829 Commits

Author SHA1 Message Date
Treehugger Robot
6cd27b6f2a Merge "Reland "Add a DisplayCapability for multi-threaded present"" into main 2023-10-18 02:21:51 +00:00
Joen Chen
e0a962c8e3 Reland "Add a DisplayCapability for multi-threaded present"
Originally landed as I5dbb01fc23abd5e0108c565f96d25e62c77fc16d and
previously reverted in I6265f8de3db31f07506906cee82a91fe3baac0bc due to
timeline constraints.

Add a test presenting from multiple threads. Split up execute() so that
it can be called for a single display. Update MultiThreadedPresent
(test) to offload presentDisplay to a separate thread, similar to how
Ib9d074671e32c95875ef7e0791dd95d6e595e47a does it, as described in
go/multi-threaded-present.

Bug: 259132483
Bug: 284156408
Fixes: 251842321
Fixes: 295841597
Test: VtsHalGraphicsComposer3_TargetTest
Change-Id: If975ee9bb0b9c6f64ef50401e2aee32f934e3f08
2023-10-16 15:23:59 -04:00
Leon Scroggins III
79d7ae8207 Remove deprecated warnings for SKIP_VALIDATE
We deliberately use a deprecated API to test that it is not used. Ignore
warnings from using it in this test.

In PresentDisplayNoLayerStateChanges, remove the check for
SKIP_VALIDATE, removing the other warning. As written, the test would be
skipped without SKIP_VALIDATE support. But devices should *not* claim
Capability::SKIP_VALIDATE, meaning the test would always be skipped. The
docs state that the behavior previously indicated by SKIP_VALIDATE is
now the default, so we should always be running the test.

Bug: NA
Test: atest VtsHalGraphicsComposer3_TargetTest (no warnings)
Change-Id: Icc89a82b4850428c2f0940be0f78f5ebff1881b3
2023-10-12 08:38:12 -04:00
Alec Mouri
b9556b3aba Merge "Start VTS for color management." into main 2023-10-10 20:40:46 +00:00
Sergiu Ferentz
31b637fd90 Merge "Bump android.hardware.graphics.common V4->V5" into main 2023-10-09 08:27:26 +00:00
Alec Mouri
f6c039a49e Start VTS for color management.
Right now this only makes sure that extended sRGB buffers aren't
corrupted by the time it hits the display. This is especially important
for Ultra HDR, because display compensation is defined by the spec.

Bug: 276331687
Bug: 259144781
Test: VtsHalGraphicsComposer3_ReadbackTest
Change-Id: Ib6c39858289d5559ae76280ca1a0ef756f2daef0
2023-10-06 23:04:15 +00:00
sergiuferentz
7d7a24d5f6 Bump android.hardware.graphics.common V4->V5
Test: Build
Bug: 291142745
Change-Id: Ib0002feb982ffcc37fa7b69493c644b7a835cf4f
2023-10-03 16:14:03 +00:00
Alec Mouri
712b3d9880 Setting layer brightness doesn't need nit info for readback tests
The nit information was used when we set exact nit values rather than a
relative brightness per layer. But we only need nit values for the
renderengine interface, which isn't tied to any hwc or panel
capabilities.

Bug: 301261125
Test: VtsHalGraphicsComposer3_TargetTest
Change-Id: I770dc5620648df2eab608e030c5e76cf190f315d
2023-09-29 00:21:37 +00:00
Ram Indani
82426a4a40 Revert "[Composer AIDL] Rename notifyExpectedPresentTimeoutNs and"
This reverts commit f850701be0.

Reason for revert: Delaying rename to avoid churn for external partner work.

Change-Id: If96786d074a61ac0f781540e98d020a6f7fd673b
2023-09-01 20:02:50 +00:00
ramindani
f850701be0 [Composer AIDL] Rename notifyExpectedPresentTimeoutNs and
notifyExpectedPresentHeadsUpNs
Renamed to timeoutNs and headsUpNs respectively

BUG: 294102485
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: Id890d9634d80700ad2515c9b4fe2a423b6b75d96
2023-08-30 18:51:19 -07:00
ramindani
2b2ec50b56 [Composer VTS] Check Vrr mode is the only mode in the Config Group
BUG: 296636107
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: I4bdf7b0988673a13297d648dcf3360a6821aaecb
2023-08-25 18:48:47 -07:00
Alec Mouri
75a546270a Remove useFramebufferCache parameter in drawLayers()
GLESRenderEngine used it, but GLESRenderEngine is no more.

Bug: 199918329
Test: builds
Change-Id: I9c735e5820bd187f910905e7e77f9445f0ff30db
2023-08-18 15:01:52 +00:00
Alec Mouri
32a41abac3 Remove color management configuration in VTS
Color management is now turned on by default, so there's no reason to
explicitly enable it in renderengine.

Bug: 295966830
Test: builds
Change-Id: I42c8afb30950081cd57072680da06895dcc02f2c
2023-08-15 02:11:49 +00:00
Treehugger Robot
6d9576d649 Merge "composer3: minor fix to dpi documentation " into main 2023-08-01 21:13:01 +00:00
Ady Abraham
07a826c28c composer3: minor fix to dpi documentation
Change-Id: Ie31cb78f682761d1022592a22867307ab78b5a75
Test: prebuild
2023-08-01 20:00:07 +00:00
Ram Indani
789cd64b73 Merge "[Composer-HAL-AIDL] Deprecates getDisplayAttribute" into main 2023-07-31 19:46:10 +00:00
ramindani
d411bd3bda [Composer-HAL-AIDL] Deprecates getDisplayAttribute
Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 284866749
BUG: 287518295
Change-Id: Ib4f32d9b60cbbbf127963e0fa4b273951e9d46e6
2023-07-31 10:16:05 -07:00
Treehugger Robot
f2d57b1e40 Merge "composer3: add rust backend " into main 2023-07-28 19:44:38 +00:00
John Reck
631dc15b2e Remove allocator from composer2.1-4 VTS
Bug: 292584923
Test: make VtsHalGraphicsComposerV2_3TargetTest VtsHalGraphicsComposerV2_4TargetTest VtsHalGraphicsComposerV2_2TargetTest VtsHalGraphicsComposerV2_1TargetTest
Change-Id: I6c5e8c8b96450f800bb60b6ed0ce3b3c10ce1565
2023-07-26 16:06:34 -04:00
John Reck
6d0abbb439 Remove mapper from composer2.1 VTS
Bug: 292584923
Test: make VtsHalGraphicsComposerV2_3TargetTest VtsHalGraphicsComposerV2_4TargetTest VtsHalGraphicsComposerV2_2TargetTest VtsHalGraphicsComposerV2_1TargetTest
Change-Id: I3642995e7236a3b9b08ad5419c9d02b67243b24a
2023-07-26 15:54:47 -04:00
Ady Abraham
9118110a15 composer3: add rust backend
Change-Id: I2d3d91fd714130252d63b697958f128c9bd06dc5
Test: presubmit
Bug: 293256928
2023-07-26 19:42:10 +00:00
John Reck
82c666bd8c Remove mapper from composer2.2 VTS
Test: make VtsHalGraphicsComposerV2_2TargetTest
Bug: 292584923
Change-Id: Id281c732535ace4a36750d759b59db7aa6e5cb3a
2023-07-26 10:17:17 -04:00
John Reck
650fe3ed52 Remove mapper from composer2.3 VTS
It was unused anyway

Bug: 292584923
Test: make VtsHalGraphicsComposerV2_3TargetTest
Change-Id: I81fb1be275ef54062a8ae5bddec17a137dda7946
2023-07-25 21:08:42 -04:00
John Reck
7f996c3f1c Remove direct mapper from composer2.4 VTS
Bug: 292584923
Test: make VtsHalGraphicsComposerV2_4TargetTest
Change-Id: I4379df1d673fc709b9a496b5c44cb9420798a05d
2023-07-25 17:35:08 -04:00
John Reck
e849ecd055 Remove unused dependencies from composer3 VTS
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: I1eeb3ad326d91ec317e91bc3c515a8f28baae074
2023-07-25 16:32:49 -04:00
Ram Indani
15e0bb9f83 Merge changes from topic "HWC3-V3-VRR" into main
* changes:
  [Composer VTS] Adds VTS for the vrr configuration
  [Composer-HAL-AIDL] Adds vrr interface configuration
2023-07-22 04:14:52 +00:00
ramindani
2704c5fe12 [Composer VTS] Adds VTS for the vrr configuration
Test getDisplayConfigurations with vrr parameters
Test notifyExpectedPresent does not return error

Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 287517352
BUG: 284881912
Change-Id: I49d6876922e9fde47e531200a29413495458b8a5
2023-07-21 21:13:37 -07:00
ramindani
bc41c5fb19 [Composer-HAL-AIDL] Adds vrr interface configuration
Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 287517352
BUG: 284881912
Change-Id: I71ed35acb18a00009cd23afe47f5c48494d08c0c
2023-07-21 21:13:37 -07:00
Treehugger Robot
d683f7da0b Merge "Support per-port display configs in VTS" into main 2023-07-21 21:13:11 +00:00
Alec Mouri
be1b4d6cce Support per-port display configs in VTS
Bug: 277855934
Change-Id: I92e1615d8eb9466b40e02f8e2df8b3432e927af6
2023-07-21 21:12:16 +00:00
Treehugger Robot
595664a377 Merge "Fix a DimmingStage documentation typo by rewording the doc." into main am: 299db35551 am: 518f74b2f9 am: 7cafdb3073 am: f0c1565ef0 am: d0c6ea82e6
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2669815

Change-Id: Ic26033b197832c2ba22c5ce704edc4c1f3a65424
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-21 07:30:31 +00:00
Treehugger Robot
7cafdb3073 Merge "Fix a DimmingStage documentation typo by rewording the doc." into main am: 299db35551 am: 518f74b2f9
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2669815

Change-Id: Ibf33531aa91335f1a34d1d8db17dfa8ffbe84a54
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-21 05:13:07 +00:00
Alec Mouri
cdcfd05736 Fix a DimmingStage documentation typo by rewording the doc.
Change-Id: I5a1b3a99630cfded4b34c74b020bb4df2ce12084
2023-07-20 23:07:17 +00:00
Kriti Dang
13ffa1d123 Merge "composer: vts: changing config groups should not check newVsyncAppliedTimeNanos" into main 2023-07-18 10:27:27 +00:00
Ady Abraham
b241927097 composer: vts: changing config groups should not check newVsyncAppliedTimeNanos
Bug: 240542961
Test: by partner
Change-Id: Id39d6c4a2a238b43dcf7b24249cab84a27eaf9dd
2023-07-17 12:23:38 +02:00
ramindani
02fe477218 [Composer VTS] Adds VTS for getDisplayConfigurations
Test getDisplayConfigurations on the version 3 of the composer.

Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 287518719
BUG: 284866749
Change-Id: Ibb654dbeb4b164d86f92f51f8083ed1ab06fcfa4
2023-07-14 14:53:11 -07:00
ramindani
d40b5667d7 [Composer-HAL-AIDL] Interface changes with getDisplayConfigurations
Updates to the AIDL interfaces with getDisplayConfigurations
This will be replacing the getDisplayConfig api that will be deprecated in the upcoming CL's.
implementations will follow in the upcoming CL's

Test: device boots, atest libsurfacerflinger_unittest, atest VtsHalGraphicsComposer3_TargetTest
BUG: 284866749
BUG: 287517352
Change-Id: I2b64dcaace26a297f308e8f5c2568c35c9cd38cb
2023-07-13 10:55:20 -07:00
ramindani
12423f5ff6 [Composer VTS] Subclass the test cases by the interface version
This helps us write tests by version number, and avoids checking version
interface in every test that we add in newer versions, avoids common mistakes of
missing a version check. And makes it clear what features were added in new versions

Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 274999658
Change-Id: I2a8d5aa6c9d426de02ab0abf2ca662e330b6a5ea
2023-06-15 22:52:32 +00:00
Edward Liaw
dbacb2173e Merge "TEST_MAPPING: enable vts hal tests in kernel-presubmit" am: 24a8a39219 am: 69771123ba am: ac75f2d41c am: c01432b259 am: abed2fcab0 am: d4ac480aa1
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2610093

Change-Id: Ia634246c8f465af29a8092c4ef7691b46480891a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 00:13:30 +00:00
Edward Liaw
c01432b259 Merge "TEST_MAPPING: enable vts hal tests in kernel-presubmit" am: 24a8a39219 am: 69771123ba am: ac75f2d41c
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2610093

Change-Id: Id502dbe01f18f68a140290f5f0bf8b709d35bf0e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-01 22:00:27 +00:00
Edward Liaw
69771123ba Merge "TEST_MAPPING: enable vts hal tests in kernel-presubmit" am: 24a8a39219
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2610093

Change-Id: Ifb1fe3792f481cfe57d3b4e9e0f7995ced887a7c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-01 21:11:34 +00:00
Edward Liaw
24696b3e32 TEST_MAPPING: enable vts hal tests in kernel-presubmit
Enable the following tests:
VtsHalBluetoothAudioTargetTest
VtsHalGraphicsComposerV2_4TargetTest

Bug: 284307085
Bug: 258819618
Test: atest :kernel-presubmit
Change-Id: I8667eaee120777a776339481f72558566e6c94b3
Signed-off-by: Edward Liaw <edliaw@google.com>
2023-06-01 16:08:42 +00:00
ramindani
c7a880719e [HIDL composer] Verify key & value sizes are within the data size range
Sizes when invalid can cause OOB reads and causes the crash

Test: atest VtsHalGraphicsComposerV2_1TargetTest && atest VtsHalGraphicsComposerV2_2TargetTest && atest VtsHalGraphicsComposerV2_3TargetTest && atest VtsHalGraphicsComposerV2_4TargetTest
go/wm-smoke test
BUG: 252995613

Change-Id: I77e472851236eba2b8418034144c9cc8237c7143
2023-05-31 23:00:53 +00:00
ramindani
caee7cd3f6 [VTS 2.3] Add length check before reading blob
Adding a length check prevents the read() from
reading outside the bounds and prevents OOB crash.

Test: atest VtsHalGraphicsComposerV2_3TargetTest && atest VtsHalGraphicsComposerV2_4TargetTest
BUG: 252764300
Change-Id: I6231e340a925127f9c32ccb76768286f7292df58
Merged-In: I6231e340a925127f9c32ccb76768286f7292df58
2023-05-25 22:12:24 +00:00
ramindani
e6e7fdfda6 [VTS 2.3] Add length check before reading blob
Adding a length check prevents the read() from
reading outside the bounds and prevents OOB crash.

Test: atest VtsHalGraphicsComposerV2_3TargetTest && atest VtsHalGraphicsComposerV2_4TargetTest
BUG: 252764300
Change-Id: I6231e340a925127f9c32ccb76768286f7292df58
2023-05-25 22:07:04 +00:00
Kriti Dang
79bbec97c4 Change the HDR conversion VTS test to take into account sink device
capabilities

Bug: 278467239
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: I69c21b6d8b9753500a7b7a1692448b7151009ba3
2023-05-08 08:28:09 +00:00
Huihong Luo
651806f263 Reset pending commands
Allow takePendingCommands to have ownership for mComamnds so commands
are reset on each call. Make reset method to be private.

Bug: 273525126
Test: manual
Change-Id: Ifecad733e5e85d475825969296ddf68081ce9e60
2023-04-22 04:09:10 +00:00
Alex Buynytskyy
ec1198d941 UpsideDownCake is now 34
Ignore-AOSP-First: UpsideDownCake Finalization
Bug: 275409981
Test: build
Change-Id: I832ab7a8b5445ba85e27bbcf5be64906bfa0e5be
2023-04-07 23:41:20 +00:00
ramindani
ea9ab1c01e VTS add length is not zero check for executeSetClientTarget am: d00b8598bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/22434697

Change-Id: I711607fc79f2ea513daba2b5017b9b5222a13d08
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-05 00:49:57 +00:00
ramindani
d00b8598bb VTS add length is not zero check for executeSetClientTarget
Test: atest VtsHalGraphicsComposerV2_1TargetTest
BUG: 252764410
Change-Id: Icd15f6e7bfdd7b3e3d0d4b407195258d4171c560
(cherry picked from commit 708d49cfce)
Merged-In: Icd15f6e7bfdd7b3e3d0d4b407195258d4171c560
2023-04-03 20:55:08 +00:00