Commit Graph

124 Commits

Author SHA1 Message Date
Yifan Hong
d5b5b2ecea add default implementation to android.hardware.tests.foo/bar/pointer@1.0
Test: hidl_test
Test: mma

Merged-In: I808423c040099354513db0ad108210fcec17c8a7
Change-Id: I808423c040099354513db0ad108210fcec17c8a7
2016-10-18 11:39:00 -07:00
Steven Moreland
45ca9939a0 Merge "Revert "Remove test for overloaded function."" 2016-10-18 18:34:04 +00:00
Steven Moreland
a3d9fe2cd4 Revert "Remove test for overloaded function."
This reverts commit 93800287fb.

Change-Id: I95b0aeb64eaf9938c6558e5817bd79c3f2e5496e
2016-10-18 18:32:49 +00:00
Treehugger Robot
51a703aea4 Merge "Remove test for overloaded function." 2016-10-18 17:45:28 +00:00
Steven Moreland
93800287fb Remove test for overloaded function.
Bug: 31758541
Test: hidl_test
Change-Id: Ib02d9e8531ea2b7ec36bf8785e6827cfa45b53ba
2016-10-17 17:53:09 -07:00
Yifan Hong
deb0cfcea3 Add test for single letter IDs.
Test: mma

Bug: 32068694
Change-Id: I56659715beaadd8ebb3b9f36558e7ebcdb3e4d27
2016-10-17 16:57:51 -07:00
Treehugger Robot
e397b73792 Merge changes from topic 'nfc-style'
* changes:
  nfc: update default implementation to match style.
  nfc: reflect style guide.
2016-10-17 15:57:16 +00:00
Hridya Valsaraju
954515f73a Modify return values of read/write/config methods to bool
Modify return values of read/write/config methods to bool
for the FMQ unit tests and benchmarks.

Bug: 31780470
Test: Built and ran existing FMQ unit tests and benchmarks

Change-Id: I2b7c9cf073f0c1a2908d48552e258ce21240ae64
2016-10-14 23:55:52 +00:00
Steven Moreland
a74426d691 nfc: update default implementation to match style.
Test: make android.hardware.nfc@1.0-impl
Change-Id: I00357d40df1a6b2289f86b33d7a5833e358884d6
2016-10-14 08:24:17 -07:00
Steven Moreland
cffe8d5df4 nfc: reflect style guide.
Test: make android.hardware.nfc@1.0
Change-Id: I19b5c5a8b7e6345152441be149349933774b3de0
2016-10-14 08:23:59 -07:00
Treehugger Robot
a91254d196 Merge "Cleanup nfc service code." 2016-10-14 07:42:18 +00:00
Myles Watson
acfbd25247 Add Bluetooth HAL definition
Test: compiles
Bug: 31972505
Change-Id: I7608b0814c9ca697b21c9e115cfcd81ab1364892
2016-10-13 22:32:38 +00:00
Steven Moreland
7573963148 Cleanup nfc service code.
Test: mma
Change-Id: Ie65c5bfde292107bec567a297e86eebf5cd7fa41
2016-10-13 09:33:18 -07:00
Treehugger Robot
a3ba3c359c Merge "Added test for overloading." 2016-10-11 23:24:47 +00:00
Steven Moreland
86c848de0b Added test for overloading.
Test: make, hidl_test
Bug: 31758541
Change-Id: Ia0fdad2f0b0155065a7dec5526ab5d14a9ec1f52
2016-10-11 22:40:50 +00:00
Roshan Pius
f243631af8 wifi: Invoke failure callbacks
Invoke the failure callbacks for |requestChipDebugInfo|,
|requestDriverDebugDump| and |requestFirmwareDebugDump| methods.

Bug: 32014425
Test: Compiles
Change-Id: I49b8ae93fe846df6d9663b10d2a70eb89bd00931
2016-10-11 07:46:24 -07:00
Roshan Pius
5926828728 wifi: Add WifiRttController object
Create the WifiRttController object and add the createRttController
method in WifiChip.

Bug: 31991232
Test: Compiles
Change-Id: I34649097c96488c660bef5acceac1a6478f80dca
2016-10-11 07:46:24 -07:00
Roshan Pius
35d958c43f wifi: Add Iface related method implementations in WifiChip
Add the iface creation/retrieval/list method implementations in WifiChip.
WifiChip does not yet support the chip mode configuration. So, all
|createIface| method calls succeed today. Once the mode configuration
changes are in place, we will deny iface creation requests depending on
the iface combination supported in the current mode.

The iface objects are all invalidated and deleted on mode switches and
when HAL is stopped.

While there,
Change the |callbacks_| member to std::vector instead of std::set. We
don't really need a set to store the list of callbacks.

Bug: 31943042
Test: Compiles
Change-Id: Ic94864c8b11aabbe569b5157d68d6056364a3c4c
2016-10-11 07:46:24 -07:00
Roshan Pius
3e2d671a4c wifi: Add the various iface object implementation
This CL adds the implementation classes for the various iface HIDL
interfaces defined. These classes implement the
|getName| & |getType| methods in the Iface HIDL interface.

Integration of these objects with WifiChip class is implemented in the
next CL.

Bug: 31943042
Test: Compiles
Change-Id: I219afd6441e15c76cf7c61f7bcd2b3568dba2b98
2016-10-11 07:46:24 -07:00
Roshan Pius
ab5c471b0b wifi: Remove "Wlan" prefix from wifi_legacy_hal public methods
All the legacy HAL API's in the function table uses the "wlan0"
interface handle for the various operations. But, this is an internal
detail that should be abstracted inside WifiLegacyHal class. So, rename
the public methods to remove the "Wlan" prefix from them.

Also, add methods to fetch the iface names to use for the various types
of HAL.

Bug: 31943042
Test: Compiles
Change-Id: I35a6cdea0ad7cff295d33c0245953258129fba43
2016-10-11 07:46:24 -07:00
Roshan Pius
cd566bddd7 wifi: Add support for multiple chips in IWifi
The modified HIDL interface supports multiple chip instances on the
device. Modify the |IWifi| interface implementation to support the new
methods.

NOTE: The legacy HAL implementation will continue to only expose 1 chip.

While there,
Change the |callbacks_| member to std::vector instead of std::set. We
don't really need a set to store the list of callbacks.

Bug: 32003988
Test: Compiles
Change-Id: I31e704100f716e223095890279bdf93d2a04377e
2016-10-11 07:46:24 -07:00
Roshan Pius
fcbf923d3a wifi(interface): Add RTT Controller object
Create a RTT controller object to use for initiating all the RTT related
HAL opertations.
Since we don't want to fix the iface on which to initiate RTT operations,
these methods will be rooted in a new standalone object |RttController|.
Framework can decide to intiate an instance of |RttController| on a
specified iface or let the implementation pick one.

Bug: 31991232
Test: Interface compiles.
Change-Id: I65f7a7babd72db26ce6549f572abd9ef73700c82
2016-10-11 07:46:24 -07:00
Roshan Pius
adcfba4b09 wifi(interface): Add Iface objects
Create a child object under IWifiChip to represent each interface
within the chip. Each iface object has a |type| & |ifname| which should
help us uniquely identify them. This should help us expose methods that
are applicable only to a specific interface type.

While there,
Assign a unique id to every chip on the device.
Add IWifi.listChipIds() to retrieve the list of chip Id's avaiable on the
device. IWifi.getChip() will now use the provided Id to retrieve the
corresponding IWifiChip object(because HIDL language doesn't support
vec<HIDL objects>).

Bug: 31943042
Bug: 32003988
Test: Interface compiles (not implementation)
Change-Id: I723007566ca4220362c02d0f452753fee4e31fce
2016-10-11 07:46:24 -07:00
Treehugger Robot
2078f22513 Merge "Initial version of radio hal" 2016-10-10 23:53:11 +00:00
Amit Mahajan
4cb7b84aba Initial version of radio hal
Test: No build issues. Unused interface; nothing to test yet.

Bug: 32020264
Change-Id: Ie57eb43b777dadbc0b0350f2e33227be3f1d65f1
2016-10-10 14:36:50 -07:00
Yifan Hong
a543fe6ab0 Merge "Add test for importing a single type." 2016-10-10 19:49:45 +00:00
Yifan Hong
799ebcb7fa Add test for importing a single type.
Test: `cd system/tools/hidl && mma`

Bug: 31821285

Change-Id: I0be97b16b84f76b64c09f9dc52709416601cbbdf
2016-10-07 19:43:43 -07:00
Yifan Hong
e312006887 Add test for fixing 0XFF (upper X)
Bug: 31983995

Test: make android.hardware.tests.expression@1.0
Change-Id: I05bed0164c5cc988843a60d1efc8f5aeb4986b9b
2016-10-07 16:32:57 -07:00
Steven Moreland
13e19421b3 Merge "Revert "Revert "Revert "nfc: reflect style guide."""" 2016-10-06 02:51:18 +00:00
Steven Moreland
6d4d412617 Revert "Revert "Revert "nfc: update default implementation to match style."""
This reverts commit 22be21e864.

Change-Id: I0534b0eb87623091685fa0e2d94d744d2aeaa4ca
2016-10-06 02:50:58 +00:00
Steven Moreland
20ea4ea288 Revert "Revert "Revert "nfc: reflect style guide."""
This reverts commit 106bc9d27a.

Change-Id: Ie2e0ad4aeaa58c45bab05234615bd7fa02b84c1a
2016-10-06 02:50:48 +00:00
Treehugger Robot
e57188f95e Merge "Add test for missing package name for FQName lookup." 2016-10-06 00:19:36 +00:00
Treehugger Robot
73e6598317 Merge changes from topic 'rename_wifi_hal'
* changes:
  wifi(interface): Rename interface to iface
  wifi(interface): Add/Correct docstring params
  wifi: Add implementation of driver/firmware memory dumps
  wifi: Add Implementation of IWifiChip.requestChipDebugInfo
  wifi: Use hal_tool & if_tool
  wifi: Restructure wifi legacy HAL implementation
  wifi: Change namespace
  wifi: Move legacy HAL implementation
2016-10-05 23:35:12 +00:00
Yifan Hong
c5be5aca63 Add test for missing package name for FQName lookup.
Bug: 31705664

Test: `cd system/tools/hidl && mma`
Change-Id: If3568f1d1e77ad97ccfce5eac5938048f3852560
2016-10-05 15:50:28 -07:00
Yifan Hong
223b82a07d Add test for vec<vec<T>> as a return value.
Bug: 31955917

Test: hidl_test
Change-Id: I9ae7f9b04126261210cb4621266676727877d92f
2016-10-05 14:12:30 -07:00
Roshan Pius
271f2c2d9c wifi(interface): Rename interface to iface
The HIDL objects are called "interface", so rename the wifi interface to
iface to distinguish between them better.

This is especially needed in the follow up CL.

Bug: 31943042
Test: mmm -j32 hardware/interfaces/wifi/1.0/
Change-Id: I3bc34930f75159d26321c0e071af9084d0585508
2016-10-05 10:30:24 -07:00
Roshan Pius
6f31d92e59 wifi(interface): Add/Correct docstring params
Changes in the CL:
1. Add missing docstring params in the HIDL interface.
2. Reword some method docs. Occurences of "will" is replaced
by "must" (based on comments received on supplicant HIDL interface:
go/aog/275115).
3. Add onFailure callbacks for all the methods and added docstrings for
them.

Bug: 31352200
Test: mmma -j32 hardware/interfaces/wifi/1.0
Change-Id: Ib7152625851023d6244f742bb77a8fdc0829e00d
2016-10-05 10:30:15 -07:00
Treehugger Robot
67f700350a Merge "Revert "Revert "nfc: update default implementation to match style.""" 2016-10-05 17:22:30 +00:00
Roshan Pius
cdb77f3cf2 wifi: Add implementation of driver/firmware memory dumps
Bug: 31352200
Test: mmma -j32 hardware/interfaces/wifi/1.0/default
Change-Id: I25d42cfd4c2b1ea7e63bdc036f37f81aed93c565
2016-10-05 09:22:06 -07:00
Roshan Pius
4b26c832ed wifi: Add Implementation of IWifiChip.requestChipDebugInfo
Bug: 31352200
Test: mmma -j32 hardware/interfaces/wifi/1.0/default
Change-Id: Id0c02e37dac66de6f830785881cb67f113c0fb19
2016-10-05 09:21:07 -07:00
Steven Moreland
22be21e864 Revert "Revert "nfc: update default implementation to match style.""
This reverts commit 3768be324b.

Change-Id: Ifecd3ac227af14b49eba83c1126d51996ce3b8f5
2016-10-05 15:46:37 +00:00
Steven Moreland
106bc9d27a Revert "Revert "nfc: reflect style guide.""
This reverts commit 69bb15e06e.

Change-Id: Icd6ac819606c83e1518c4b6252f6416f55e618fd
2016-10-05 15:46:21 +00:00
Roshan Pius
908a69a53a wifi: Use hal_tool & if_tool
Changes in the CL:
1. Currently |WifiNative.cpp|, uses |hal_tool| to initialize the
function table and |if_tool| to set the interface up when |startHAL|
method is invoked. Use the same sequence in the HIDL'ized HAL.
2. Remove the assertion if the function table initialization fails. This
will result in a failure indication on starting the HAL now.

Bug: 31352200
Test: mmma -j32 hardware/interfaces/wifi/1.0/default
Change-Id: I268845ed62158b6a2ff36659f0bb15c4100a7222
2016-10-04 18:36:25 -07:00
Roshan Pius
aabe575536 wifi: Restructure wifi legacy HAL implementation
Restructured the existing code to create a new class called
|WifiLegacyHal|. This class will be used as a wrapper to invoke
all the legacy HAL functions and handle the "C" style callbacks.

Bug: 31936700
Test: mmma -j32 hardware/interfaces/wifi/1.0/default
Change-Id: I63e8543f49886f8446101320a97d1e96e30d1035
2016-10-04 18:36:22 -07:00
Roshan Pius
79a9975d07 wifi: Change namespace
Move the implementation to "android::hardware::wifi:V1_0::implementation"
namespace.
This is following the style guidelines in NFC HIDL
implementation(go/aog/279421).

While there,
Run checkstyle to correct formatting issues.

Bug:31936700
Test: mmma -j32 hardware/interfaces/wifi/1.0/default
Change-Id: I5600a60a0041b3318ed9289823ec335a8ed8a83d
2016-10-04 13:23:20 -07:00
Roshan Pius
3c4e8a358c wifi: Move legacy HAL implementation
Changes in the CL:
1. Move the legacy HAL implementation from
"frameworks/opt/net/wifi/wifi_hal_legacy" to
"hardware/interfaces/wifi/1.0/default".
2. Renamed the .rc file and the module name in makefile to
conform to the HIDL style guide.

Files renamed from:
wifi_hal_service.cpp/h -> wifi.cpp/h
wifi_chip_service.cpp/h -> wifi_chip.cpp/h
main.cpp -> service

Bug: 31821133
Test: mmma -j32 hardware/interfaces/wifi/1.0/default
Change-Id: I5e65e2fdb5596346bde6963588031dcea42d633a
2016-10-04 13:10:25 -07:00
Yifan Hong
61db854465 Add test for referring to nested types.
Bug: 31821285

Test: `make hidl_test && adb sync && adb shell hidl_test`
Change-Id: Iae030baa5bbe6e890512b494a0b657163c6a99a6
2016-10-04 10:40:55 -07:00
Martijn Coenen
ea4b569fee Merge "Revert "nfc: reflect style guide."" 2016-10-04 16:44:14 +00:00
Steven Moreland
3768be324b Revert "nfc: update default implementation to match style."
This reverts commit 6b6381cb58.

Change-Id: I2891a4ea774ad0047d9f99074fe773808dae0f7c
2016-10-04 16:37:11 +00:00
Steven Moreland
69bb15e06e Revert "nfc: reflect style guide."
This reverts commit e0c416a6f2.

Change-Id: I3fec772343d88a29225aef61bb549fef8ac9b797
2016-10-04 16:36:21 +00:00