On binder death, the cookie is the value that is passed to the death
recipient. This value shouldn't be nullptr here since our onDeath()
function expects an instance of BootControlClientAidl. If that doesn't
exist, we have a null pointer dereference which will cause update_engine
to crash.
Bug: 369289491
Test: crash bootctl service
Change-Id: I0bed4680c23b7d3516ed43aa566c4474962244fa
BootControlClientAIDL and BootControlClientHIDL are child classes of BootControlClient. We should
use proper inheritance and override the base class methods.
Test: th
Change-Id: Ia741f28bc463b55dc075a17901a024566324564a
Use of StreamSwitcher causes threading issues with the FMQ due to
using it in a way which is not anticipated by the FMQ design.
Stream implementations that need to change its behavior depending
on connected devices must do it without changing the I/O thread.
For example implementations please refer to PrimaryStream and
RemoteSubmixStream.
The class code has been moved to 'deprecated' directory and
namespace, and will be removed in the future. Any classes which
currently depend on StreamSwitcher should be updated mechanically
to use the new name and the include file location. Such classes
need to be planned to be overhauled as soon as possible to remove
the dependency on StreamSwitcher.
Bug: 300130515
Test: m
Change-Id: I6b0d20274013826360ca5efa69a01df9457db9c6
When boot control service dies, we should log that it is no longer
available. To do this, we should register a death recipient in the
client.
Bug: 369289491
Test: kill bootctl service while running OTA
Change-Id: If766451cafe939725e7a88b1ca23b2a4af0d1a80
Rewrite Power VTS check support using AIDL versions instead of
API versions, and change hint session tests to use a common test
fixture.
Bug: 294917526
Test: atest VtsHalPowerTargetTest
Merged-In: I3cef31fa8dc6341a47d173a13d07521bafe4a1e5
Change-Id: I3cef31fa8dc6341a47d173a13d07521bafe4a1e5
Added test for setAudioPortConfig with invalid gain input in audio HAL
VTS. Also added HAL version check in audio HAL VTS.
Bug: 336370745
Test: atest VtsHalAudioCoreTargetTest
(cherry picked from commit 7f1ab0c33c)
Merged-In: I0f14c203c253de56ca0c3711927b2dcafa1b0ea7
Change-Id: Ib0b0d7266e249359f2750412f3fbabe1b2be958e
The root cause is that the dequeue/queue v4l2 buffers is driven by requests.
The potential issue is already noticed and commented in commented in OutputThread::threadLoop().
But setup a sensor thread may need change in architecture.
The patch fix the issue by dropping too old buffers.
Bug: 368087676
Change-Id: I5d6711bc3a73d0bc043b596aee6ce4af4c1841da
Signed-off-by: Fang Hui <hui.fang@nxp.com>
Since use of StreamSwitcher causes the worker thread to be changed
during connected device change, its use must be avoided. We intend
to remove StreamSwitcher completely in future.
Bug: 300130515
Bug: 338974476
Bug: 368723297
Bug: 369272078
Bug: 369289912
Bug: 369964381
Test: atest CtsMediaAudioTestCases
Test: atest VtsHalAudioCoreTargetTest
Change-Id: I4f6fd35f69d73641a86e1102f1d30d5e8f626e8f
Fix an incorrect error message for VehicleApPowerStateReport ON.
Flag: EXEMPT HAL fix
Test: Manual test
Bug: 371614400
Change-Id: I81406931d27e2f8b174b52720d4f502e0e32fdd4
Since use of StreamSwitcher causes the worker thread to be changed
during connected device change, its use for the primary HAL streams
must be avoided. The reason is that switching of the FMQ reader thread
accompanied with simultaneous writes from two writers: one on the
framework side, another on the HAL side sending the "exit" command,
violates threading assumptions of blocking FMQ and causes spurious
races that eventually make FMQ non-functional.
Bug: 300130515
Bug: 368723297
Bug: 369272078
Bug: 369289912
Bug: 369964381
Test: atest VtsHalAudioCoreTargetTest
Change-Id: I14dc6fc08ae9e8aaaf3cd80e96b20dd1df54f633
The types were split into another package so some newer devices are
using this new package.
The topic was cherry-picked but the branch configs made a mess. So we
are only cherry-picking this new hash for tests.
The new hash is added first, because the last hash in the file is
expected to the be current hash.
Bug: 293945485
Bug: 364817993
Test: build cuttlefish on this branch
Merged-In: I9e90ada03144b49245dc6b55a0fb2fa2eb6f3893
Change-Id: I6d3ef12301532d8b3fb8729abbbe6bd2dde86c91
Parsed card id and device id from output bus device address,
and used them to write output data into corresponding PCM
devices in stream alsa.
Bug: 336370745
Test: atest VtsHalAudioCoreTargetTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4d71bd736be6f52a9e954dd518be0b6ece3ddc1b)
Merged-In: I18efa2d1aea233375906efc0aa9c93c8f3b464e8
Change-Id: I18efa2d1aea233375906efc0aa9c93c8f3b464e8
These containers use std::allocator<const T>, which is an undocumented
libc++ extension to the C++ standard library. The extension was removed
in llvm.org/PR96319. Use an ordinary non-const T instead.
Bug: http://b/349681543
Test: m VtsHalMediaOmxV1_0TargetStoreTest
Flag: EXEMPT, refactor to fix build failure
Change-Id: I5b5ceed1d2618b7ce1f979242f33f6bc92df0545
The CtsVirtualDevicesTestCases suite was split into
tests per sub-system, need to update our mapping.
Bug: 316017930
Test: atest CtsVirtualDevicesAudioTestCases
Change-Id: I27457a499916fd1e3e1db2e0e6ad3374d02c0a11
... as this might allow an underlying `RenderEngineThreaded` thread
to race against the process shutdown.
Bug: b/361574971
Test: ATP cuttlefish_gfxstream_guest_angle_graphics_vts_tests
Change-Id: Ief71d8931ec3560780a850d8bb8bc727bbff5c52
The types were split into another package so some newer devices are
using this new package.
The topic was cherry-picked but the branch configs made a mess. So we
are only cherry-picking this new hash for tests.
Bug: 293945485
Test: none
Change-Id: Ie55ccf8b368b664642723f13887767032efef024
Revert submission 3283232-cherrypicker-L65300030006744043:N33800030107981038
Reason for revert: Droidmonitor created revert due to b/370755706. Will be verifying through ABTD before submission.
Reverted changes: /q/submissionid:3283232-cherrypicker-L65300030006744043:N33800030107981038
Change-Id: I574abf94fcc5b503388e5b7bf377bfdb88b6f39e
