Commit Graph

324 Commits

Author SHA1 Message Date
Jooyung Han
2dd88e6c8a Explain how to add service_contexts for stable-c mapper
Stable-c mapper instance should be declared in two ways:
- vintf manifest
- service_contexts

The latter part was missing.

Bug: 336010345
Change-Id: I7bd776bf7d943049ef319c90739dae10071409ab
Test: documentation
2024-04-25 18:48:51 +00:00
Hsin-Yi Chen
219876109a Move libimapper_stablec ABI dumps from prebuilts/abi-dumps
The update process for prebuilts/abi-dumps/platform will be adapted for
trunk stable. The ABI dumps for libimapper_stablec are moved to
"abi-dumps" in this project so that the trunk stable release process
will not affect them.

Test: m libimapper_stablec_abicheck
Test: development/vndk/tools/header-checker/utils/create_reference_dumps.py \
      -libs libimapper_stablec_abicheck --lib-variant PLATFORM \
      -ref-dump-dir hardware/interfaces/graphics/mapper/stable-c/abi-dumps \
      -products aosp_arm64
Bug: 333532038
Change-Id: Ia69daa721ef983c18118bd6d0a70dd5b7a0a47a2
2024-04-16 20:21:56 +08:00
Kiyoung Kim
9e9d41d162 Remove VNDK definition(s)
As of VNDK deprecation, any libraries that defines vndk is no longer
valid anymore. This change removes all VNDK definition(s) from modules
which was VNDK.

Bug: 328994089
Test: AOSP CF build succeeded
Change-Id: Ifdade9c052db29c989ce7d804ba725361c4c0f8e
Merged-In: Ic4f19113c1a25dc1fb60cdfbf9c0f2d8d7d09726
2024-04-05 02:29:07 +00:00
John Reck
52414d1c2a Fix annotation in doc
Change-Id: I4fb90e7b30659227263087c85b98db31bb039184
2024-03-14 01:58:19 +00:00
Treehugger Robot
52e9ebfa91 Merge "Use new API to load mapper" into main am: 6a5da15033
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2960862

Change-Id: If9bc9393e42d5af792d04fabda945c2bb1a5a028
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-14 01:32:01 +00:00
Jooyung Han
0425704133 Use new API to load mapper
AServiceManager_getDeclaredPassthroughHal() can replace
android_load_sphal_library().

Bug: 325018681
Test: VtsHalGraphicsMapperStableC_TargetTest
Change-Id: I004355a9df8bd1ba4f9fb00149d7fddb9ac9f499
2024-02-13 21:37:47 +09:00
Treehugger Robot
74dc4cc5d7 Merge "[DON'T BLOCK] Test ownership migration rules" into main am: 27e97308c4
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2950589

Change-Id: Ie4f36b193820490e606e7f5100ca29200f832fa2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-07 01:45:21 +00:00
Aditya Choudhary
ad2ba1b851 [DON'T BLOCK] Test ownership migration rules
This CL is created as a best effort to migrate test targets
to the new android ownership model. If you find incorrect or unnecessary
attribution in this CL, please create a separate CL to fix that.

For more details please refer to the link below,
go/new-android-ownership-model

Bug: 304529413
Test: N/A
Change-Id: Ic8c4bd6ac246e7efa98bbdaf822d12ae8e1230a5
2024-02-05 15:45:22 +00:00
Jason Macnak
cde05dd247 Merge "Ensure AIMapper and underlying IMPL outlive IMapperProvider" into main am: b8c23a8a7d am: 4c11b51986 am: 8dcf909435 am: f5dbe8113a am: ba4b850b8a
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2781709

Change-Id: Ie4edc900be0e48bb00e3913ec75456347a58f81a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-11 02:14:30 +00:00
Jason Macnak
7d201b58fa Ensure AIMapper and underlying IMPL outlive IMapperProvider
... as a

  static vendor::mapper::IMapperProvider<IMPL> provider;

may be destructed during a clean process exit (during __cxa_finalize())
but the underlying IMPL may still be in use on other threads.

Bug: b/304343434
Test: boot Cuttlefish
Change-Id: I80687494c61210d527908b5a67375950ca45c8ea
2023-10-10 11:54:00 -07:00
sergiuferentz
7d7a24d5f6 Bump android.hardware.graphics.common V4->V5
Test: Build
Bug: 291142745
Change-Id: Ib0002feb982ffcc37fa7b69493c644b7a835cf4f
2023-10-03 16:14:03 +00:00
Alec Mouri
2ee3317613 Add API level for IMapper 4's bad metadata test
Some devices shipped with broken validation for HDR metadata. Relax the
test for vendor freeze purposes.

Bug: 276843519
Test: VtsHalGraphicsMapperV4_0TargetTest
Change-Id: I564f4bd12145f7831faa1e5a0f2d2abe074e4769
2023-08-04 21:59:23 +00:00
John Reck
0cf823b31d Merge "Add test for USAGE query for >32-bit" am: 4ef9f5dd2b am: a1171f30d8 am: 0284fd727c
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2607685

Change-Id: I81d2669f98a9716acb638d632cfb28442b122add
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-30 22:31:34 +00:00
John Reck
4ef9f5dd2b Merge "Add test for USAGE query for >32-bit" 2023-05-30 20:11:24 +00:00
John Reck
b9cd45c741 Add test for USAGE query for >32-bit
Bug: 284333373
Test: this
Change-Id: Ie9683e5cccb85db1280b85b0b32d7cec042d79a3
2023-05-26 16:55:09 -04:00
Treehugger Robot
cb75e7a3dc Merge "Fix typo in FreeBufferNegative test" am: 9886fbe306 am: ae2e886386 am: 75975657f2
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2595001

Change-Id: I2bf5aefeaac8e000acff3a9b59afb77a7634650f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-19 22:21:26 +00:00
John Reck
1ba7c5124c Fix typo in FreeBufferNegative test
Wrong buffer was being free'd, triggering ASAN violations

Fixes: 278138497
Test: this
Change-Id: I7be7c85a55a58d01576324d2cd201e5a03e88283
2023-05-19 14:24:21 -04:00
Treehugger Robot
534c5eeea3 Merge "Revert "graphics: improve preloading for IMapper default impl"" am: aab958fef0 am: 3ce3ee6427 am: d95f1801c7
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2497376

Change-Id: I1562de76110f9d938f00e3c603f6a2cf69e19a14
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 20:57:13 +00:00
Chia-I Wu
7ca92515be Revert "graphics: improve preloading for IMapper default impl"
This reverts commit 6d189b71a2.

Reason for revert: b/273884219, beagle_x15

Change-Id: I9706fc46f9aedbeb4bbcff7ebcb45939bcd20680
2023-03-20 16:36:56 +00:00
Chia-I Wu
34eece60f5 Merge "graphics: improve preloading for IMapper default impl" am: 960c33c599 am: 697fddee77 am: 227a9f4155
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2459229

Change-Id: Ic80d75ea9db96d5dce2dd86942bddbecb0c5cd74
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-28 21:06:57 +00:00
Chia-I Wu
6d189b71a2 graphics: improve preloading for IMapper default impl
When GraphicBufferMapper::preloadHal dlopens the default impl, make sure
the gralloc module is also dlopen'ed.

Bug: 269664560
Test: android.view.cts.PixelCopyTest#testVideoProducer on grunt

Change-Id: I57418338d5212fb9a2c1ea82eba63d855f69ff32
2023-02-27 14:19:12 -08:00
Alec Mouri
bedde5e845 Check the correct sysprop for P010 support for gralloc 3 and 4. am: 960c14db22
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2441523

Change-Id: I86b2df035255b94e8a682c1870efea0df450aec4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-18 02:10:40 +00:00
Alec Mouri
960c14db22 Check the correct sysprop for P010 support for gralloc 3 and 4.
We need to check the first api level that the vendor shipped with.

Also check P010 support in the preamble of the relevant test rather than in allocate(), since otherwise either allocate() may incorrectly skip some tests or allocate() may succeed but with the wrong layout information.

Bug: 257442231
Test: VtsHalGraphicsMapperV4_0TargetTest
Change-Id: I00ae5aa01117704158c38f0689e91df99473e208
Merged-In: I00ae5aa01117704158c38f0689e91df99473e208
2023-02-16 23:16:14 +00:00
Alec Mouri
78d76ea43f Check the correct sysprop for P010 support for gralloc 3 and 4.
We need to check the first api level that the vendor shipped with.

Also check P010 support in the preamble of the relevant test rather than in allocate(), since otherwise either allocate() may incorrectly skip some tests or allocate() may succeed but with the wrong layout information.

Bug: 257442231
Test: VtsHalGraphicsMapperV4_0TargetTest
Change-Id: I00ae5aa01117704158c38f0689e91df99473e208
2023-02-15 02:37:49 +00:00
Yi Kong
0214404f6e Fix compiler warning discovered by clang-r484482 am: 07448c2929 am: ba993e51e8 am: 661d9018c7
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2402792

Change-Id: I195de8f952c0b9091e4e57d64535e4e2014f3fb5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-25 20:10:23 +00:00
Yi Kong
07448c2929 Fix compiler warning discovered by clang-r484482
external/googletest/googletest/include/gtest/gtest.h:1545:11: error: invalid operands to binary expression ('const std::vector<unsigned char>' and 'const android::hardware::hidl_vec<unsigned char>') [clang-diagnostic-error]
  if (lhs == rhs) {
      ~~~ ^  ~~~

Test: presubmit
Change-Id: Iabe98a58d5dc5b9943c38240da2d8df6ac61fb7f
2023-01-26 01:23:03 +09:00
Devika Krishnadas
e794f8f5e4 Merge "gralloc4-vts: Remove assert for sizeInBits for RAW formats" 2023-01-20 20:57:09 +00:00
Treehugger Robot
7603d62a20 Merge "Drop <name>I</name> from mapper HAL." am: d2bbda8b32 am: 116ddaf033 am: 81f4ddd0c5
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2392038

Change-Id: Ieb1ffe7a2a24c93b6696acd9d9c178475b826aef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-20 18:54:25 +00:00
Treehugger Robot
d2bbda8b32 Merge "Drop <name>I</name> from mapper HAL." 2023-01-20 17:10:47 +00:00
Yifan Hong
ccb250d550 Drop <name>I</name> from mapper HAL.
libvintf now supports empty interface names for native HALs.

Test: TH
Bug: 264267049
Change-Id: Ie525478631e785ce8b9d813d08b0a92331047ced
2023-01-17 15:23:32 -08:00
Devika Krishnadas
7f3f32177b gralloc4-vts: Remove assert for sizeInBits for RAW formats
sizeInBits for components in RAW formats do not have to be invalid even if the bits are not contiguous.

Bug: 265348037
Test: atest VtsHalGraphicsMapperV4_0TargetTest

Change-Id: I69f58226e988c20b8ba5499ffec4fa0e2b2a68df
Signed-off-by: Devika Krishnadas <kdevika@google.com>
2023-01-13 00:28:04 +00:00
Treehugger Robot
ad6f10ae9f Merge "Clarify format BLOB locking" am: 66cf51232c am: c764d58ed8 am: 36c65361a0
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2381019

Change-Id: I475aa5d0f415480aa1d9d8c599c55c4c8c0dceaf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 07:32:53 +00:00
John Reck
0c1a059f01 Clarify format BLOB locking
Bug: 162571907
Test: n/a doc only change
Change-Id: I3ab26cee8a790067447781e13062c62fc3b7c01c
2023-01-10 11:25:56 -05:00
John Reck
741ffc2fd8 Merge "Add a README and a standardizable VERSION" am: a74147236c am: 313e0cec86 am: f42300352e
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2375176

Change-Id: I68e182beadfeaa8cb932a8fab501812cca694294
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-09 20:36:39 +00:00
John Reck
0124abc1e9 Add a README and a standardizable VERSION
* Changes the compatbility matrix version to 5.0 & marks optional
* Tweaks the interface name in case it doesn't get removed soon
  (otherwise readme looks silly)
* Adds a README.md to mapper/stable-c
* Adds VTS test to validate versions match

Test: build + mapper VTS

Change-Id: I9b1256e07aaf2876d579a5487d2051c60097fb70
2023-01-06 17:40:16 -05:00
John Reck
2b3eccb904 Merge "Add stride query" am: 0797e36036 am: 04d190b3c8 am: 2e7c541ebe
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2360899

Change-Id: I58bfee442be24701d7ae2e98cacb4e34b1b1b219
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-06 20:57:54 +00:00
John Reck
2c2cfc9341 Add stride query
Fixes: 261856851
Test: VtsHalGraphicsMapperStableC_TargetTest

Change-Id: Ib49df2d46dd55848c4854179bd6205c86c232a6d
2023-01-04 16:41:26 -05:00
John Reck
0e4732c1a5 Adjust IMapperMetadataTypes.h to match gralloc4 encoding
Specifically include the header encoding. Initially
omitted as it's a bit redundant, the value in having
bit-for-bit identical encoding between gralloc4 &
imapper5 seems worthwhile enough to keep it.

Test: impltests + VtsHalGraphicsMapperStableC
Change-Id: Iee37bb97acf40362c301a06f9118938b1a0c2cd9
2022-12-15 13:50:07 -05:00
John Reck
749f5af092 Add some more tests & tweak spec around SMPTE2094-40
Test: this
Change-Id: If7c549b8efcf490859f10c225a700188b76a54fa
2022-12-15 13:49:55 -05:00
John Reck
800d77ccae Add libui requirements
Test: make
Change-Id: I78a3a7239b07976ad1ab0fc89c017a1defee2587
2022-12-13 18:44:37 -05:00
John Reck
606e156ed9 Merge "Add ABI check to IMapper5" 2022-12-09 19:13:05 +00:00
John Reck
5868a0de40 Merge "Adjust IMapperMetadataTypes.h to match gralloc4 encoding" 2022-12-08 22:02:22 +00:00
Marc Kassis
9c428fe3ed graphics.common V3 -> V4
Bug: 251177105
Test: m
Change-Id: I816b8e14a0741402090cdc4732c2a904e830ff4e
Merged-In: I1cb84ec85f98789d0737207a1661b39a25538c96
Merged-In: I2e1561f4ccb59a2a833af9a7afd07840ab2ebfa4
2022-12-07 10:53:12 +00:00
John Reck
97f313746f IMapper 5 - the Stable C approach
Test: make VtsHalGraphicsMapperStableC_TargetTest VtsHalGraphicsAllocatorAidl_TargetTest

Change-Id: I910b27f388e3fb7261425dd4b2133885c05edd37
Merged-In: I910b27f388e3fb7261425dd4b2133885c05edd37
2022-12-01 17:37:59 +00:00
John Reck
c1e4c064b3 Add ABI check to IMapper5
Bug: 254345788
Test: Make change, verify build fails
Change-Id: Ib97b26f1483293b0461c47184ae39c48b9404b0f
2022-11-30 18:13:06 -05:00
John Reck
ae73a6ebd5 Add some more tests & tweak spec around SMPTE2094-40
Test: this
Change-Id: If7c549b8efcf490859f10c225a700188b76a54fa
2022-11-28 19:53:12 -05:00
John Reck
fc21e8b3ef Adjust IMapperMetadataTypes.h to match gralloc4 encoding
Specifically include the header encoding. Initially
omitted as it's a bit redundant, the value in having
bit-for-bit identical encoding between gralloc4 &
imapper5 seems worthwhile enough to keep it.

Test: impltests + VtsHalGraphicsMapperStableC
Change-Id: Iee37bb97acf40362c301a06f9118938b1a0c2cd9
2022-11-22 15:30:28 -05:00
John Reck
48c546c7e9 IMapper 5 - the Stable C approach
Test: make VtsHalGraphicsMapperStableC_TargetTest VtsHalGraphicsAllocatorAidl_TargetTest

Change-Id: I910b27f388e3fb7261425dd4b2133885c05edd37
2022-11-18 11:20:00 -05:00
Steven Moreland
eaa8469b7c Merge "graphics.common V3 -> V4" 2022-11-02 21:21:29 +00:00
Treehugger Robot
344f7933ed Merge "Update OWNERS" am: 0ea6e013ef am: 91b8d6b035 am: 27ae2a7bef
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2282841

Change-Id: I99f6ab3a12e225cacbbaeffc9d28cd5b9451d3f8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-02 20:40:19 +00:00