It's reasonable to update the global variable "currentCalls" before
notifying the reader thread. Otherwise this can cause some issues such
as null pointer dereference in other modem.
Bug: 139264227
Test: Don't have devices that uses the corresponding modem that reports
this issues. This is verified according to a partner CL:
https://partner-android-review.googlesource.com/c/platform/hardware/interfaces/+/1422356
Change-Id: Iee9e18149397c39b7c84ec1dc570b9bac7142eb6
- Run test only if LOW_POWER_MODE capability is supported.
- Modify the corresponding VTS 1.1 test to run only if the GNSS
HAL version is 1.1.
Fixes: 127434062
Test: atest VtsHalGnssV2_0Target
Change-Id: Icbd18d80468e9e5a542f2eace5bfbe45af08ca47
Merged-In: Icbd18d80468e9e5a542f2eace5bfbe45af08ca47
(cherry picked from commit 03bc98e028)
- Use IGnssCallback@2.0::gnssSvStatusCb_2_0() method to receive SV
info.
- Run the test only if SATELLITE_BLACKLIST capability is supported.
- IRNSS is excluded from blacklisting as IGnssConfiguration@2.0 is
not updated to support the blacklisting new constellation type.
- Modify the corresponding VTS 1.1 test to run only if the GNSS
HAL version is 1.1.
Bug: 128028791
Test: atest VtsHalGnssV2_0Target
Change-Id: Idd44a5a1c9d54d7434da945ecbd1ee90007f5054
Merged-In: Idd44a5a1c9d54d7434da945ecbd1ee90007f5054
(cherry picked from commit f42602678f)
After disconnect calls, we want to verify there are no more current calls
by calling IRadio.getCurrenctCalls
Test: run vts
Bug: 138413412
Change-Id: Iacca49abff11fbdfb4ae6dd060a5f150e9e4a74d
am: d7059a8549 -s ours
am skip reason: change_id I9211c3e172727f56d0cceaf91b98f8d5b3c7fc7e with SHA1 18408a93d9 is in history
Change-Id: I261c1136ef8736309d6c05a8b1e7e2384196d76b
Avoid race condition between event callback and wait context. Make
callbacktype to invalid before call function to change it.
Test: excute VtsHalWifiNanV1_0TargetTest VtsHalWifiNanV1_2TargetTest
Bug: 133484330
Merged-In: I9211c3e172727f56d0cceaf91b98f8d5b3c7fc7e
Change-Id: I0a7e27411cb8fbd877f8228e9d53b62cac424b17
Providing non-dds exemption for HAL 1.2 network scan due to some devices
only perform network scan on preferred data sim. Since logical modem
id(0/1) and physical sim slot id(0/1) are intuitively aligned. Set
first sim as dds sim, and skip the network scan on the second one
(non-dds).
Test: Vts
Bug: 135243177
Change-Id: I58b89473714dc6d3ce6567ba1809baad6cd6d799
Changes to the VTS test to support OEM's who use a separate
dedicated SAP interface.
Note: This is a VTS test change only. The default implementation does
not still support a dedicated SAP interface (OEM's can obviously
customize the default implementation for their devices).
Bug: 136645414
Test: None (verified by partner OEM)
Change-Id: I42b87bf90cfa90c7c218309164ab2b77f3685f9e
Problem:
VtsHalGraphicsComposerV2_1Target#GraphicsComposerHidlCommandTest.PRESENT_DISPLAY_NO_LAYER_STATE_CHANGES fail
the testcase setcolormode SRGB without check if current device support SRGB
Solution:
change setColorMode from SRGB to NATIVE
Verify:
verify in on franklin
Bug: 135375302
Test: build, boot, VtsHalGraphicsComposerV2_1TargetTest
Change-Id: I646c263d96b03f9d30e6563a45cff37835001609
Merged-In: I5eebe5f530e3b62037d669992cf2eca0849f10be
If HidlSetUp() bails before startPollingThread() is called (which can
happen if the HAL isn't implemented on the given device), mPollThread
will initialize with the default constructor resulting in joinable()
returning false which means calling detach() throws an exception.
Checking joinable() before detaching allows the test suite to be skipped
successfully.
Fixes: 136736906
Test: Run vts-tradefed on VtsHalSensorsV1_0Target and verify that it is
skipped successfully on a device that doesn't support HAL 1.0
Change-Id: Ie685ae2dc314edb8df2f3cc7112141a2f5e46008
Network scan tests with parameters are disabled because of vendors
failed to fully implement startNetworkScan in HAL 1.4, and GSM rat scan
with parameters will get REQUEST_NOT_SUPPORTED error from modem.
Test: VTS
Bug: 137298570
Change-Id: I99df8495c5f654cb1420b7da36d7f5128ce14dbc
Change stopNetworkScan from 1_1 to 1_2 when testing VtsHalRadioV1_2Target.
Symptom:
When vts process slot2 "startnetworkscan", it will call "stopnetworkscan()" when startnetworkscan
success. But from current design it will set stopnetworkscan to slot1(wrong slot, expect is slot2)
as bwlow log.
CTS fail log:
hardware/interfaces/radio/1.2/vts/functional/radio_hidl_hal_test.cpp:111
//Device request NwScan on 2nd Sim
06-28 11:30:22.770 radio 873 1213 F RILQ : RIL[1][Log.cpp: 48] [DispatcherModul(873,1213)]
d: [DispatcherModule]: Handling msg = RIL_REQUEST_START_NETWORK_SCAN
//But Device want to abort on Primary Sim
06-28 11:30:22.776 radio 923 1205 F RILQ : RIL[0][Log.cpp: 48] [DispatcherModul(923,1205)]
d: [NasModule]: Handling msg = RIL_REQUEST_STOP_NETWORK_SCAN[Context: IRadio(1681692777)]
Bug: 135982495
Test: Build pass. Local test VTS pass.
Change-Id: Ic53c24ab2a670e806b4ac7f192e6eb81252ade84
(cherry picked from commit 5cef297cb2)
As per spec,NFCEE_ID value dynamically assigned by NFCC
has the following range
- In NCI_2.0, 0x80 <= NFCEE ID <= 0xFE.
- In NCI_1.0, 0x01 <= NFCEE ID <= 0xFE.
Bug: 137053584
Test: VtsHalNfcV1_2TargetTest with NCI1.0 & NCI2.0 supported device.
Change-Id: I09adaca8b36900a92d737b176e09234251aae2bc
The whole test case run emergencyDial.RadioHidlTest_v1_4 first and then
come after startNetworkScan.RadioHidlTest_v1_4 test case immediately
(within ~3 secs) the NWscan failure is device in emergency call in
progress/connected while doing emergencyDial.RadioHidlTest_v1_4 test
Although emergencyDial.RadioHidlTest_v1_4 only care about command/response
is successful or not and don't care call is established or not, modem do
care about call condition is in idle/progress/connected state before it
can do NWscan
When there's dedicated channel established, modem can not perform AP
request NWscan in parallel as we are single HW modem restriction.
Test: run vts
Bug: 135595082
Change-Id: Iecba54b93b96d33b57bc59e00f082ff133d2e57b
Merged-In: Iecba54b93b96d33b57bc59e00f082ff133d2e57b
The VTS flush test case was previously deactivating sensors before
waiting for flush events to be received causing any pending flush events
to be discarded per the HAL contract.
Bug: 136472044
Test: Run test and ensure it passes
Change-Id: I23b94e650c6dbbc33640768bee356a49565ba753
GSI images do not have AVB verification enabled and therefore lack
several properties the keymaster HAL test depended on. Selectively
disable those parts of the test that would fail with AVB verification
disabled. Also disable date format checks under GSI. When invoked from
GSI the TEE-backed keymaster doesn't use the correct date format.
Bug: 130843899
Test: VtsHalKeymasterV4_0TargetTest
Exempt-From-Owner-Approval: change only affects VTS-on-GSI behavior
Change-Id: Idaafb7b515c41290c766a8132f35d498ca15f48a
1.1 IRadioConfig does not exist. radio.config@1.2 is a
minor version uprev that only updates the sub interfaces,
not the top level interface.
Test: builds
Test: on device with target-level 4, w/o this change,
with radio config 1.1, see test failure on deprecated
radio config HAL
Test: on this device, with this change, with radio config 1.1,
deprecated radio config HAL failure goes away.
Bug: 135172251
Change-Id: Id51870a8a757af0895577a27723cff8ee3ba0fdd
There is no guarantee that the static metadata
pointer passed in the "DeviceCb" contructor will
be valid after the call completes. The device
callback instance is expected to be active until
the camera session is open. Clone the required
metadata in "DeviceCb" and manage the lifetime
appropriately by using the "CameraMetadata"
wrapper.
Bug: 135976837
Test: CameraHidlTest#processCaptureRequestPreview
Change-Id: Idd3c6c8c2e5a3fc44a49712e25a04009cbd471b1
@1.4::ISap and @1.3::ISap don't exist, so we can't declare a requirement
for them.
Bug: 135627722
Test: reproduce error with vts_treble_vintf_test and then test to see
this change fixes it.
Change-Id: I8e48fcaf56701087d5720d5133ffa9b23a4ea31e
Removed the dependency on the fact that the core's new ID is always >= existing ID.
New ID and the old ID may not have any such relation.
Bug: 135475397
Fixes: 135475397
Test: Updated unit tests in VmsUtilsTest. Ran the tests on Hawk.
Change-Id: I5a7e72f36a84f5bf2d3c7bf1ccb89d27c5c0da97
The TEE keymaster has been seen to be almost a minute out of sync with
the host clock during attestation. Increase the leniency window to two
minutes.
Bug: 134408892
Bug: 134408367
Test: VtsHalKeymasterV4_0TargetTest
Change-Id: Ic256a939dcd7e7b108099cfcf237cacde8dde059
