mirror of
https://github.com/Evolution-X/hardware_interfaces
synced 2026-02-01 22:04:26 +00:00
cc489264af
Background: android.hardware.audio.common was frozen in the upstream tm-dev. Previously, the interface had only V1 (as the in-development version) and it was in the VNDK. However, after the freeze, it will have V1 and V2, and only V1 will remain in the VNDK, because we can't have multiple versions of the same AIDL interface in VNDK (it's just waste of memory). android.hardware.audio.core is a new AIDL interface that doesn't exist in TM. It is also a member of VNDK and imports the audio.common interface. So far, the import has been done without an explicit version number (i.e. `imports: ["android.hardware.audio.common"]`). As a result, V1 was imported before the freeze, and V2 (the latest) will be imported after the freeze. Problem: audio.core depending on audio.common-V2 is NOT allowed since the former is a member of VNDK, but the latter isn't. VNDK should form a closure. We are actually hitting this: ``` > error: hardware/interfaces/audio/aidl/Android.bp:71:1: module "android.hardware.audio.core-V1-ndk" variant "android_vendor.Tiramisu_arm64_armv8-a_static" (created by module "android.hardware.audio.core-V1-ndk-generator" (created by module "android.hardware.audio.core_interface")): (native:vendor:vndk) should not link to "android.hardware.audio.common-V2-ndk" (native:vendor): VNDK-core must only depend on VNDK-core or VNDK-SP ``` To fix this, make the dependency to audio.common to be explicit about the version. This change can't be uploaded to tm-dev as audio.core doesn't exist there, and must be submitted before the AIDL APIs are frozen there. Bug: 225941299 Test: m Change-Id: Iadc96d558d5c7431b0a2b0cbd28b99319a24ee44