Evolution-x/hardware_interfaces
1
0
Fork 0
mirror of https://github.com/Evolution-X/hardware_interfaces synced 2026-02-01 11:36:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

send <request active source> command to test cec message

Browse Source 
VtsHalTvCec uses <give physical address> command with broadcast
mode to test cec sendMessage function, however according to the
cec spec about the command's description which says "A request to
a device to return its Physical Address", so this command is not
right for broadcast, some cec drivers deny to broadcast this
command, which will obviously lead the VTS case fail.

So I suggest to use <request active source> command to do the job.
I have verified the case can pass on Synaptics platform with this patch.

bug-id: b/206924358

Change-Id: I040c72180cf90cfbceb6363a50a621acf888c654
This commit is contained in:
shla
2021-11-18 10:18:52 -08:00
committed by Shuilong Lai
parent 6f1e16a587
commit b1829af24e
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tv/cec/1.0/vts/functional/VtsHalTvCecV1_0TargetTest.cpp
View File

@@ -130,7 +130,7 @@ TEST_P(HdmiCecTest, SendMessage) {
message.initiator = CecLogicalAddress::PLAYBACK_1;
message.destination = CecLogicalAddress::BROADCAST;
message.body.resize(1);
message.body[0] = 131;
message.body[0] = 133;
SendMessageResult ret = hdmiCec->sendMessage(message);
EXPECT_EQ(ret, SendMessageResult::SUCCESS);
}

2
tv/cec/1.1/vts/functional/VtsHalTvCecV1_1TargetTest.cpp
View File

@@ -145,7 +145,7 @@ TEST_P(HdmiCecTest, SendMessage) {
message.initiator = CecLogicalAddress::PLAYBACK_1;
message.destination = CecLogicalAddress::BROADCAST;
message.body.resize(1);
message.body[0] = 131;
message.body[0] = 133;
SendMessageResult ret = hdmiCec->sendMessage_1_1(message);
EXPECT_EQ(ret, SendMessageResult::SUCCESS);
}