Merge "Added info to HAL docs to answer Q1 from Ford pending questions." into udc-dev

This commit is contained in:
Shrikar Amirisetty
2023-03-13 19:12:01 +00:00
committed by Android (Google) Code Review
2 changed files with 26 additions and 0 deletions

View File

@@ -43,6 +43,8 @@ import android.hardware.automotive.vehicle.VehiclePropertyType;
enum VehicleProperty {
/**
* Undefined property.
*
* This property must never be used/supported.
*/
INVALID = 0x00000000,
/**

View File

@@ -296,6 +296,30 @@ TEST_P(VtsHalAutomotiveVehicleTargetTest, setNotWritableProp) {
ASSERT_EQ(setValueResult.error().code(), ErrorCode::ACCESS_DENIED_FROM_VHAL);
}
// Test get(), set() and getAllPropConfigs() on VehicleProperty::INVALID.
TEST_P(VtsHalAutomotiveVehicleTargetTest, getSetPropertyIdInvalid) {
ALOGD("VtsHalAutomotiveVehicleTargetTest::getSetPropertyIdInvalid");
int32_t propId = toInt(VehicleProperty::INVALID);
auto getValueResult = mVhalClient->getValueSync(*mVhalClient->createHalPropValue(propId));
ASSERT_FALSE(getValueResult.ok()) << "Expect get on VehicleProperty::INVALID to fail";
ASSERT_EQ(getValueResult.error().code(), ErrorCode::INVALID_ARG);
auto propToSet = mVhalClient->createHalPropValue(propId);
propToSet->setInt32Values({0});
auto setValueResult = mVhalClient->setValueSync(*propToSet);
ASSERT_FALSE(setValueResult.ok()) << "Expect set on VehicleProperty::INVALID to fail";
ASSERT_EQ(setValueResult.error().code(), ErrorCode::INVALID_ARG);
auto result = mVhalClient->getAllPropConfigs();
ASSERT_TRUE(result.ok());
for (const auto& cfgPtr : result.value()) {
const IHalPropConfig& cfg = *cfgPtr;
ASSERT_FALSE(cfg.getPropId() == propId) << "Expect VehicleProperty::INVALID to not be "
"included in propConfigs";
}
}
// Test subscribe() and unsubscribe().
TEST_P(VtsHalAutomotiveVehicleTargetTest, subscribeAndUnsubscribe) {
ALOGD("VtsHalAutomotiveVehicleTargetTest::subscribeAndUnsubscribe");