Commit Graph

149 Commits

Author SHA1 Message Date
Leon Scroggins III
63c8fea778 VTS: Add flag dependency so librenderengine can be used
I6c436b6b80b27930d82aabf22107216172773b56 adds a dependency for
librenderengine on flags. Add that dependency so we can use
librenderengine here, too.

Bug: 305445199

Test: atest VtsHalGraphicsComposerV2_2TargetTest
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: If339ac94a6eff4af34e60cf1c1135289b8915441
2024-02-05 12:51:01 -05:00
Aditya Choudhary
39ed8dc1ad [DON'T BLOCK] Test ownership migration rules am: c5c6c62995 am: 85d604d0db
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2939799

Change-Id: I68af10e082403fcfdbd89e7d63bb07f207bc06e2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-31 17:46:24 +00:00
Aditya Choudhary
85d604d0db [DON'T BLOCK] Test ownership migration rules am: c5c6c62995
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2939799

Change-Id: I1046113ffdcd09649fa65e023aae0969262772e0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-31 17:06:10 +00:00
Aditya Choudhary
c5c6c62995 [DON'T BLOCK] Test ownership migration rules
This CL is created as a best effort to migrate test targets
to the new android ownership model. If you find incorrect or unnecessary
attribution in this CL, please create a separate CL to fix that.

For more details please refer to the link below,
<add g3 doc link>

Bug: 304529413
Test: N/A
Change-Id: I3322344f595f974f730dc824af0110388076d838
2024-01-31 11:06:17 +00:00
Wiwit Rifa'i
c67c887c5a composer: vts: update getClientTargetSupport tests
Ensure the primary display to set power on before running
getClientTargetSupport tests for VTS 2.1 - 2.3.

Bug: 308252481
Test: atest VtsHalGraphicsComposerV2_1TargetTest
Test: atest VtsHalGraphicsComposerV2_2TargetTest
Test: atest VtsHalGraphicsComposerV2_3TargetTest
Change-Id: I6b793537ee42c87f37c4c1d7141364541f448134
2024-01-05 16:29:12 +08:00
Alec Mouri
75a546270a Remove useFramebufferCache parameter in drawLayers()
GLESRenderEngine used it, but GLESRenderEngine is no more.

Bug: 199918329
Test: builds
Change-Id: I9c735e5820bd187f910905e7e77f9445f0ff30db
2023-08-18 15:01:52 +00:00
Alec Mouri
32a41abac3 Remove color management configuration in VTS
Color management is now turned on by default, so there's no reason to
explicitly enable it in renderengine.

Bug: 295966830
Test: builds
Change-Id: I42c8afb30950081cd57072680da06895dcc02f2c
2023-08-15 02:11:49 +00:00
John Reck
631dc15b2e Remove allocator from composer2.1-4 VTS
Bug: 292584923
Test: make VtsHalGraphicsComposerV2_3TargetTest VtsHalGraphicsComposerV2_4TargetTest VtsHalGraphicsComposerV2_2TargetTest VtsHalGraphicsComposerV2_1TargetTest
Change-Id: I6c5e8c8b96450f800bb60b6ed0ce3b3c10ce1565
2023-07-26 16:06:34 -04:00
John Reck
6d0abbb439 Remove mapper from composer2.1 VTS
Bug: 292584923
Test: make VtsHalGraphicsComposerV2_3TargetTest VtsHalGraphicsComposerV2_4TargetTest VtsHalGraphicsComposerV2_2TargetTest VtsHalGraphicsComposerV2_1TargetTest
Change-Id: I3642995e7236a3b9b08ad5419c9d02b67243b24a
2023-07-26 15:54:47 -04:00
John Reck
82c666bd8c Remove mapper from composer2.2 VTS
Test: make VtsHalGraphicsComposerV2_2TargetTest
Bug: 292584923
Change-Id: Id281c732535ace4a36750d759b59db7aa6e5cb3a
2023-07-26 10:17:17 -04:00
Brian Lindahl
e887a25203 Revert "Add VTS readback tests for buffer slot clearing"
This reverts commit d103cd6828.

NOTE: This is not a full revert, it leaves the production code in place and only reverts the VTS test changes.

Reason for revert: b/262370410

Test: atest VtsHalGraphicsComposerV2_1TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_2TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_3TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_4TargetTest on Oriole
Bug: 262370410
Change-Id: I336beb9f0ed81b305b26c6d8e9da70cfabe04bbd
2023-01-18 21:18:21 +00:00
Nolan Scobie
8ef31a2afb Merge "Add librenderengine_deps to targets depending on librenderengine" 2022-12-14 16:21:13 +00:00
Brian Lindahl
d103cd6828 Add VTS readback tests for buffer slot clearing
Bug: 258196272
Test: atest VtsHalGraphicsComposer3_ReadbackTest
Test: atest VtsHalGraphicsComposerV2_2TargetTest
Change-Id: I95d24f9cf10d95e54bc228c02bedab9a8281cfd1
2022-12-09 14:31:39 -07:00
Nolan Scobie
a61ca2a872 Add librenderengine_deps to targets depending on librenderengine
See I46750a0336a29d8d32ad2cb79a71c90461272fce for context.

Bug: 259248961
Test: presubmit builds
Change-Id: Ibd8b75406bd79dab6bc20aeaad0d08c9fcdfeb41
2022-12-07 11:48:27 -05:00
Treehugger Robot
344f7933ed Merge "Update OWNERS" am: 0ea6e013ef am: 91b8d6b035 am: 27ae2a7bef
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2282841

Change-Id: I99f6ab3a12e225cacbbaeffc9d28cd5b9451d3f8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-02 20:40:19 +00:00
John Reck
15703c76af Update OWNERS
Remove all subfolder OWNERS in favor of single top-level
Update top-level OWNERS

Fixes: 230785548
Test: n/a

Change-Id: I9e4f4fa7938e31f0caf864836889f8ebb5ca5675
2022-11-02 12:36:41 -04:00
Sally Qi
a1c66a2993 Add cc_defaults wrapper for android.hardware.graphics.allocator ndk
package.

- to avoid manually rev up if needed.

Bug: 243429120
Test: builds
Change-Id: I25bfcc203cda61af308c37c3766fa9efe6c6784c
Merged-In: I25bfcc203cda61af308c37c3766fa9efe6c6784c
2022-10-20 18:27:12 -04:00
Sally Qi
0435c6b4f3 Add cc_defaults wrapper for android.hardware.graphics.allocator ndk
package.

- to avoid manually rev up if needed.

Bug: 243429120
Test: builds
Change-Id: I25bfcc203cda61af308c37c3766fa9efe6c6784c
2022-09-01 13:28:00 -07:00
Sally Qi
784c253a05 Add cc_defaults as wrapper for graphics composer/common AIDL
interfaces.

- Add new Android.bp in graphics folder and wrap composer and common
  AIDL in to separate cc_defaults.
- remove composer3 dependency from allocator's VTS .bp file.

Bug: 243429120
Test: builds
Change-Id: Ia91e4ab87b7ac86248094317185b317d5604e654
2022-08-26 15:18:42 -07:00
Patrick Williams
af78e0ad80 Replace RenderEngineResult with FenceResult
Bug: b/232535621
Test: refactor, existing tests pass

Change-Id: I86fe498246e45d199a47008a3fb90af3030e83d6
2022-08-24 20:00:40 +00:00
ramindani
b2b747ffd4 [VTS] Update allocator name for AIDL allocator.
We used "default" value for the allocator in the test
and this value was used as is for the AIDL allocator.
This caused the test to fail because we were not able to acquire the
appropriate allocator as AIDL allocator instance is not named "default".
Update the test to use the correct instance name for AIDL allocator,
if available.

Test: atest VtsHalGraphicsComposerV2_1TargetTest
atest VtsHalGraphicsComposerV2_2TargetTest
atest VtsHalGraphicsComposerV2_3TargetTest
atest VtsHalGraphicsComposerV2_4TargetTest
atest VtsHalGraphicsComposer3_TargetTest
BUG: 234671596

test results after updates:
VTS 2.1 : http://ab/I84600010058657636
VTS 2.2 : http://ab/I51800010058498973
VTS 2.3 : http://ab/I87700010058914863
VTS 2.4 : http://ab/I88900010058592031
VTS 3.0 : http://ab/I96200010058838905

Change-Id: I04ae1a18d757cfd941d4929ad08f6bb2c8643f76
2022-06-07 23:33:12 +00:00
Alec Mouri
38ccfd7a29 Tweak IMapper 4.0 VTS to run with AIDL IAllocator
When there is no HIDL IAllocator installed on the device, then these
tests must still run.

Bug: 231982605
Test: VtsHalGraphicsMapperV4_0TargetTest
Change-Id: If7503d398c03086df470971cc2c10029270525f9
2022-05-23 18:38:37 +00:00
Alec Mouri
55f76ca7af Update renderengine dependency to VTS
Bug: 218954037
Test: builds
Change-Id: I31f8a8764fa66a9aec4762354c425ba1442ef351
Merged-In: I31f8a8764fa66a9aec4762354c425ba1442ef351
2022-03-31 01:16:14 +00:00
Chih-hung Hsieh
34593d4e2a Merge "Add timed out test files to tidy_timeout_srcs" am: ff54f73b4f am: fa83970b3a am: 581616e658
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1992232

Change-Id: I2eac13fe3b5ab0b4f15d6ceadf376e5e74124a81
2022-02-24 01:32:09 +00:00
Chih-Hung Hsieh
ad1bf31b78 Add timed out test files to tidy_timeout_srcs
* Timed out runs do not show any warning messages.
* These test files cannot finish clang-tidy runs with
  the following settings:
    TIDY_TIMEOUT=90
    WITH_TIDY=1
    CLANG_ANALYZER_CHECKS=1
* When TIDY_TIMEOUT is set, in Android continuous builds,
  tidy_timeout_srcs files will not be compiled by clang-tidy.
  When developers build locally without TIDY_TIMEOUT,
  tidy_timeout_srcs files will be compiled.
* Some of these test modules may be split into smaller ones,
  or disable some time consuming checks, and then
  enable clang-tidy to run within limited time.

Bug: 201099167
Test: make droid tidy-hardware-interfaces_subset
Change-Id: I1de28f1572fff368f67eab512fffec9f2e5c2a9b
2022-02-18 17:25:41 -08:00
Treehugger Robot
fa31414317 Merge "Add alecmouri to composer OWNERS" am: d89d96d196 am: b766496521 am: 8f8f639518 am: a44e520716
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1949687

Change-Id: Ia2074f2f0d8cdbc8546b9eda7e3ab1759ed2d578
2022-01-14 22:37:21 +00:00
Ady Abraham
7b957abe49 Add alecmouri to composer OWNERS
Change-Id: I01a0958e1371ba0e6a92d7f5f0d19ce0acdb7604
2022-01-14 17:10:25 +00:00
Vishnu Nair
59329712a9 Update VTS to use ExternalTexture impl
We want to expose GraphicBuffer properties via
ExternalTexture class and within, SurfaceFlinger access the
buffer via this proxy interface. This allows us to inject
and mock GraphicBuffers as needed. Specifically this will
be used to recreate layer state from transaction traces.

Test: compiles
Bug: 200284593

Change-Id: If2b6c43bb5b302fbc49dfa49d6ac1f79f92f30f7
2022-01-14 02:06:17 +00:00
Alec Mouri
ece0bc399c Link in libshaders into composer VTS
Bug: 200309590
Test: builds
Change-Id: I71df8b0ea3b5df2ba09861bb3cd11645595f09bc
2021-11-24 12:23:48 -08:00
Long Ling
abc390baae Merge "Fix comile error for pixel aidl hwc" 2021-11-12 04:39:26 +00:00
Alec Mouri
256264dc1f Link in libtonemap into composer VTS
Bug: 200310159
Test: builds
Change-Id: I9183cf2bcb11a837ab2f27d9210f3c30f02d093a
2021-10-29 14:39:00 -07:00
Treehugger Robot
af0806e4f5 Merge "Update OWNERS for VtsHalGraphicsComposer tests." am: cb0667c916 am: 83f6228bdf am: 2b799702ab am: d2eeeaabc2 am: 9d68d6be49
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1861820

Change-Id: Ica8fcb124b173ee79805d2d84352d6f1fea95880
2021-10-20 20:59:29 +00:00
Yiming Pan
cd9afdf0af Update OWNERS for VtsHalGraphicsComposer tests.
Test: Tree Hugger
Bug: 143903671
Change-Id: I228402a350ecccac92dea7c5facde60496ba3e6e
2021-10-18 17:28:00 -07:00
Long Ling
2997151fae Fix comile error for pixel aidl hwc
Bug: 201321174
Change-Id: Ib64dce591232e62985f72dffff22792fe908407a
2021-10-13 15:54:47 -07:00
Sally Qi
d515dbade2 Revert "Revert "Fix vts cases due to function change for async r..."
Revert^2 "Second Patch for async RenderEngine"

2109270e74a18585aceffc94d1758cee47bb4175

Bug: 202843200
Bug: 202833127
Bug: 202808760
Test: this
Change-Id: I504d2974d97e78431dc5d7e572e8ae70690dc34c
2021-10-13 11:15:13 -07:00
Sally Qi
a56868b854 Fix Vts drawLayers function for async renderengine change
Bug: 180657548
Test: this
Change-Id: I8980d843599fe8b8195f6a1b8540b5d13528ac4b
2021-08-17 17:13:26 -07:00
Sally Qi
a5d54ffeaa Merge "Fix vts gfx readback test issue because clearRegion was removed in I11f369d26e080ba49c7108957f8cf44c85146021." 2021-07-12 22:31:04 +00:00
Alec Mouri
06b9fb5e28 Merge "Clear composition changes when a color mode is not supported" into sc-dev am: f569528b19 am: 8ae996d084
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/15244526

Change-Id: If3d38454cef2f87fca51b03ece36a1231aff8747
2021-07-09 21:39:13 +00:00
Alec Mouri
981a3c1a66 Merge "Clear composition changes when a color mode is not supported" into sc-dev am: f569528b19
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/15244526

Change-Id: Ia3186d6d30fcaab371cee4adba50108a61fff515
2021-07-09 21:29:39 +00:00
Alec Mouri
b1bd1e8a32 Clear composition changes when a color mode is not supported
Otherwise this may cause a test to spuriously fail during teardown.

Bug: 184726169
Test: VtsHalGraphicsComposerV2_2TargetTest
Change-Id: I569680a0fe6c866199ba0711e8cc263b9b3efd58
2021-07-09 11:15:18 -07:00
Sally Qi
ab4bc8d0d0 Fix vts gfx readback test issue because clearRegion was removed in
I11f369d26e080ba49c7108957f8cf44c85146021.

Bug: 181073175
Test: VtsHalGraphicsComposerV2_2TargetTest passed
Change-Id: Ic50b968f2d2334a016d0e83a66e43e89e6d2ad80
2021-07-09 00:18:56 +00:00
Treehugger Robot
555c368ddb Merge "Replace writepid with task_profiles command for cgroup migration" am: a43f14bdac am: 7151796908
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1740279

Change-Id: I8c9ebb5de59a2b8a87c8045cfc8c64b71eac0f10
2021-06-23 23:09:57 +00:00
Suren Baghdasaryan
dd50b2f45d Replace writepid with task_profiles command for cgroup migration
writepid command usage to join a cgroup has been deprecated in favor
of a more flexible approach using task_profiles. This way cgroup path
is not hardcoded and cgroup changes can be easily made. Replace
writepid with task_profiles command to migrate between cgroups.

Bug: 191283136
Test: build and boot
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
Change-Id: I249ecc45a001a69d73b06b77154f9b6e5f9964d9
2021-06-23 18:43:27 +00:00
Marin Shalamanov
513ae73a91 VTS: Free allocated buffers
The native handle was not freed which causes some devices to
run out of memory when executing the test. This change
creates a RAII wrapper around native_handle_t, which
automatically deallocates buffers when they go out of scope.

Bug: 188686850
Test: atest VtsHalGraphicsComposerV2_4TargetTest
Change-Id: I19a22a5a3202e048de77926ce4a116a31d9de906
2021-06-16 12:46:56 +02:00
Alec Mouri
2a6ef4e566 Revert "Revert "Update Readback VTS to align with RenderEngine i..."
Revert "Revert "Update WaylandRenderSurface to accomodate interf..."

Revert "Revert "Add ExternalTexture class into RenderEngine inte..."

Revert submission 14199598-revert-14086921-renderengine-external-tex-QJNBWQMQEU

Reason for revert: Prepare for relanding
Reverted Changes:
I01e65a7f4:Revert "Update WaylandRenderSurface to accomodate ...
I7d58118c1:Revert "Update Readback VTS to align with RenderEn...
I1501890f4:Revert "Add ExternalTexture class into RenderEngin...

Change-Id: Ic2ee9311d22658ac77c8a94f6070324cf07b601b
2021-04-16 16:36:21 +00:00
Alec Mouri
51daee615f Revert "Update Readback VTS to align with RenderEngine interface..."
Revert "Update WaylandRenderSurface to accomodate interface change"

Revert "Add ExternalTexture class into RenderEngine interface"

Revert submission 14086921-renderengine-external-tex

Reason for revert: Potential culprit for b/185361988
Reverted Changes:
I7796764e2:Update WaylandRenderSurface to accomodate interfac...
I13904eec4:Update Readback VTS to align with RenderEngine int...
I222c71e6e:Add ExternalTexture class into RenderEngine interf...

Change-Id: I7d58118c1c2284a04eb52e992e901d82faaf5bb0
2021-04-15 16:27:01 +00:00
Alec Mouri
bdd7e7e511 Update Readback VTS to align with RenderEngine interface change
RenderEngine no longer directly takes in GraphicBuffer objects. Instead,
it takes in ExternalTexture types that manage resources associated with
a GraphicBuffer.

Bug: 180767535
Test: builds
Change-Id: I13904eec491fce223b6178fa5571589b67402865
2021-04-13 11:01:50 -07:00
Ady Abraham
203bdee456 Vts: Add missing usage to buffer
The test's buffer is read by the GPU and therefore needs to be allocatted with
BufferUsage::GPU_TEXTURE

Fixes: 182935868
Change-Id: I7795e6a32acdf3ecf76003bd12715fcaf73a4e71
Test: VtsHalGraphicsComposerV2_2TargetTest
2021-03-17 03:32:59 +00:00
Alec Mouri
43db707407 Add render target bit to output buffer for readback vts
RenderEngine requires the gpu target bit on its output buffers, since
it is a GPU implementation which...uses the GPU.

Bug: 180650640
Test: atest VtsHalGraphicsComposerV2_2TargetTest
Change-Id: Ie99af44dc1b8804026b889f8342362839a43c945
2021-02-24 23:40:21 +00:00
Bob Badour
564733607c resolve merge conflicts of 5c715dd65b to sc-dev
Change-Id: Ie3809f388a44d735303118366331679aa63a5944
2021-02-22 15:58:32 +00:00