Commit Graph

7823 Commits

Author SHA1 Message Date
android-build-prod (mdb)
d3b6ea09c1 Merge changes from topic "lazy-dumpstate"
am: 5c2a8265c6

Change-Id: I81b8c547d174a4becfb99ed0cb4e9fe53be1ac15
2018-05-07 13:00:09 -07:00
android-build-prod (mdb)
5c2a8265c6 Merge changes from topic "lazy-dumpstate"
* changes:
  Make dumpstate HAL lazy.
  dumpstate: add interface into rc file
2018-05-07 18:07:21 +00:00
Steven Moreland
521d15c537 Make dumpstate HAL lazy.
Bug: 78509314
Test: HAL isn't running
Test: adb bugreport HAL runs
Test: HAL isn't running after bugreport finishes
Test: manually inspect state using `lshal` and logs
    using `adb logcat | grep android.hardware.dump`

(cherry picked from commit 711b806727c85d91cf805db4f78b4a9609e2bf43)

Change-Id: Ic97516a4297e7933430fb4fa3fd0109f8c1b1d0a
2018-05-07 09:35:11 -07:00
Wei Wang
af3006428d dumpstate: add interface into rc file
Bug: 7748994
Test: Build
Change-Id: I5e86b0e63928f42ea7b247bd0de0719daf80a10d
Merged-In: I5e86b0e63928f42ea7b247bd0de0719daf80a10d
2018-05-07 09:27:02 -07:00
Steven Moreland
240aa37762 rename BUILT_SYSTEM_{COMPATIBILITY_,}MATRIX
am: 515324a7a4

Change-Id: I1843daf9f99c510ae64238b40452c91e0454b376
2018-05-02 18:24:48 -07:00
Steven Moreland
e03003b4de Remove early checks on manifest.
am: a5cca55a1f

Change-Id: If1fb3ae17dbb2d0d71f472536c7a5ad049c37561
2018-05-02 18:24:44 -07:00
Steven Moreland
515324a7a4 rename BUILT_SYSTEM_{COMPATIBILITY_,}MATRIX
For consistency with BUILT_VENDOR_MATRIX.

Bug: 66917623
Test: manual
Change-Id: I666eceeb9fc20e5f5754f605c2fbb6530e51b326
2018-05-01 18:36:30 -07:00
Steven Moreland
a5cca55a1f Remove early checks on manifest.
These are to be checked in verify_vintf_matrices at
the end of the build when all of the manifest fragments
are available.

Bug: 66917623
Test: check that verify_vintf_matrices hits these checks
Change-Id: I3f184a05a6a95751384da077257dddcf73d3a6f2
2018-05-01 18:36:30 -07:00
Yifan Hong
1ccbbf3eaa Restore kernel requirements for frozen matrices.
am: a6a1e0b2d2

Change-Id: I96403d04d14c9fcefee88e7ca385ff18b29ec646
2018-05-01 11:50:07 -07:00
Yifan Hong
2e74d17942 Add 4.14.0 kernel to all matrices.
am: d8a4d3463e

Change-Id: Ib0db9f0d53fe45dbb46779652076fbddeda586e8
2018-05-01 11:50:01 -07:00
Yifan Hong
a6a1e0b2d2 Restore kernel requirements for frozen matrices.
Requirements for legacy/1/2.xml has changed because
android-base.cfg files are changed. These files should
build from an older snapshot of the requirements.

Fixes: 78576469
Test: builds
Test: vts_treble_vintf_test

Change-Id: I908ebbe495ae06f983ef983a1be7937cf6be1c12
Merged-In: I908ebbe495ae06f983ef983a1be7937cf6be1c12
2018-04-30 17:27:46 -07:00
Yifan Hong
d8a4d3463e Add 4.14.0 kernel to all matrices.
P framework can work with 4.14 kernel. 0 should
be updated to the correct value in a follow-up
patch.

This creates the following tags in all matrices:
Kernel 4.14 common requirements
Kernel 4.14 requirements on CONFIG_ARM is set
Kernel 4.14 requirements on CONFIG_ARM64 is set

Bug: 72409164
Bug: 77886167
Test: manually inspect built matrix
Change-Id: I82168df314ad61b21440ec5c703db8358468e083
Merged-In: I82168df314ad61b21440ec5c703db8358468e083
2018-04-30 16:33:56 -07:00
android-build-prod (mdb)
28172ae62a Merge "HWC2On1Adapter: Fix fd leak in Layer::dump"
am: 2e38b2c0f6

Change-Id: I347beecd5bf383426e7637c13bb59a2b2e5a9dd0
2018-04-27 11:36:19 -07:00
android-build-prod (mdb)
2e38b2c0f6 Merge "HWC2On1Adapter: Fix fd leak in Layer::dump" 2018-04-27 18:27:53 +00:00
android-build-prod (mdb)
030935b4a0 Merge "Replace hidl_enum_{iterator -> range}."
am: 71d7d91ba8

Change-Id: Ib3e22173fa4a81915d8296082d438345504c5dde
2018-04-27 11:17:47 -07:00
android-build-prod (mdb)
71d7d91ba8 Merge "Replace hidl_enum_{iterator -> range}." 2018-04-27 18:08:06 +00:00
Dan Stoza
9f20633e6c HWC2On1Adapter: Fix fd leak in Layer::dump
Removes the fence dump from Layer::dump, since:
  a) It was leaking (a dup() without a close())
  b) It's not that useful anyway since it wasn't displaying the actual
     fence fd

Test: Manual
Bug: 73979009
Change-Id: I8f7446a05a1bab8c3ca781610ebeb98d17fa483b
2018-04-26 12:52:35 -07:00
Dan Stoza
aa8814d2ef Merge "graphics: add libhwc2on{1,fb}adapter"
am: 86b9e6d4b6

Change-Id: I6a4d9b4e79d2baa9a8de11072ac088c4b20a091a
2018-04-26 11:35:53 -07:00
Dan Stoza
86b9e6d4b6 Merge "graphics: add libhwc2on{1,fb}adapter" 2018-04-26 18:26:31 +00:00
Steven Moreland
303afec451 Replace hidl_enum_{iterator -> range}.
This class is technically an iterable object, not a range.

Bug: 78573628
Test: N/A
Change-Id: Ibe307cb2e55e030ecd48e7cab09e5863f6a5e2f7
2018-04-25 12:49:05 -07:00
Kevin Rocard
df22381a0c Merge "Audio: setParam improve status_t to Result consistency"
am: 74e1cbb094

Change-Id: I10c3f800090ce77e1858abcd932df93d42057a27
2018-04-23 14:51:46 -07:00
Kevin Rocard
74e1cbb094 Merge "Audio: setParam improve status_t to Result consistency" 2018-04-23 21:41:14 +00:00
Jiyong Park
eba42a4d6b Merge "Mark configstore-utils as double_loadable"
am: a7b9291b82

Change-Id: Ieee85a4e7083d9814905ec74a02d5e535db4c93e
2018-04-20 19:25:19 -07:00
Treehugger Robot
a7b9291b82 Merge "Mark configstore-utils as double_loadable" 2018-04-21 02:14:51 +00:00
sqian
5c053fcef7 Sim Status Present VTS
am: 2a60b89b9c

Change-Id: I68bf282f35d8d6c16cc9412e26b2c4c458ac8c83
2018-04-20 17:43:55 -07:00
Kevin Rocard
574cc909d4 Audio: setParam improve status_t to Result consistency
The rest of the API (*::analyseStatus) returns NOT_SUPPORTED
when the legacy API returns -ENOSYS.

setParameter legacy -> treble shim did not follow this
conversion due to the legacy API stating that for get_paramers,
-ENOSYS should be returned if
"the implementation does not accept a parameter change while the
 output is active but the parameter is acceptable otherwise",
aka INVALID_STATE.

Thus setParameter shim used to return
 - OK for OK
 - INVALID_STATE for -ENOSYS
 - INVALID_ARGUMENTS for everything else

This leads to several problems:
 - an implementation of the legacy API can not report NOT_SUPPORTED
 - is inconsistent with the rest of the status_t conversion methods
 - shim methods implemented over getParameter can not distinguish
   failures error required by the .hal documentation

Most importantly, on the system side, the Result is transformed to a
status_t again but without any special logic for methods wrapping
getParameter in the shim.
See: analyzeResult in
     frameworks/av/media/libaudiohal/2.0/ConversionHelperHidl.cpp
This can not be changed as the system can not know which methods
are implemented with a legacy wrapper under the Treble API boundary.

This mean that if:
 - hal return -ENOSYS ()
 - shim converts it to INVALID_STATE
 - libaudiohal converts it to NOT_ENOUGH_DATA ()
Thus the checkForNewParameter_l's "status == INVALID_OPERATION"
test in frameworks/av/services/audioflinger/Threads.cpp
are now always false and broken.
This has been broken since the introduction of the Treble shim for O.

Thus setParam now converts status_t to Result in the same way
as all the other shim methods.

Bug: 72873273
Bug: 69811500
Bug: 69010523
Test: playback and record for media and voice call
Change-Id: I41204c0807d2bd4675e941771cbc9a43d7d14855
Merged-In: I41328afce56ce31d4a26159ca2d4b16d14cce05b
Signed-off-by: Kevin Rocard <krocard@google.com>
2018-04-20 23:30:28 +00:00
sqian
2a60b89b9c Sim Status Present VTS
Fix and enhance sim-present tests,
Save VTS running time,
Fix serial number inconsistancy issue

Fix and enhance sim-present tests:
In 1.0:
- setupDataCall timeout, need more waiting time
- requestIccSimAuthentication returns REQUEST_NOT_SUPPORTED,
need to check it
- sendSms timeout, would need more waiting time
- sendSMSExpectMore timeout, would need more waiting time
- getAllowedCarriers, getting CardState::RESTRICTED, the previous test
of setAllowedCarriers is doing resetting back to no carrier restriction,
but that needs some time to populate.
In 1.1:
- setSimCardPower_1_1 set sim card power down that makes other tests
fail, reset it back with sim card power on.

Save VTS running time,
- Use waiting loop and prevent unnecessary waiting to save the whole
running time.

Fix serial number inconsistancy issue
- During the enforcement running, it is liked the serial number is
not consistent. And it happens in b/78249227. Suspect that when sim
card is inserted, during the testing running time, the radio may
request some response that is not triggered from the test, but the
test may receive it and think it is what is triggered by the test. The
fix is to check serial number before notifying of unlock the test
lock.

Bug: 76125134
Bug: 78248071
Bug: 78139665
Bug: 78249227
Test: run vts -m VtsHalRadioV1_0Target; run vts -m VtsHalRadioV1_1Target
Change-Id: I08fe9d7ac16283c7ce1a5aeb6b3b372786a8d5c3
Merged-In: I08fe9d7ac16283c7ce1a5aeb6b3b372786a8d5c3
(cherry picked from commit 788eb80830)
2018-04-20 14:54:12 -07:00
Phong Tran
689a46fa4b health 2.0: fix typo in README
am: 085c7ef6c3

Change-Id: I7d87262f4b943750dbb2096bfbdfffe1eb6fd9f1
2018-04-19 13:56:16 -07:00
Phong Tran
085c7ef6c3 health 2.0: fix typo in README
Test: none

Change-Id: I6c4a1b08ac49d84a77976a488cad53ce14bb9d91
2018-04-19 22:25:44 +07:00
Michael Butler
ebce657784 Merge changes from topic "nnapi-aosp-sync"
am: 07c5cfcf34

Change-Id: Ic053f5f3f8282f2ee001f82a78c45c7f1e070040
2018-04-18 15:17:40 -07:00
Michael Butler
f2c0b234a7 Sync NNAPI Operand and Operation documentation fixes
am: 1e9f62d4f2

Change-Id: Id649171faed87257300b73d7b3bfb51aaa484b9e
2018-04-18 15:15:09 -07:00
Miao Wang
6e219026f7 Fix the spec for TENSOR_QUANT8_ASYMM to match our validation.
am: e12088cd64

Change-Id: Iefb673239e00e99f0e671b0311aba62c0d16930b
2018-04-18 15:14:54 -07:00
Miao Wang
763387beea Fix the NNAPI HAL documentation about ADD and MUL
am: 9237ae8889

Change-Id: I82477495696172b456305ac7dc739d93cdcd9e2e
2018-04-18 15:14:35 -07:00
Michael Butler
cb61c34dff NN validation tests
am: 7ed6135471

Change-Id: Ibefb02e19031ad887fc9cd51a182879ca9564aa2
2018-04-18 15:14:11 -07:00
David Gross
f03f1eaf2f Add validation tests for consistency of model inputs and outputs.
am: fa89f009f9

Change-Id: If7e5bc4c303ec1f7fbdac39306f6302c009f2ad2
2018-04-18 15:13:37 -07:00
Pirama Arumuga Nainar
4a75828cc7 Disable arm32 asan for VtsHalNeuralnetworksV1_1TargetTest
am: 0d8dbeecd6

Change-Id: I1c6c362c5f43cc643c68cdd4620b2626ec90887c
2018-04-18 15:12:57 -07:00
Michael Butler
07c5cfcf34 Merge changes from topic "nnapi-aosp-sync"
* changes:
  NNAPI: Add execution preference to prepareModel (HAL)
  Sync NNAPI Operand and Operation documentation fixes
  Fix the spec for TENSOR_QUANT8_ASYMM to match our validation.
  Fix the NNAPI HAL documentation about ADD and MUL
  NN validation tests
  Add validation tests for consistency of model inputs and outputs.
  Disable arm32 asan for VtsHalNeuralnetworksV1_1TargetTest
2018-04-18 22:00:10 +00:00
Michael Butler
f02692d840 NNAPI: Add execution preference to prepareModel (HAL)
A model can be prepared in different ways to optimize for different
use-cases. This CL propagates the execution preference across the HAL so
that the NN service can better fit the users needs.

Bug: 77864669
Test: mma
Test: NeuralNetworksTest_static
Test: VtsHalNeuralnetworksV1_1TargetTest
Merged-In: Ib928d510d462f36b6a87d5e81010513db7829fa8
Change-Id: Ib928d510d462f36b6a87d5e81010513db7829fa8
(cherry picked from commit 2504c2fe4f)
2018-04-18 19:08:24 +00:00
Michael Butler
1e9f62d4f2 Sync NNAPI Operand and Operation documentation fixes
This CL adds the typo fixes, bug fixes, and missing descriptions added
to the NNAPI but not to the NN HAL. This CL also adds description of
implicit padding, which was present but not documented in 1.0.

Bug: 77541934
Bug: 75459529
Test: mma
Merged-In: I7baa9e515057c43e759849284b3bb0d420a71f1b
Change-Id: I7baa9e515057c43e759849284b3bb0d420a71f1b
(cherry picked from commit 25f3ad328b)
2018-04-18 19:08:17 +00:00
Miao Wang
e12088cd64 Fix the spec for TENSOR_QUANT8_ASYMM to match our validation.
- Scale of 0.0 is invalid for quantized tensor.

Bug: 77236592
Test: mma
Merged-In: I3a53d6303d8c964d451e17a3b1671de82d0ff335
Change-Id: I3a53d6303d8c964d451e17a3b1671de82d0ff335
(cherry picked from commit a82d39102a)
2018-04-18 19:08:11 +00:00
Miao Wang
9237ae8889 Fix the NNAPI HAL documentation about ADD and MUL
- ADD and MUL supports QUANT8_ASYMM since OMR1. It was a bug missing
  them in the HAL documentation.
  - Added the updated hash to current.txt for this ABI preserving
  change.

Bug: 75459529
Test: mm
Merged-In: I492a7431c0dbb3dc5967c586d080eb134e380bf2
Change-Id: I492a7431c0dbb3dc5967c586d080eb134e380bf2
(cherry picked from commit f62984027c)
2018-04-18 19:07:59 +00:00
Michael Butler
7ed6135471 NN validation tests
This CL adds validation tests for all of the existing generated models.
The strategy of this CL is this: given a valid model or request, make a
single change to invalidate the model or request, then verify that the
vendor service driver catches the inconsistency and returns
INVALID_ARGUMENT.

Bug: 67828197
Test: mma
Test: VtsHalNeuralnetworksV1_0TargetTest
Test: VtsHalNeuralnetworksV1_1TargetTest
Merged-In: I8efcdbdccc77aaf78992e52c1eac5c940fc81a03
Change-Id: I8efcdbdccc77aaf78992e52c1eac5c940fc81a03
(cherry picked from commit f76acd0312)
2018-04-18 19:07:52 +00:00
David Gross
fa89f009f9 Add validation tests for consistency of model inputs and outputs.
Test: VtsHalNeuralnetworksV1_1TargetTest --hal_service_instance=android.hardware.neuralnetworks@1.1::IDevice/sample-all --gtest_filter=Flavor/NeuralnetworksInputsOutputsTest.*
Test: VtsHalNeuralnetworksV1_1TargetTest --hal_service_instance=android.hardware.neuralnetworks@1.1::IDevice/sample-float-fast --gtest_filter=Flavor/NeuralnetworksInputsOutputsTest.*
Test: VtsHalNeuralnetworksV1_1TargetTest --hal_service_instance=android.hardware.neuralnetworks@1.1::IDevice/sample-quant --gtest_filter=Flavor/NeuralnetworksInputsOutputsTest.*

Bug: 67828197
Merged-In: I245227dce095b9cbbb9b527ad99aa71d11f77c4f
Change-Id: I245227dce095b9cbbb9b527ad99aa71d11f77c4f
(cherry picked from commit 7a76d8a7a8)
2018-04-18 19:07:45 +00:00
Jiyong Park
0d257d5f7e Mark configstore-utils as double_loadable
configstore-utils is explicitly marked as double_loadable since it is one of the
(indirect) dependencies of the LLNDK library libvulkan
and at the same time the lib itself is marked as VNDK. Such lib can be
double loaded inside a vendor process.

Note: even without this change, the library is already capable of being
double loaded due to the dependency graph around it. This change is to
make it explicit so that double loading of a library is carefully
tracked and signed-off by the owner of the lib.

Bug: 77155589
Test: m -j
Merged-In: Ibece0476b819e3387836305ee3b1c9dbf614920b
Change-Id: Ibece0476b819e3387836305ee3b1c9dbf614920b
(cherry picked from commit 9fb3c20bc6)
2018-04-18 11:46:52 +09:00
Pirama Arumuga Nainar
0d8dbeecd6 Disable arm32 asan for VtsHalNeuralnetworksV1_1TargetTest
Bug: http://b/74200014

Building this module with asan triggers an internal error in gold.

Test: mma SANITIZE_TARGET=address in
hardware/interfaces/neuralnetworks/1.1/vts/functional

Merged-In: I3ce5352a6c86c8dca257d35af06989e57f871749
Change-Id: I3ce5352a6c86c8dca257d35af06989e57f871749
(cherry picked from commit cca38c56f4)
2018-04-17 22:30:07 +00:00
sqian
ddb774872e Radio Sap 1.2 default implementation
am: 031a6a87c9

Change-Id: I047fcf2da264f4aec0f4657c88da5890018361af
2018-04-16 16:22:25 -07:00
sqian
031a6a87c9 Radio Sap 1.2 default implementation
Checked points:
- service is on
- vts can run on it
- provided a dummy implementation that a VTS test can pass it
- applied with recent update in radio 1.2 hal
- format repaired
- pass on a 1.0 VTS test, a 1.1 VTS test, and a 1.2 VTS test

Bug: 74114758
Test: run vts

Change-Id: I8a052e3cedb41db9028552ab88f1e26492718497
Merged-In: I8a052e3cedb41db9028552ab88f1e26492718497
(cherry picked from commit 0de4d31569)
2018-04-16 12:01:50 -07:00
Jiyong Park
0c9ca37cc7 android.hardware.graphics.allocator@2.0 is no longer VNDK-SP
The interface lib has been in VNDK-SP because
android.hardware.graphics.mapper@1.0 was using it. However, since the
dependency has gone [1], there is no need keep it in VNDK-SP. The
VNDK-SP set should be kept as small as possible because libs in VNDK-SP
are subject to double-loading.

Unmark the 'support_system_process' property to exclude the lib from
VNDK-SP.

This commit re-lands I8722c1ac15ddf56a627a12a0c649b4d734e5e5cd because
it was reverted during O-MR1 push to AOSP-master.

Bug: 69480083
Test: walleye boots to the UI
Change-Id: I0af8115dceb9711c6c451ffaeedda6c823ec2905
Merged-In: I8722c1ac15ddf56a627a12a0c649b4d734e5e5cd
(cherry picked from commit e514a4b8a8)
2018-04-13 09:17:46 +00:00
sqian
7c85c8642d Fix Radio response/indication 1.2
am: 7f3b78408c

Change-Id: I207769dac9cee28e63d6e08fd9bab6534284ba57
2018-04-12 19:53:15 -07:00
sqian
7f3b78408c Fix Radio response/indication 1.2
Radio VTS client 1.2 radio response cannot be cast from radio response
in the service. To fix it, the client radio response and indication
should extend 1.2 IRadioResponse and IRadioIndication

Bug: 77815815
Test: ran it on the default service
Change-Id: Ib014af98d52d9f208d2139f4a239e9d61ea4d569
Merged-In: Ib014af98d52d9f208d2139f4a239e9d61ea4d569
(cherry picked from commit 79bafb943b)
2018-04-12 18:15:36 -07:00