Commit Graph

1511 Commits

Author SHA1 Message Date
Eino-Ville Talvala
8eeb520795 Unfreeze graphics.common HAL and add YCBCR_P210 format
YCBCR_P210 is a 10-bit 4:2:2 YCbCr color format

Test: Builds, camera/media/graphics CTS continues to pass
Flag: EXEMPT HAL interface change
Bug: 368395888
Change-Id: I6609870be75675dd08c2203d4b5be49ebd1de447
2024-10-16 17:39:45 -07:00
Eino-Ville Talvala
294b3a1dc3 VtsHalGraphicsMapper test: Use static graphics.hardware.common
To avoid linking issues during graphics.hardware.common updates.

Bug: 368395888
Test: Builds
Flag: EXEMPT build file changes only
Change-Id: I2377d8cb35bdc7a1f8020812bf773f9b15ffc277
2024-10-08 19:26:06 -07:00
Jerome Gaillard
c03b4f8293 Merge "Graphics interface libraries only exist for linux/Android" into main 2024-10-08 18:00:41 +00:00
Jason Macnak
dfcc584150 Merge "Avoid leaking RenderEngine" into main am: ad6288c8bc am: 3f5b11006b
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3289233

Change-Id: I743bf52b5b25109913fab101f9c0990d8dcd3ee9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-10-02 17:31:49 +00:00
Jason Macnak
64f73a4c5f Avoid leaking RenderEngine
... as this might allow an underlying `RenderEngineThreaded` thread
to race against the process shutdown.

Bug: b/361574971
Test: ATP cuttlefish_gfxstream_guest_angle_graphics_vts_tests
Change-Id: Ief71d8931ec3560780a850d8bb8bc727bbff5c52
2024-10-01 15:40:33 -07:00
Treehugger Robot
9f39f1a76b Merge "Convert android.hardware.graphics.composer@2.2-service to soong" into main am: cbca4fe91b am: f47a3b90a0
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3271712

Change-Id: I56f1714d6e87973fcf24c7126af9791b31a098eb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-26 00:02:49 +00:00
Jerome Gaillard
9c50f3b8a7 Graphics interface libraries only exist for linux/Android
cc_defaults in graphics/Android.bp should only add libraries to linux
(which includes Android) targets, as those libraries do not exist on
other platforms (macOS/Windows).
This avoids issues when these defaults are added to libraries that build
for host as well as Android (such as libhwui).

Bug: 368328962
Test: N/A
Change-Id: If19aa1f6b66721b86678a036b7f1f185cb90635b
2024-09-19 18:32:28 +01:00
Bill Yang
ce222a2cbc Convert android.hardware.graphics.composer@2.2-service to soong
The conversion skip the if condition for
TARGET_USES_DISPLAY_RENDER_INTENTS due to the cflag it set is never
being used actually.

Bug: 368204639
Test: m android.hardware.graphics.composer@2.2-service
Change-Id: I7347fa5cef192385f94954f620bebee6a24ebb82
2024-09-19 06:37:15 +00:00
Treehugger Robot
636cba8773 Merge "Do not force verbose logs on for anything including ComposerCommandBuffer.h" into main am: 6e5537e1d6 am: 7d7c2f3c09
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3222543

Change-Id: I687471e2a7ee1e34a725323a8f4a73b6715b0c4d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-17 19:35:38 +00:00
Abhishek Gadewar
8aa200ef9c Do not force verbose logs on for anything including ComposerCommandBuffer.h
Summary: It looks like the verbose log debug flag was set during the introduction
of this header and continued to be propagated forward. Since this define
is done in a header, it is forcing verbose logs on for anything which
includes the header.

Test: See less logspam from components including this header

Change-Id: I678ee3384a0a5b13c684a7e14c3358f70a7def30
Signed-off-by: Abhishek Gadewar <abhishekgadewar@meta.com>
2024-09-16 21:10:27 +00:00
Huihong Luo
198c5c6d40 Merge "Add a new api to support HDCP" into main 2024-09-09 15:21:26 +00:00
Sally Qi
8fe9fba573 Merge "[Lut HAL] Move layer out of Lut interface." into main 2024-08-29 16:05:15 +00:00
Sally Qi
6cc484f5e6 [Lut HAL] Move layer out of Lut interface.
- Also add setLayerLuts interface.

Bug: 329472100
Test: builds
Change-Id: I41c36fb5baf77e3a2d111eb32e289b91274eca2a
2024-08-22 14:39:35 -07:00
Alec Mouri
6a000228f7 Support 10-bit VTS readback
Some devices require this for VTS

Bug: 329526845
Test: builds
Test: VtsHalGraphicsComposer3_TargetTest
Change-Id: I94d9611c9ec64be867ade6933a07ae9e97b459a1
2024-08-21 00:37:54 +00:00
Huihong Luo
3a42a8a09d Add a new api to support HDCP
A special HDCP level change callback is reported.

Bug: 293945485
Test: manual
Change-Id: I096554a9e1f69c3dba7c7da58917f2b498ae8726
2024-08-19 21:17:34 +00:00
Sally Qi
420a72f7c3 [Lut HAL] change func name to takeDisplayLut instead.
- also fix some build warnings.

Bug: 329472100
Test: builds
Change-Id: I8b6e25e150c00bdef0606b380bdaeb228cc7ba35
2024-08-14 09:49:40 -07:00
Sally Qi
18e4f4b30c Merge "[Aidl] Add LUT HAL" into main 2024-08-13 18:22:43 +00:00
Sally Qi
ac6824fb33 [Aidl] Add LUT HAL
A Look-Up Table(LUT) provides either the platform or apps ways to
control tonemapping for specific content, more specifically HDR
contents.

LutProperties HAL is also exposed to OverlayProperties API.

Bug: 329472100
Test: builds
Change-Id: Ia25fb21b57c924a9f5a6b4424661a4e152db96f4
2024-08-12 13:42:53 -07:00
Leon Scroggins
15a2c17d43 Merge "Assert the errors size to 1 for case SetDisplayBrightness" into main am: 9e65f0a00d am: 2647200f4c
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3174319

Change-Id: I74c2be26ae1cc26ace79e6a603a7c2bf936410e5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-09 21:01:09 +00:00
Leon Scroggins
2647200f4c Merge "Assert the errors size to 1 for case SetDisplayBrightness" into main am: 9e65f0a00d
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3174319

Change-Id: Id3d13c4a18c46e5170cfc9336ae40ec64cc6998b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-09 20:42:53 +00:00
Vishnu Nair
4bb969334b Add new dependencies for renderengine
Flag: android.os.perfetto_sdk_tracing
Bug: 349905670
Test: perfetto
Change-Id: I213f3ec153f8bbdbbf79e3619e0752bafdfd3f60
2024-07-16 03:41:07 +00:00
Liu, Kai1
6adbf0c117 Assert the errors size to 1 for case SetDisplayBrightness
null pointer dereference crash will be triggered if vector errors
is emptry when accessing errors[0].errorCode, so change EXPECT_EQ
to ASSERT_EQ to avoid this issue.

Test: run vts -m VtsHalGraphicsComposer3_TargetTest

Signed-off-by: Liu, Kai1 <kai1.liu@intel.com>
(cherry picked from https://android-review.googlesource.com/q/commit:aec33e9a41e4bccfd1834e1ab03f785eea4f0b52)
Merged-In: I3b30d491ef886b98e462447e6de78828e7822fca
Change-Id: I3b30d491ef886b98e462447e6de78828e7822fca
2024-07-15 17:00:19 +00:00
Treehugger Robot
b1f024bec3 Merge "Add gralloc tests for locking without CPU usage" into main 2024-07-11 11:39:42 +00:00
Alina Kalyakina
682cfa1332 Add gralloc tests for locking without CPU usage
Add GraphicsMapperHidlTest#LockUnlockNoCPUUsage and
GraphicsMapperStableCTests#LockUnlockNoCPUUsage.
The tests try to lock buffer without CPU usage.

Bug: 346894869
Test: https://android-build.corp.google.com/builds/abtd/run/L15900030005005775, https://android-build.corp.google.com/builds/abtd/run/L64000030005004833
Change-Id: I32a468ff889cf403239e4b10831d6e16e63ae2b9
2024-07-09 14:06:21 +00:00
Cheng Gu
b2b7aa2f48 Make some common libs apex_available am: 974ff63e65
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3155579

Change-Id: If950305c85e8849d1627f1860fbb22b497f7e2af
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-02 21:42:26 +00:00
Cheng Gu
974ff63e65 Make some common libs apex_available
Makes some common libs available to "anyapex".

Bug: 318597144
Bug: 350759487
Test: make
Change-Id: I26d80d1358bf2fccf4cc6f95885d36d19b94d5ff
2024-07-02 20:18:26 +00:00
Kiyoung Kim
416e8efe24 Remove Vndk_use_version property from AIDL am: 7c0d9eb259
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/27589611

Change-Id: I439948e0bcd97d2122b470ed92c01d9019af7c6a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-31 00:35:13 +00:00
Kiyoung Kim
7c0d9eb259 Remove Vndk_use_version property from AIDL
Vndk_use_version property is no longer in use with deprecation of VNDK.
Remove Vndk_use_version property and its usage.

Bug: 328994089
Test: AOSP CF build succeeded
Change-Id: I681cc850341a7dc47416dc81c1da21b687f87b1b
2024-05-30 03:29:10 +00:00
Treehugger Robot
d492a60b30 Merge "Make RenderEngine render to the same format as the readback buffer." into main 2024-05-28 23:43:52 +00:00
Xin Li
64e598ce2b Merge Android 24Q2 Release (ab/11526283) to aosp-main-future
Bug: 337098550
Merged-In: I53a278f1317f5307441103dc42dc5be6f20d7075
Change-Id: I3a53ebf7339cdb886d3c1b733b8eee1847f8832a
2024-05-24 08:28:04 -07:00
Alan Rosenthal
8e84edaa58 ComposerCommandBuffer.h: fix compiler warning
```
warning: format specifies type 'unsigned int' but the argument has type
'IComposerClient::Command' [-Wformat]
```

Change-Id: I9a585330ef1edd7675e6406318bd966b03c8a209
2024-05-21 17:24:22 +00:00
Ying Wei
af54782a2a Improve log message.
Add more information to the failure message: now it looks something like `Failed to get a callback for Display 0 switching from {Config 38: vsyncPeriod 4166666, minFrameIntervalNs 16666667} to {Config 37: vsyncPeriod 8333333, minFrameIntervalNs 8333333}` instead of `failed to get a callback for the display 0 with config 37`

Test: atest VtsHalGraphicsComposer3_TargetTest:PerInstance/GraphicsComposerAidlCommandV2Test#SetRefreshRateChangedCallbackDebugEnabled_SetActiveConfigWithConstraints/0_android_hardware_graphics_composer3_IComposer_default

Bug: 340971724
Change-Id: Id2a1030a9b12e86bda8f6031e79a8374227f4061
2024-05-17 16:31:12 +00:00
Alec Mouri
19e90fa289 Make RenderEngine render to the same format as the readback buffer.
Some device's readback buffers do not support alpha, so rendering golden
images should also not use alpha.

Bug: 335805098
Test: VtsHalGraphicsComposer3_ReadbackTest
Change-Id: I153ea1707b9fd8113529b8c18fa90711acfad04e
2024-05-13 17:09:25 +00:00
Treehugger Robot
f20b08fc66 Merge "Remove unneccessary restriction" into main 2024-05-06 20:04:43 +00:00
John Reck
6b36415306 Remove unneccessary restriction
Fixes: 338432622
Test: n/a doc only change
Change-Id: Icf075be3b258793d3006ced2925ff32d34c90e40
2024-05-02 17:43:06 -04:00
Treehugger Robot
51d6995823 Merge "Explain how to add service_contexts for stable-c mapper" into main am: 1b20111074 am: a05f402812
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3062802

Change-Id: I3f691230c75c723c2e4e343b0d86736245e46e77
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-30 07:16:47 +00:00
Jooyung Han
2dd88e6c8a Explain how to add service_contexts for stable-c mapper
Stable-c mapper instance should be declared in two ways:
- vintf manifest
- service_contexts

The latter part was missing.

Bug: 336010345
Change-Id: I7bd776bf7d943049ef319c90739dae10071409ab
Test: documentation
2024-04-25 18:48:51 +00:00
Manali Bhutiyani
18f658cde4 Merge "DisplayDecoration test: destroy layers per display" into main 2024-04-18 16:37:56 +00:00
Leon Scroggins III
c2a83d449c DisplayDecoration test: destroy layers per display
This appears to have been broken with
Ic3c0415612b1387671ab8efa0ec95ed727f6bf68, which attempts to destroy
layers for all displays using a single writer. The display command that
destroys a layer must be in the writer for that display, in order for
the displays to run independently. Do so in the test itself, rather than
relying on TearDown to destroy all of them.

Bug: 333974982
Test: atest VtsHalGraphicsComposer3_TargetTest
Flag: TEST_ONLY
Change-Id: Ib6807c85bc6cb32c56cc72126a9fa68363365912
2024-04-17 14:49:20 -04:00
Hsin-Yi Chen
e32d58be85 Merge "Move libimapper_stablec ABI dumps from prebuilts/abi-dumps" into main am: cdf6fc5424 am: e835d02eb8
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3043453

Change-Id: I2e361cc7538e4edb8e045df28befeaf7950421ef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-17 08:00:38 +00:00
Hsin-Yi Chen
219876109a Move libimapper_stablec ABI dumps from prebuilts/abi-dumps
The update process for prebuilts/abi-dumps/platform will be adapted for
trunk stable. The ABI dumps for libimapper_stablec are moved to
"abi-dumps" in this project so that the trunk stable release process
will not affect them.

Test: m libimapper_stablec_abicheck
Test: development/vndk/tools/header-checker/utils/create_reference_dumps.py \
      -libs libimapper_stablec_abicheck --lib-variant PLATFORM \
      -ref-dump-dir hardware/interfaces/graphics/mapper/stable-c/abi-dumps \
      -products aosp_arm64
Bug: 333532038
Change-Id: Ia69daa721ef983c18118bd6d0a70dd5b7a0a47a2
2024-04-16 20:21:56 +08:00
Ram Indani
8892a927f4 Merge "[Composer-VTS] Check minFrameIntervalNs to check if rate is changing" into main 2024-04-05 23:00:28 +00:00
Kiyoung Kim
9e9d41d162 Remove VNDK definition(s)
As of VNDK deprecation, any libraries that defines vndk is no longer
valid anymore. This change removes all VNDK definition(s) from modules
which was VNDK.

Bug: 328994089
Test: AOSP CF build succeeded
Change-Id: Ifdade9c052db29c989ce7d804ba725361c4c0f8e
Merged-In: Ic4f19113c1a25dc1fb60cdfbf9c0f2d8d7d09726
2024-04-05 02:29:07 +00:00
ramindani
3ba7334dba [Composer-VTS] Check minFrameIntervalNs to check if rate is changing
With different VRR modes we may have 2 modes with
exactly the same minFrameIntervalNs, and in this case we can't
differentiate between 2 modes.

Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 328350178
Change-Id: I5cddfee8b789ed6ce1b223ec345175f19a0db091
2024-04-04 11:34:40 -07:00
Manali Bhutiyani
f687f7f7b8 [vts] Fix VTS batched-command tests
Fix VTS tests per comments in b/304976052.
Removing redundant tests, as existing CreateLayer, DestroyLayer,
 CreateLayer_BadDisplay and  DestroyLayer_BadDisplay
already provide the needed coverage.

Bug: 304976052
Test: atest VtsHalGraphicsComposer3_TargetTest
      atest PerInstance/GraphicsComposerAidlBatchedCommandTest
Change-Id: I34cb6a69aad6d8f86772a82833b8f15e465fe8d3
2024-04-04 18:20:30 +00:00
Treehugger Robot
22d9bade44 Merge "Fix annotation in doc" into main am: 2116f9c807 am: 2b16275c92
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3002168

Change-Id: Iad540930b35db7995e8d88582a9b64f4ac8ebde0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-20 01:26:43 +00:00
Treehugger Robot
2116f9c807 Merge "Fix annotation in doc" into main 2024-03-20 00:41:09 +00:00
Ady Abraham
530024ea4a composer: vts: add support for batched create/destroy layers
Bug: 315517904
Fixes: 329461909
Test: atest VtsHalGraphicsComposer3_TargetTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:a00d246f2725b22d32b2908230de7620238827ba)
Merged-In: Ic3c0415612b1387671ab8efa0ec95ed727f6bf68
Change-Id: Ic3c0415612b1387671ab8efa0ec95ed727f6bf68
2024-03-19 23:11:56 +00:00
Leon Scroggins
9375782730 Merge "Provide better documentation for CommandErrors" into main 2024-03-15 15:09:35 +00:00
Leon Scroggins III
5e2c3fe166 Provide better documentation for CommandErrors
Some HWC implementations which do not support DISPLAY_DECORATION are
handling DISPLAY_DECORATION layers in VTS by reporting an error (as
required by the test) AND by proposing ChangedCompositionTypes. The
latter is unnecessary, as SF will never read the changed types. Update
the documentation to be more specific that this is unnecessary.

Bug: b/324977561
Bug: b/329119344
Bug: b/329017438
Bug: b/327322951
Bug: b/327090469
Test: GraphicsComposerAidlCommandTest#DisplayDecoration
Change-Id: I09c90e40818dc43b968c3e79e61e8b13a13e6344
2024-03-14 16:43:14 -04:00