Commit Graph

67153 Commits

Author SHA1 Message Date
Cole Faust
be7e47f8ec Remove dependencies on the 1-variant fallback
When adding a dependencies, if the variants don't match, but the
dependency only has 1 variant anyways, soong will always use that
variant. This makes it hard to add new variants to soong, because the
1-variant fallback stops being used and you start getting missing
variant errors. Make changes to bp files such that all dependencies
correctly specify the variant to use.

Bug: 372091092
Flag: EXEMPT refactor
Test: m nothing
Change-Id: Ia820b73e20525ff35c9a8bf8179eb63869857988
2024-10-22 16:30:58 -07:00
Daniel Zheng
50297cce15 Merge "bootctl: pass cookie to death recipient" into main 2024-10-17 20:09:23 +00:00
Treehugger Robot
8b5691175c Merge "threadnetwork: Avoid execute command if service does not exist" into main 2024-10-17 15:07:17 +00:00
shihchienc
ae9ea3c896 threadnetwork: Avoid execute command if service does not exist
We might run VTS when the thread_network service is not available. This
patch prevents shell commands from being executed if the service is
absent.

Bug: 374009923
Bug: 355317617
Test: atest VtsHalThreadNetworkTargetTest
Change-Id: I94dd7e2e7585e061f53291c47e46841e5e670b6c
2024-10-17 06:29:42 +00:00
Treehugger Robot
3f53c5c185 Merge "Move modules in compatibility_matrices/Android.bp" into main 2024-10-17 03:17:31 +00:00
Jason Macnak
08ae9df3de [automerger skipped] Avoid leaking RenderEngine am: 5eb07e3b88 am: 9cbed70311 -s ours
am skip reason: Merged-In Ief71d8931ec3560780a850d8bb8bc727bbff5c52 with SHA-1 64f73a4c5f is already in history

Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3311018

Change-Id: I58144d977c7e51f7896a394013d7da8dfe671983
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-10-16 22:48:42 +00:00
Jason Macnak
9cbed70311 Avoid leaking RenderEngine am: 5eb07e3b88
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3311018

Change-Id: I0740d094839bce59a89bf02ad5d8c600f30c06f7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-10-16 22:33:15 +00:00
Daniel Zheng
d5d0c5500a bootctl: pass cookie to death recipient
On binder death, the cookie is the value that is passed to the death
recipient. This value shouldn't be nullptr here since our onDeath()
function expects an instance of BootControlClientAidl. If that doesn't
exist, we have a null pointer dereference which will cause update_engine
to crash.

Bug: 369289491
Test: crash bootctl service
Change-Id: I0bed4680c23b7d3516ed43aa566c4474962244fa
2024-10-16 14:04:19 -07:00
Jason Macnak
5eb07e3b88 Avoid leaking RenderEngine
... as this might allow an underlying `RenderEngineThreaded` thread
to race.

Bug: b/368983946
Test: stress test of VtsHalGraphicsComposer3_TargetTest
Bug: b/361574971
Test: ATP cuttlefish_gfxstream_guest_angle_graphics_vts_tests
(cherry picked from https://android-review.googlesource.com/q/commit:64f73a4c5fdc79a882c9047e69d9f64b89c013b9)
Merged-In: Ief71d8931ec3560780a850d8bb8bc727bbff5c52
Change-Id: Ief71d8931ec3560780a850d8bb8bc727bbff5c52
2024-10-16 18:18:21 +00:00
Andrea Orru
03cafd0b65 Merge "keymaster_benchmark: remove usage of base::CommandLine" into main 2024-10-16 01:40:22 +00:00
Devin Moore
1484f11a84 Merge "Override AIDL CAS HAL if HIDL is built" into main 2024-10-15 21:47:00 +00:00
Yifan Hong
2b10d4d109 Merge "health storage inherit root OWNERS." into main 2024-10-15 20:13:02 +00:00
Aditya Kumar
475a24dd71 Merge "error: no matching constructor for initialization of 'std::ifstream'" into main 2024-10-15 18:41:31 +00:00
Andrea Orru
46591a9c48 keymaster_benchmark: remove usage of base::CommandLine
As part of the effort to uprev libchrome in Android, we are trying
to remove Android dependencies to libchrome that are not strictly
required.

Bug: 360917504
Test: Presubmit
Change-Id: Icce3f3a6c075509968d3565aec3153c4771ebb2d
2024-10-15 09:24:45 +00:00
HONG Yifan
6f5ba92e92 health storage inherit root OWNERS.
Test: TH
Fixes: 0fe0782761
    ("Split out health.storage OWNERS file")
Bug: 296950573
Change-Id: Ic975b0dc6efa4e9660e038695a47ffedd1c208bc
2024-10-14 22:06:56 -07:00
Treehugger Robot
78b668e4a9 Merge "Add frozen: true|false to all AOSP HALs that don't have frozen" into main 2024-10-14 22:55:12 +00:00
Aditya Kumar
a4bdedeb20 error: no matching constructor for initialization of 'std::ifstream'
```
hardware/interfaces/automotive/ivn_android_device/impl/default/src/IvnAndroidDeviceService.cpp:51:19: error: no matching constructor for initialization of 'std::ifstream' (aka 'basic_ifstream<char>')
   51 |     std::ifstream configStream(mConfigPath);
      |                   ^            ~~~~~~~~~~~
```

Bug: b/353528991
Change-Id: I7530772fdd758f41714db36e50c1d82189f46528
2024-10-14 19:06:29 +00:00
Justin Yun
160bfcb509 Move modules in compatibility_matrices/Android.bp
New framework_compatibility_matrix module will be autogenerated and
attached at the end of the Android.bp file. To avoid conflict, move
the other modules above the system compatibility matrix modules.

Bug: 331696132
Test: ./bump.py 202504 202604 w x
Change-Id: Ic70094a216549902ea1c20caebf5605abd7036ab
2024-10-13 19:15:25 +09:00
Treehugger Robot
0de4aa3c22 Merge "Remove Android.mk from bump.py" into main 2024-10-12 01:02:43 +00:00
Devin Moore
3227acc073 Remove Android.mk from bump.py
The file no longer exists and everything is handled in the Android.bp
file instead. The script was previously modified to handle the
Android.bp file.

Test: build/make/tools/finalization/build-step-0-and-m.sh cf_x86_64_phone
Bug: 331696132
Change-Id: I08bd6d40fd4b003d9c5f927e06288922c5e16202
2024-10-11 23:15:40 +00:00
Mikhail Naganov
05fc6aa383 audio: Fix AudioRecordTest#testTimestamp CTS on CF
After experimenting, it seems that the input poll
is more stable after the PCM input on CF has just
been opened. Since calling 'flush' on an input
stream puts it into the 'STANDBY' state, explicitly
call 'StreamAlsa::standby' after 'flush' in the
primary input stream implementation.

Bug: 340899868
Bug: 362852052
Bug: 372951987
Test: atest CtsMediaAudioTestCases
Test: atest VtsHalAudioCoreTargetTest
Change-Id: Ic1df6835ce00323ca3f0905ea46d3bc151e05fc4
2024-10-11 14:09:40 -07:00
David Drysdale
25876eb8d1 Merge "KeyMint: coalesce device ID failure code" into main 2024-10-11 07:46:16 +00:00
David Drysdale
7b05efd13f KeyMint: coalesce device ID failure code
Test: VtsAidlKeyMintTargetTest
Change-Id: I7c94af96010f5c5f708f54bf02e0f85a96cece3f
2024-10-10 18:19:51 +01:00
Daniel Zheng
cba986107b boot_control: use overrides
BootControlClientAIDL and BootControlClientHIDL are child classes of BootControlClient. We should
use proper inheritance and override the base class methods.

Test: th
Change-Id: Ia741f28bc463b55dc075a17901a024566324564a
2024-10-10 09:57:38 -07:00
Treehugger Robot
3f4c251a00 Merge "audio: Deprecate StreamSwitcher" into main 2024-10-10 16:08:26 +00:00
Mikhail Naganov
92166144a2 audio: Deprecate StreamSwitcher
Use of StreamSwitcher causes threading issues with the FMQ due to
using it in a way which is not anticipated by the FMQ design.

Stream implementations that need to change its behavior depending
on connected devices must do it without changing the I/O thread.
For example implementations please refer to PrimaryStream and
RemoteSubmixStream.

The class code has been moved to 'deprecated' directory and
namespace, and will be removed in the future. Any classes which
currently depend on StreamSwitcher should be updated mechanically
to use the new name and the include file location. Such classes
need to be planned to be overhauled as soon as possible to remove
the dependency on StreamSwitcher.

Bug: 300130515
Test: m
Change-Id: I6b0d20274013826360ca5efa69a01df9457db9c6
2024-10-09 18:19:27 -07:00
Daniel Zheng
c15d064c4a Merge "boot_control death recipient" into main 2024-10-10 01:10:11 +00:00
Daniel Zheng
28b6b2b1b6 boot_control death recipient
When boot control service dies, we should log that it is no longer
available. To do this, we should register a death recipient in the
client.

Bug: 369289491
Test: kill bootctl service while running OTA
Change-Id: If766451cafe939725e7a88b1ca23b2a4af0d1a80
2024-10-09 21:19:44 +00:00
Treehugger Robot
70c35c3986 Merge "ExternalCameraHAL: Get old image if taking picture without preview" into main 2024-10-09 17:28:50 +00:00
jimmyshiu
8c8c1c1215 [automerger skipped] VTSHalPowerTarget: check if HintSession supported am: f5a213c5ed -s ours am: afeb6bbb8c -s ours
am skip reason: Merged-In Ia1161aeafcd541745e7e0da1bd4c1781dc535460 with SHA-1 92e08f9387 is already in history

Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3269678

Change-Id: I1b3e273f9a01abf0f83304abb081320756ce5bef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-10-09 07:54:56 +00:00
Tomasz Wasilczyk
0b06be49cc Remove unused global const variable am: 6dc643db27 am: 16e747fe60
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3298493

Change-Id: Ie8fc6494c582e305e91e84383e7e7f46b0b81e78
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-10-09 07:54:54 +00:00
Matt Buckley
4562fbb120 [automerger skipped] Refactor Power VTS in terms of AIDL version am: 87f9c220b5 -s ours am: b2c1536da9 -s ours
am skip reason: Merged-In I3cef31fa8dc6341a47d173a13d07521bafe4a1e5 with SHA-1 42027e0ee7 is already in history

Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3298492

Change-Id: Ia6030e58c30837ad386cb5e52dbdbdfda4ae4e76
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-10-09 07:54:51 +00:00
jimmyshiu
afeb6bbb8c [automerger skipped] VTSHalPowerTarget: check if HintSession supported am: f5a213c5ed -s ours
am skip reason: Merged-In Ia1161aeafcd541745e7e0da1bd4c1781dc535460 with SHA-1 92e08f9387 is already in history

Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3269678

Change-Id: I92fcf31cad3022e32292717a874039be69666660
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-10-09 07:40:50 +00:00
Tomasz Wasilczyk
16e747fe60 Remove unused global const variable am: 6dc643db27
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3298493

Change-Id: I881c63488eee3a8dbe796f0d0d5912b929391b08
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-10-09 07:40:42 +00:00
Matt Buckley
b2c1536da9 [automerger skipped] Refactor Power VTS in terms of AIDL version am: 87f9c220b5 -s ours
am skip reason: Merged-In I3cef31fa8dc6341a47d173a13d07521bafe4a1e5 with SHA-1 42027e0ee7 is already in history

Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3298492

Change-Id: I304305f50a7449495bf97b6920cc31c2b771846f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-10-09 07:40:38 +00:00
jimmyshiu
f5a213c5ed VTSHalPowerTarget: check if HintSession supported
Igore HintSession testcases while HintSession isn't supported.

Test: atest Power/PowerAidl
Bug: 322112957
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:8191575b6717e99d00b247c6a21b29cda7eb3a52)
Merged-In: Ia1161aeafcd541745e7e0da1bd4c1781dc535460

Change-Id: Ia1161aeafcd541745e7e0da1bd4c1781dc535460
2024-10-08 09:24:03 +00:00
Tomasz Wasilczyk
6dc643db27 Remove unused global const variable
Bug: 175635923
Test: MODULES-IN-hardware-interfaces-power
Change-Id: Ie73f48df62a17b309c774b2f446db3ee53b3863b
2024-10-08 09:23:54 +00:00
Matt Buckley
87f9c220b5 Refactor Power VTS in terms of AIDL version
Rewrite Power VTS check support using AIDL versions instead of
API versions, and change hint session tests to use a common test
fixture.

Bug: 294917526
Test: atest VtsHalPowerTargetTest
Merged-In: I3cef31fa8dc6341a47d173a13d07521bafe4a1e5
Change-Id: I3cef31fa8dc6341a47d173a13d07521bafe4a1e5
2024-10-08 09:23:23 +00:00
Treehugger Robot
0a2b52b3e4 Merge "Add VTS for setAudioPortConfig with invalid gain" into main 2024-10-07 22:34:42 +00:00
Weilin Xu
349aea2127 Add VTS for setAudioPortConfig with invalid gain
Added test for setAudioPortConfig with invalid gain input in audio HAL
VTS. Also added HAL version check in audio HAL VTS.

Bug: 336370745
Test: atest VtsHalAudioCoreTargetTest
(cherry picked from commit 7f1ab0c33c)
Merged-In: I0f14c203c253de56ca0c3711927b2dcafa1b0ea7
Change-Id: Ib0b0d7266e249359f2750412f3fbabe1b2be958e
2024-10-07 14:57:24 -07:00
Mikhail Naganov
ee843ed4a2 Merge "audio: Add AC-4 level 4 audio format to schema" into main 2024-10-07 21:29:15 +00:00
Mikhail Naganov
ea4241bda3 Merge "audio: Do not use StreamSwitcher for StreamRemoteSubmix" into main 2024-10-07 17:01:08 +00:00
Fang Hui
8c428d7ad2 ExternalCameraHAL: Get old image if taking picture without preview
The root cause is that the dequeue/queue v4l2 buffers is driven by requests.

The potential issue is already noticed and commented in commented in OutputThread::threadLoop().
But setup a sensor thread may need change in architecture.

The patch fix the issue by dropping too old buffers.

Bug: 368087676

Change-Id: I5d6711bc3a73d0bc043b596aee6ce4af4c1841da
Signed-off-by: Fang Hui <hui.fang@nxp.com>
2024-10-05 17:50:49 +08:00
Mikhail Naganov
e976625a49 audio: Do not use StreamSwitcher for StreamRemoteSubmix
Since use of StreamSwitcher causes the worker thread to be changed
during connected device change, its use must be avoided. We intend
to remove StreamSwitcher completely in future.

Bug: 300130515
Bug: 338974476
Bug: 368723297
Bug: 369272078
Bug: 369289912
Bug: 369964381
Test: atest CtsMediaAudioTestCases
Test: atest VtsHalAudioCoreTargetTest
Change-Id: I4f6fd35f69d73641a86e1102f1d30d5e8f626e8f
2024-10-04 18:51:46 -07:00
Yu Shan
51d6329919 Fix unknown VehicleApPowerStateReport ON.
Fix an incorrect error message for VehicleApPowerStateReport ON.

Flag: EXEMPT HAL fix
Test: Manual test
Bug: 371614400
Change-Id: I81406931d27e2f8b174b52720d4f502e0e32fdd4
2024-10-04 14:20:08 -07:00
Treehugger Robot
50956bd1cf Merge "audio: Do not use StreamSwitcher for StreamPrimary" into main 2024-10-03 21:48:38 +00:00
Mikhail Naganov
f5ec73e546 audio: Do not use StreamSwitcher for StreamPrimary
Since use of StreamSwitcher causes the worker thread to be changed
during connected device change, its use for the primary HAL streams
must be avoided. The reason is that switching of the FMQ reader thread
accompanied with simultaneous writes from two writers: one on the
framework side, another on the HAL side sending the "exit" command,
violates threading assumptions of blocking FMQ and causes spurious
races that eventually make FMQ non-functional.

Bug: 300130515
Bug: 368723297
Bug: 369272078
Bug: 369289912
Bug: 369964381
Test: atest VtsHalAudioCoreTargetTest
Change-Id: I14dc6fc08ae9e8aaaf3cd80e96b20dd1df54f633
2024-10-02 17:11:43 -07:00
Devin Moore
34a3c0bdc9 [automerger skipped] Add a new known hash to drm am: 8fc1714797 -s ours
am skip reason: Merged-In I9e90ada03144b49245dc6b55a0fb2fa2eb6f3893 with SHA-1 2ae7fb6e55 is already in history

Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3291162

Change-Id: Ic761e2a46814ba2f0ed4cd289ae45f7f87d11ec3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-10-02 23:51:04 +00:00
Devin Moore
8fc1714797 Add a new known hash to drm
The types were split into another package so some newer devices are
using this new package.

The topic was cherry-picked but the branch configs made a mess. So we
are only cherry-picking this new hash for tests.

The new hash is added first, because the last hash in the file is
expected to the be current hash.

Bug: 293945485
Bug: 364817993
Test: build cuttlefish on this branch

Merged-In: I9e90ada03144b49245dc6b55a0fb2fa2eb6f3893
Change-Id: I6d3ef12301532d8b3fb8729abbbe6bd2dde86c91
2024-10-02 22:51:27 +00:00
Weilin Xu
21c8770923 Enable bus device audio in default audio HAL
Bug: 336370745
Test: atest VtsHalAudioCoreTargetTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:e9f7cf5a8495d11d92760bac5238eedb9dd5ea72)
Merged-In: I7d9ab165f3208f401a9889623050374ed6aea691
Change-Id: I7d9ab165f3208f401a9889623050374ed6aea691
2024-10-02 19:35:32 +00:00