VTS readback tests were crashing because RenderEngine before LayerSettings were deleted. LayerSettings holds onto ExternalTexture, which calls back into RenderEngine to clean up texture objects, so this was causing a UAF issue.
Bug: 372063484
Test: VtsHalGraphicsComposer3_TargetTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:92a3161ed6a89858f95e03ce981ce7a4ed19b396)
Merged-In: Iad39e1a4aa9a9488af54742df121a981756b6275
Change-Id: Iad39e1a4aa9a9488af54742df121a981756b6275
- Add new defaults for Rust and AIDL graphics HAL library references
- Migrate HAL interfaces to use new AIDL defaults
This is in preparation for upgrading the graphics.common HAL to V6.
Test: Builds
Bug: 368395888
Flag: EXEMPT build changes
Merged-In: I9d312328255226fbd7162b9dfd151dfa823f1858
Change-Id: I9d312328255226fbd7162b9dfd151dfa823f1858
YCBCR_P210 is a 10-bit 4:2:2 YCbCr color format
Test: Builds, camera/media/graphics CTS continues to pass
Flag: EXEMPT HAL interface change
Bug: 368395888
Merged-In: I6609870be75675dd08c2203d4b5be49ebd1de447
Change-Id: I6609870be75675dd08c2203d4b5be49ebd1de447
... as this might allow an underlying `RenderEngineThreaded` thread
to race.
Bug: b/368983946
Test: stress test of VtsHalGraphicsComposer3_TargetTest
Bug: b/361574971
Test: ATP cuttlefish_gfxstream_guest_angle_graphics_vts_tests
(cherry picked from https://android-review.googlesource.com/q/commit:64f73a4c5fdc79a882c9047e69d9f64b89c013b9)
Merged-In: Ief71d8931ec3560780a850d8bb8bc727bbff5c52
Change-Id: Ief71d8931ec3560780a850d8bb8bc727bbff5c52
... as this might allow an underlying `RenderEngineThreaded` thread
to race against the process shutdown.
Bug: b/361574971
Test: ATP cuttlefish_gfxstream_guest_angle_graphics_vts_tests
Change-Id: Ief71d8931ec3560780a850d8bb8bc727bbff5c52
The conversion skip the if condition for
TARGET_USES_DISPLAY_RENDER_INTENTS due to the cflag it set is never
being used actually.
Bug: 368204639
Test: m android.hardware.graphics.composer@2.2-service
Change-Id: I7347fa5cef192385f94954f620bebee6a24ebb82
Summary: It looks like the verbose log debug flag was set during the introduction
of this header and continued to be propagated forward. Since this define
is done in a header, it is forcing verbose logs on for anything which
includes the header.
Test: See less logspam from components including this header
Change-Id: I678ee3384a0a5b13c684a7e14c3358f70a7def30
Signed-off-by: Abhishek Gadewar <abhishekgadewar@meta.com>
null pointer dereference crash will be triggered if vector errors
is emptry when accessing errors[0].errorCode, so change EXPECT_EQ
to ASSERT_EQ to avoid this issue.
Test: run vts -m VtsHalGraphicsComposer3_TargetTest
Signed-off-by: Liu, Kai1 <kai1.liu@intel.com>
(cherry picked from https://android-review.googlesource.com/q/commit:aec33e9a41e4bccfd1834e1ab03f785eea4f0b52)
Merged-In: I3b30d491ef886b98e462447e6de78828e7822fca
Change-Id: I3b30d491ef886b98e462447e6de78828e7822fca
Vndk_use_version property is no longer in use with deprecation of VNDK.
Remove Vndk_use_version property and its usage.
Bug: 328994089
Test: AOSP CF build succeeded
Change-Id: I681cc850341a7dc47416dc81c1da21b687f87b1b
```
warning: format specifies type 'unsigned int' but the argument has type
'IComposerClient::Command' [-Wformat]
```
Change-Id: I9a585330ef1edd7675e6406318bd966b03c8a209
Add more information to the failure message: now it looks something like `Failed to get a callback for Display 0 switching from {Config 38: vsyncPeriod 4166666, minFrameIntervalNs 16666667} to {Config 37: vsyncPeriod 8333333, minFrameIntervalNs 8333333}` instead of `failed to get a callback for the display 0 with config 37`
Test: atest VtsHalGraphicsComposer3_TargetTest:PerInstance/GraphicsComposerAidlCommandV2Test#SetRefreshRateChangedCallbackDebugEnabled_SetActiveConfigWithConstraints/0_android_hardware_graphics_composer3_IComposer_default
Bug: 340971724
Change-Id: Id2a1030a9b12e86bda8f6031e79a8374227f4061
Some device's readback buffers do not support alpha, so rendering golden
images should also not use alpha.
Bug: 335805098
Test: VtsHalGraphicsComposer3_ReadbackTest
Change-Id: I153ea1707b9fd8113529b8c18fa90711acfad04e
Stable-c mapper instance should be declared in two ways:
- vintf manifest
- service_contexts
The latter part was missing.
Bug: 336010345
Change-Id: I7bd776bf7d943049ef319c90739dae10071409ab
Test: documentation
This appears to have been broken with
Ic3c0415612b1387671ab8efa0ec95ed727f6bf68, which attempts to destroy
layers for all displays using a single writer. The display command that
destroys a layer must be in the writer for that display, in order for
the displays to run independently. Do so in the test itself, rather than
relying on TearDown to destroy all of them.
Bug: 333974982
Test: atest VtsHalGraphicsComposer3_TargetTest
Flag: TEST_ONLY
Change-Id: Ib6807c85bc6cb32c56cc72126a9fa68363365912
The update process for prebuilts/abi-dumps/platform will be adapted for
trunk stable. The ABI dumps for libimapper_stablec are moved to
"abi-dumps" in this project so that the trunk stable release process
will not affect them.
Test: m libimapper_stablec_abicheck
Test: development/vndk/tools/header-checker/utils/create_reference_dumps.py \
-libs libimapper_stablec_abicheck --lib-variant PLATFORM \
-ref-dump-dir hardware/interfaces/graphics/mapper/stable-c/abi-dumps \
-products aosp_arm64
Bug: 333532038
Change-Id: Ia69daa721ef983c18118bd6d0a70dd5b7a0a47a2
As of VNDK deprecation, any libraries that defines vndk is no longer
valid anymore. This change removes all VNDK definition(s) from modules
which was VNDK.
Bug: 328994089
Test: AOSP CF build succeeded
Change-Id: Ifdade9c052db29c989ce7d804ba725361c4c0f8e
Merged-In: Ic4f19113c1a25dc1fb60cdfbf9c0f2d8d7d09726
With different VRR modes we may have 2 modes with
exactly the same minFrameIntervalNs, and in this case we can't
differentiate between 2 modes.
Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 328350178
Change-Id: I5cddfee8b789ed6ce1b223ec345175f19a0db091
Some HWC implementations which do not support DISPLAY_DECORATION are
handling DISPLAY_DECORATION layers in VTS by reporting an error (as
required by the test) AND by proposing ChangedCompositionTypes. The
latter is unnecessary, as SF will never read the changed types. Update
the documentation to be more specific that this is unnecessary.
Bug: b/324977561
Bug: b/329119344
Bug: b/329017438
Bug: b/327322951
Bug: b/327090469
Test: GraphicsComposerAidlCommandTest#DisplayDecoration
Change-Id: I09c90e40818dc43b968c3e79e61e8b13a13e6344
As of VNDK deprecation, any libraries that defines vndk is no longer
valid anymore. This change removes all VNDK definition(s) from modules
which was VNDK. Any former VNDK-SP libraries will be marked as double-loadable,
so it can keep be able to be referenced by LLNDK libraries.
Bug: 328994089
Test: AOSP CF build succeeded
Change-Id: Ic4f19113c1a25dc1fb60cdfbf9c0f2d8d7d09726
Ignore-AOSP-First: Merge conflict
- add sRGB and DisplayP3 layers in HWC, if mixedColorSpaces is
supported, only DPU composition happens.
Bug: 311252937
Test: this
Change-Id: I400a6dd18a05bbdf69e249907e13a4fa7eafbf01
Includes VTS for notifyExpectedPresent call,
frameRate change in the present call and
notifyExpectedPresent after timeout.
Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 291792736
Change-Id: I1ef7011d7dcbdd6bb378b80ca0b0d7cd52832897
It's not supposed to be sign-extended as that blocks off the entire
28-64 bit range instead of the 28-31 bit range as indicated in the
comment
As this value is correct in HIDL and in the docs, do a history
re-write of the AIDL value to match the intended (and previous)
values.
Test: make
Bug: 323484008
Change-Id: I0b373576a366c853c87109a9b24ec9f8d9cbdb4d
